From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA81C27C4F for ; Fri, 21 Jun 2024 23:06:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C16A8D01AA; Fri, 21 Jun 2024 19:06:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 570768D0196; Fri, 21 Jun 2024 19:06:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EA1C8D01AA; Fri, 21 Jun 2024 19:06:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 214D78D0196 for ; Fri, 21 Jun 2024 19:06:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A61A6A3DC2 for ; Fri, 21 Jun 2024 23:06:31 +0000 (UTC) X-FDA: 82256431782.07.DE6613F Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf08.hostedemail.com (Postfix) with ESMTP id B6B4616000D for ; Fri, 21 Jun 2024 23:06:28 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XdCOS6/E"; spf=pass (imf08.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719011177; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VmJJqF0Z9kdA9Tn6NolRkYmbDu11OVzx3VE4wX/FoVw=; b=6T3FDCrDgd5w2ND1vZMIuJMPgzolbAjaZ+AMBt/KkhIQIlBjhQOMaiLkHPBV/gS4m3+y/i Nc9UsZ6WggEyn55HZ/k8kB8UP0J8LoNXfP5mxVd26m39ZzjhT+3Crc8Gz0DYmY3x9LS0rx 2yIOCo1hvT0PCu3FFiTacZPkS4sdsfo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719011177; a=rsa-sha256; cv=none; b=XtB9buE/PJL6Ef45MyqBEs6O/clTMpsK5PJB0TmDyXy7vHwqre0MNPTQeI+7upnRT5s4zH /luH2PVLCulDsNLi+h1ad27kIRicBf1b9bzx2ZcxYTitCLCsqAY2XmpmDqUT1skZUR/5Av ljnWaeH58RfP9DHAxBRtiFSpkY25+7A= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XdCOS6/E"; spf=pass (imf08.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a62ef52e837so298460966b.3 for ; Fri, 21 Jun 2024 16:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719011187; x=1719615987; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=VmJJqF0Z9kdA9Tn6NolRkYmbDu11OVzx3VE4wX/FoVw=; b=XdCOS6/EffwXz2BR0yoOVegqvmQfmJe0M6POFGVlJaAg2TLan8YhbeyTeQbzV9dxf3 M9aq/XiFjd04UeUY9KDsNiQ3hLnzBsH0tCJJrp3Xdnx8hcnZB9EtoPMc0b56ASdcqFuZ zS4nWim3ubwvci7gfiJN9Ua9fxsmMM/hlcCSMcX0XbomkMFgC8NO//i5QSupuubb1j63 /fH+iC8qW9I2+KUREhq6BOG4aSa41LYmQ9hi8x5wEn9CxWeJrqW7f5dAKyJxOTA2I8h8 7TGqkvxozU2WjBB8PegQ9aKJ/+0gNe9LcmjO3pUenXPEeBC0W4RYNovz7APMYwx+sIpo 7hCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719011187; x=1719615987; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VmJJqF0Z9kdA9Tn6NolRkYmbDu11OVzx3VE4wX/FoVw=; b=ICYoU3vcpf89og8ZO3e0pMwSzCX5RCA+X5FVotTS9c9dwYF/b5OQS9pV3TDsWJ7cl2 lKuyA41T4m2Ub8NfcA1tZzRgdWq2y5DUsKh+7fJPIOKoo82SWoeGeCapt84NLjrGTkMV COoZxrsBub6F9jRDM0bE7ydIw6FiHNSkeuVAkUh6o8hnoQL58DpKgKa7RqUFEimSrHh9 xy1wNTj7UDxSbAubDdQr1g8DByo9LVuBg/ZxrLgcjMlcbJ5MLVzdtPUihdMjUXKBkjTk QPGqiBQc2tePeSQhk5JRYbksj8/pYvbueJVyylXjISHHA2os/YdrP8INsyBdmewTAhby GkFg== X-Forwarded-Encrypted: i=1; AJvYcCXoBTM/7DwnNPUflBPXOcfkNWve8s/5TNy9uClMp4G22d5yhyFXFr3ZvUqP5BUPm+dRE9Cp7bk23eTIN6VqOBRZFgE= X-Gm-Message-State: AOJu0Yz5t7o2fpeZlvk59dEkF7DAm6dyK8q/5IoC2eb7se5JDJxvgXyx SsDdWkQQPST7jjfDYGc2FPYi1Pq8+7IhuNjlRAe3KmDaGddEf4J1 X-Google-Smtp-Source: AGHT+IEfHi7fn853XIjn6j7g0LHb55aXTn1icqa190hU3/PA8FgUR91O7DWpcyu86L4WHxyy32scwQ== X-Received: by 2002:a17:906:d8db:b0:a6f:16c7:9130 with SMTP id a640c23a62f3a-a6fab61b4bemr602666966b.28.1719011186899; Fri, 21 Jun 2024 16:06:26 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6fcf549075sm129288466b.98.2024.06.21.16.06.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Jun 2024 16:06:26 -0700 (PDT) Date: Fri, 21 Jun 2024 23:06:25 +0000 From: Wei Yang To: Guenter Roeck Cc: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, Paul Mackerras , Tejun Heo Subject: Re: [Patch v3] mm/memblock: remove empty dummy entry Message-ID: <20240621230625.7nopxs226k7oagm5@master> Reply-To: Wei Yang References: <20240405015821.13411-1-richard.weiyang@gmail.com> <8d6205d4-18fb-4e98-97e6-db226dcf48f3@roeck-us.net> <20240621010713.cyai3pkucbp7v7r5@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: 5z49eg6ydd8dczw1e5y6qy3g86qjuug1 X-Rspamd-Queue-Id: B6B4616000D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719011188-456232 X-HE-Meta: U2FsdGVkX18Ws4tRtKcn76lMwYBGwr9ssEezguQdICGIrhWdhMwU/0Y5ydCvBHIff/R1QeFXFFY5RTuVqyMXlUm1YGa9h9Ex7k4oMHHSXRkhQRGloSX88dY2C0RVrMTq7kTyr/P4bX5XpAV55rqOHTUT5dL4kfUEAjuufCtGh2b9tNORkJR58mlWbHncGAbmNpmaJrynnWiykv0UyPua2lglr/AJcS/P0izb6ml0kYyTh5cuvEOkTtJCpDKSgtfrZT7slbZEidaohB+2uiKLej5R6S+wX0S4DKldYDtt4sxe93wbP9jkHbIi+nU/tl/QNa9n1i/PnKmRRyeeDnWFb1NaYNKb4S4OKo1Y7EYeLjqw35BxjwUMSIXMUtKMlN/Y7DyWBbX9fvcOJmN6JPqQwxJWixf0uacuf3F1/XhiWDsQ3sUzBxba+KqX14LNzuckLaEPiuUL2AyFMNxD2pmgZHjdXjeNgHp4Nvdi15vcJD7z6NGqoI73EjwQm55pqd6lS7V1MpDG5FsA0wlkM9ny0aIlKumcxdoXDa/41IbSrf5b8ffk+Difb8prlhZdRNqgaxa7ChzENN/KBkKdM4MMRvTZQDIReUnOzFbWtJOpvNMHBjqM/OfEknXMLwqRlSb0QqAts3YuOClc2+O5hg+IoAaWZV/IyC1Q4gvXh5Ipc2oyV8FOCM1wbsVQAnwL65sqyzWtZ4+Zx3lpWC1yztSoJkgejl9+CzsS6BUruyKNhc7E3kGmOUpnGPM4WghUFrz0uoFieIHIbkwHTq+CfX1eiSXoYalUlFSYfT+MxQPkm+gzj+Q4mtNmZQshtl/uAYGvzHQcYVW/7R9v0wgIqKfP694Si1arSUprvM3Y5GwAa+eek+cKHQ74Op68QD3Tz/hzV6DfA5RRJsx0j084M9RKIpmKAI72txhaTDiZFX0zNPCffGC/7KuuCbn1N48NfsSx7EqzkvHhYjWxAnRkknJ fRwnRxRT gLy2DSKgf1O8b1k5ZVkVq89egwBl/kp1APq33mV43WDYVud0Z17HQ+SHfs3eWsMvgcdyMPrgESJY1wESmxi49wx6TGL32ZBvWnrK05Qla5cOvHOY8xlpxZaLHQiI5CSDBfKUMd9aZmd8IijRaQqaBuoNO5eDx48ulhKuar4Cr04vu/NDIndh4pSNcE4KpWoN5R3ChvBYvD1LsfjSiD/1I5jP612bWLM1g3pNZaIkUjDBrC9GZNnmiAS+iuAY+aT0TugNtfP31PrU3xcX52LK+yg7pI/d5regaqP4Hjt9QrAXk5W5vMYMJvy16VN8W6PU4e2is1+U+vokDZ/b3LzA+XwBI4vqCCUINBvS4xJI2V0M9IvrxUFpNgEHc9Xy/n3WhF6o9/RdBq6sh+oKNA6X9j9rNyW7ZgXL8T2++4PZsIjm9Sq5iz5pwyezyzxKZuGW/soURNhtyRlGgD9CH/AiQZNtA3Y0KPftpK9XGMfOMh2oKlfQMjVvrqtN90FPmTP9WPZrWIhyjd4T9ekWK42BwcRteU9KaeFt/VLws9NjNDh5d/K3QUaW4sazBDR6XsYDsk3zJQ31Kf1cTRRpZFUwNQvd4uu64ZY6lb9akU6FgMidHrxPgl91d2k93NEMd5MZmRjLWiwaW8zEXSM9WBxZEk4ZDglbW0XKzQo9L2ZF+dGDjSYjHrJLsEdI4JZ7gRYFCMiKnqoTM5fAHCMk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 20, 2024 at 07:34:06PM -0700, Guenter Roeck wrote: >On 6/20/24 18:07, Wei Yang wrote: >> On Thu, Jun 20, 2024 at 02:58:17PM -0700, Guenter Roeck wrote: >> > Hi, >> > >> > On Fri, Apr 05, 2024 at 01:58:21AM +0000, Wei Yang wrote: >> > > The dummy entry is introduced in the initial implementation of lmb in >> > > commit 7c8c6b9776fb ("powerpc: Merge lmb.c and make MM initialization >> > > use it."). >> > > >> > > As the comment says the empty dummy entry is to simplify the code. >> > > >> > > /* Create a dummy zero size LMB which will get coalesced away later. >> > > * This simplifies the lmb_add() code below... >> > > */ >> > > >> > > While current code is reimplemented by Tejun in commit 784656f9c680 >> > > ("memblock: Reimplement memblock_add_region()"). This empty dummy entry >> > > seems not benefit the code any more. >> > > >> > > Let's remove it. >> > > >> > > Signed-off-by: Wei Yang >> > > CC: Paul Mackerras >> > > CC: Tejun Heo >> > > CC: Mike Rapoport >> > > >> > >> > With this patch in linux-next, all microblaze qemu images fail to boot. Reverting it >> > fixes the problem. >> > >> > Bisect log is attached for reference. >> > >> >> Thanks for the reporting. >> >> Would you mind running the test to take a look? >> >> It is in tools/testing/memblock. Simply make and ./main. >> This is a user-space test case, would you mind running it with this commit applied? > >This is a silent failure. There is no console output, so the image crashes >before it gets to that point. > >Building microblaze:petalogix-s3adsp1800:initrd ... running ................R............. failed (silent) >------------ >qemu log: >qemu-system-microblaze: terminating on signal 15 from pid 2343410 (/bin/bash) > Would you mind add kernel parameter memblock=debug without the commit applied? If my understanding is correct, you can bootup without this commit, right? >Guenter -- Wei Yang Help you, Help me