From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
Alexander Potapenko <glider@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Heiko Carstens <hca@linux.ibm.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Marco Elver <elver@google.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Pekka Enberg <penberg@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-s390@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
Sven Schnelle <svens@linux.ibm.com>,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH v7 24/38] s390/boot: Add the KMSAN runtime stub
Date: Fri, 21 Jun 2024 13:35:08 +0200 [thread overview]
Message-ID: <20240621113706.315500-25-iii@linux.ibm.com> (raw)
In-Reply-To: <20240621113706.315500-1-iii@linux.ibm.com>
It should be possible to have inline functions in the s390 header
files, which call kmsan_unpoison_memory(). The problem is that these
header files might be included by the decompressor, which does not
contain KMSAN runtime, causing linker errors.
Not compiling these calls if __SANITIZE_MEMORY__ is not defined -
either by changing kmsan-checks.h or at the call sites - may cause
unintended side effects, since calling these functions from an
uninstrumented code that is linked into the kernel is valid use case.
One might want to explicitly distinguish between the kernel and the
decompressor. Checking for a decompressor-specific #define is quite
heavy-handed, and will have to be done at all call sites.
A more generic approach is to provide a dummy kmsan_unpoison_memory()
definition. This produces some runtime overhead, but only when building
with CONFIG_KMSAN. The benefit is that it does not disturb the existing
KMSAN build logic and call sites don't need to be changed.
Reviewed-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
arch/s390/boot/Makefile | 1 +
arch/s390/boot/kmsan.c | 6 ++++++
2 files changed, 7 insertions(+)
create mode 100644 arch/s390/boot/kmsan.c
diff --git a/arch/s390/boot/Makefile b/arch/s390/boot/Makefile
index 526ed20b9d31..e7658997452b 100644
--- a/arch/s390/boot/Makefile
+++ b/arch/s390/boot/Makefile
@@ -44,6 +44,7 @@ obj-$(findstring y, $(CONFIG_PROTECTED_VIRTUALIZATION_GUEST) $(CONFIG_PGSTE)) +=
obj-$(CONFIG_RANDOMIZE_BASE) += kaslr.o
obj-y += $(if $(CONFIG_KERNEL_UNCOMPRESSED),,decompressor.o) info.o
obj-$(CONFIG_KERNEL_ZSTD) += clz_ctz.o
+obj-$(CONFIG_KMSAN) += kmsan.o
obj-all := $(obj-y) piggy.o syms.o
targets := bzImage section_cmp.boot.data section_cmp.boot.preserved.data $(obj-y)
diff --git a/arch/s390/boot/kmsan.c b/arch/s390/boot/kmsan.c
new file mode 100644
index 000000000000..e7b3ac48143e
--- /dev/null
+++ b/arch/s390/boot/kmsan.c
@@ -0,0 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <linux/kmsan-checks.h>
+
+void kmsan_unpoison_memory(const void *address, size_t size)
+{
+}
--
2.45.1
next prev parent reply other threads:[~2024-06-21 12:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 11:34 [PATCH v7 00/38] kmsan: Enable on s390 Ilya Leoshkevich
2024-06-21 11:34 ` [PATCH v7 02/38] kmsan: Make the tests compatible with kmsan.panic=1 Ilya Leoshkevich
2024-06-21 11:34 ` [PATCH v7 04/38] kmsan: Increase the maximum store size to 4096 Ilya Leoshkevich
2024-06-21 11:34 ` [PATCH v7 05/38] kmsan: Fix is_bad_asm_addr() on arches with overlapping address spaces Ilya Leoshkevich
2024-06-21 11:34 ` [PATCH v7 07/38] kmsan: Remove a useless assignment from kmsan_vmap_pages_range_noflush() Ilya Leoshkevich
2024-06-21 11:34 ` [PATCH v7 08/38] kmsan: Remove an x86-specific #include from kmsan.h Ilya Leoshkevich
2024-06-21 11:34 ` [PATCH v7 09/38] kmsan: Expose kmsan_get_metadata() Ilya Leoshkevich
2024-06-21 11:34 ` [PATCH v7 11/38] kmsan: Allow disabling KMSAN checks for the current task Ilya Leoshkevich
2024-06-21 11:34 ` [PATCH v7 14/38] kmsan: Use ALIGN_DOWN() in kmsan_get_metadata() Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 16/38] kmsan: Expose KMSAN_WARN_ON() Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 17/38] mm: slub: Let KMSAN access metadata Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 18/38] mm: slub: Disable KMSAN when checking the padding bytes Ilya Leoshkevich
2024-06-24 7:34 ` Vlastimil Babka
2024-06-21 11:35 ` [PATCH v7 19/38] mm: kfence: Disable KMSAN when checking the canary Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 20/38] lib/zlib: Unpoison DFLTCC output buffers Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 21/38] kmsan: Accept ranges starting with 0 on s390 Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 22/38] s390/boot: Turn off KMSAN Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 23/38] s390: Use a larger stack for KMSAN Ilya Leoshkevich
2024-06-21 11:35 ` Ilya Leoshkevich [this message]
2024-06-21 11:35 ` [PATCH v7 25/38] s390/checksum: Add a KMSAN check Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 26/38] s390/cpacf: Unpoison the results of cpacf_trng() Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 27/38] s390/cpumf: Unpoison STCCTM output buffer Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 28/38] s390/diag: Unpoison diag224() " Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 31/38] s390/mm: Define KMSAN metadata for vmalloc and modules Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 32/38] s390/string: Add KMSAN support Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 33/38] s390/traps: Unpoison the kernel_stack_overflow()'s pt_regs Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 35/38] s390/uaccess: Add the missing linux/instrumented.h #include Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 36/38] s390/unwind: Disable KMSAN checks Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 37/38] s390/kmsan: Implement the architecture-specific functions Ilya Leoshkevich
2024-06-21 11:35 ` [PATCH v7 38/38] kmsan: Enable on s390 Ilya Leoshkevich
2024-06-21 17:55 ` [PATCH v7 00/38] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621113706.315500-25-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=42.hyeyoo@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=svens@linux.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox