From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D05DC2BA18 for ; Fri, 21 Jun 2024 01:11:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73A0F8D0113; Thu, 20 Jun 2024 21:11:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E99D8D0111; Thu, 20 Jun 2024 21:11:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 589EB8D0113; Thu, 20 Jun 2024 21:11:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3B82F8D0111 for ; Thu, 20 Jun 2024 21:11:40 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E0A6A40709 for ; Fri, 21 Jun 2024 01:11:39 +0000 (UTC) X-FDA: 82253118318.17.0F87741 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf15.hostedemail.com (Postfix) with ESMTP id D229BA0008 for ; Fri, 21 Jun 2024 01:11:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bVX3A5Dh; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718932292; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=icQ/ZynCs7EX0R6bbe+3ACnBKW7J1c4bjca59pdSPaY=; b=dVxOanT2DRVPLMbctFJccUcJ4mjiJMMtfhFNvVHvuDbSp0vmYOHfmDfvPCZJncLHskofnz mDcflamW3kCN1qwmeN1Rxa0cSH2xa1SVXzngx+pTHDckP1anYwno7x0hBwfiyQwYpWWa3Q PnJaEAoLA9XiZSsuhMjJh9qkuTsFTJE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bVX3A5Dh; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718932292; a=rsa-sha256; cv=none; b=6sYcYCGDDrwlwC+5VSS2v/bi+osAtx+PwxrOpnKTSzoZBnuuxMS6mSkehBo2wPYX6OVeDM tuJHSpiW11CGef+1sHzn+squfsOHUXP0p0jeqOGsuuXdgOVtVe3fB6uwfyuDnujoQB5ICk 5gA0qwVipuTnk+4zVn0nRPoQJJa/EXk= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ebe40673d8so15702731fa.3 for ; Thu, 20 Jun 2024 18:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718932296; x=1719537096; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=icQ/ZynCs7EX0R6bbe+3ACnBKW7J1c4bjca59pdSPaY=; b=bVX3A5Dh21OhmRxMB2PMO/50x83Qy/MBD50dW2FT/j3tp00gpU0zSa4OPYicl3A901 cqQUJAmW8LxOHh7064BbcqPGQ4Jzdo5XlmPDwYCdxUYTz22j+DCC+MZ+ZsdvSuLgkUhh VS8KG8FwLEO1LLOsKn3fH38XXIfCCjSil/2xBJNvWtPKvIz4iToSBf0FSkaTDas/cfaA FgcgI2QOs0vdRfsVIFYk0/tmIh3STKTfi71lsz+At0qJsZ1TelhHf5M/KfRUDP3QOJdB HBYXR63goCM/fFgrTDgJrm+eFUXidXAUXe6K4gmtNk6BJ4//QTQmNVoY9+48yXMX2HHE rH6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718932296; x=1719537096; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=icQ/ZynCs7EX0R6bbe+3ACnBKW7J1c4bjca59pdSPaY=; b=FZPLbT7M/oZiX2waWLCsJloFuzAQ4RdmXJTDQHueuuxtHBm8puwH8Z59p8MHPRuuC/ fL9og47RUAX4Hswhn8euZeM+FXlNGvMAPxrUWKLVOZOEtYQ9oChVcmG9ls8Bq9Y7Ja8v a7b/9wd6O1/I3ZOkUyjDQ+gjI8Ns57eeACiWK2WVGDAfBeFjCDS8OcxUuk596mQzsTxJ O/MehBgLHVeFZK/F+9/xq3Pwcc66cogtrOEutRD/sC4ujAF0aF2BRY3d8H9YW1rrUoTu K1I1p3trhH8v0lfONctNK3qSDiuSLkHpCWS4ELkLjY9drPUeC9naMX2kRjIigOMdKO0W rnlA== X-Forwarded-Encrypted: i=1; AJvYcCVv7Z7l76CUFwSaq25ob2dzgrTdY95M+6gpc+TnNwv6ygCCK06JmWcPplSr2iq/ixgQA+q4HKG5EPNmp7Qnw1fyeL4= X-Gm-Message-State: AOJu0Yx1erk/9ntEqexTurKMY2uJrbm2dQ+pZXkPZq3tOS/tAqP7reJ2 M/iiBr5lIw3Jx8L0v3CElXR47o+TYTMh93Itjo/P2KLLsn1bc0ES+bHljn1k X-Google-Smtp-Source: AGHT+IEpC7xF+OulmKV7IW5E1NvlnxhXwP0xW/ISQhilw1URgrcXmg/Rh9JSEDABuVWkpbOshGaF9g== X-Received: by 2002:a2e:8817:0:b0:2eb:fdc3:c2ea with SMTP id 38308e7fff4ca-2ec3cecc2a0mr42666931fa.30.1718932295692; Thu, 20 Jun 2024 18:11:35 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57d3042e407sm232254a12.46.2024.06.20.18.11.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jun 2024 18:11:35 -0700 (PDT) Date: Fri, 21 Jun 2024 01:11:34 +0000 From: Wei Yang To: Guenter Roeck Cc: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, Paul Mackerras , Tejun Heo Subject: Re: [Patch v3] mm/memblock: remove empty dummy entry Message-ID: <20240621011134.4vjac3lb3juuocfd@master> Reply-To: Wei Yang References: <20240405015821.13411-1-richard.weiyang@gmail.com> <8d6205d4-18fb-4e98-97e6-db226dcf48f3@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d6205d4-18fb-4e98-97e6-db226dcf48f3@roeck-us.net> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D229BA0008 X-Stat-Signature: uac9bmi4w5tn4gxuu1moogi5ofg37wit X-Rspam-User: X-HE-Tag: 1718932297-777918 X-HE-Meta: U2FsdGVkX1++xO2J5gr0KwvyG94ZW7VyowDO7hvcbX5FJc5VlAwNKKAMMroYkx/B+tpY/fTPp2eH3wYPUeuG4pCq1k9cRp6L/4XViSsNgAu4Ga4SVVJ5Dp005FiFh2i288emeK5hcUi2N0mS4IRXKWLtTmJD5pu1T8U+vHCFAHr6WrY3CpiDjTc3r4WFZwqZZrIxx76lm4H8rqLpE96Lnj2gHIdO5NzZ37RoTc08EBS4mLealdKUcW3NZw33fHgeRqRFvfg+7ybVgznRkPEsqAxhCN7Z80gHF+v7LsB7/q19nUzBn3UdgMz7GYudYaDCRoLWqitGBBDKx6xOjCnaOoQpPCJLu6Ck0j75mP4uaVPIRDh9JAmu8c4LJSdqEa5YXMJggIG6kdD9UYTuWteejVZloU8sB5k2tyoU9g/llEdo2lV/DviZ7E5lqylW8l1rD118bIvM/plfKxtH8R69e6Tiwv6xdETK9x2DtuIHICzx2/UOI2PfFaQ/dFwXSpKO95ANEoCQhgUE8aHIagbqxy4nc5GL2Fg7nyLrV+kJjyGMGJcvmQA5qAJVm270Ox2UJZi4UKShhO2iS5MrbPa6GcRNVkc9aRWY45+Al97oqJBfw9uufGW7W54+S43J4GWgwjpiB34k+YF03MP0AaJgFay1hLA+ys3LUX4VPl5wLhPhQMpGlC/E4YZgryLdQUVcngtn+E2JNusUfO82dsr7JYBYZfcca8SvrkqM9re6xnaUT1YhzUlMSIK1USm1FuBygWoJ0jNd81Ri63g4/sZUVGZSYJV+fWq+Mxt1eDdUc1pTsnetFP8vTFg4FN8INLBP0qtxE6rgrWkjKh9dYnDBaQe5Y9rV1yEwiVkZeeqB8DLTcQtRoJTw49oWnpOnddx/gpyJJFAs3oZ1OL/TL66ZRrktENl38GdVgXC+5HdphYc5qzzgcPG5vzbCVnu2seAzIsu0uydvMfYUv+AjPaM ToAA8GNP tcPXZ7vGH7UVDYKuItTffItOswBjreQqEgxPFRTytFPw5t15mRsxYIvKY2GCypo7M8IhLcbZ7uTbbiJzddKqtWwiW5wMnYt9ovcB2j3mzkzTBIjrRNdklB3dmbq6A6fDKc1CLDhOGaMHdM+B+h0nEKiW+8kCOpOjhWqSk0wVs9w8VFdBYkN0xTGoYG72WjZl0SYIVdXXMNTYL0l9f+bQvItMrGB7Zx5wLO6N+374JjOviuZoI512PmO2zM/PJ9UimggnK5t4wQrt5E49HcZi7aGVX8oJ3rzwfAXJMlg6/f0Mv2kgwN3wyPovpUhxxkhcdHKXQvelq8yOq48+2iW9EB4aIgaGO+a+OteBJgwayN8P0glvqfaarp2WwRO34ffF+c72v/vYN6ES+TcxKu9ch82VL4eUISpy8CwFPzfrEYSxqF9KaoMxMgoMRpFwV3U3lIfGzoi5PnaBbiPmrEu/LtXtSB8ck7XUIjSudXUPQXat+1UR/ryrN3fEa7tcWaVR3cWH3qGRzQLV2kNhFoapXm50Yj6SGQHEIRcAPN8Q5sX8OR3jbtiztvt4cHgj3hzGtJNh47nq2c+hWqUcYfV7ZJXvZaOYYG8qwwjCbv4OGs+fCa8RcE2d9D2uHEL7qYjulWS1n4agv5kpv0Xs4UuFA0QB635+eZIla2Xh8Py2u+3wkx0P+aGRcz/Qo835IvtwE7Eft2ISwJwNQZsXkQZnlnKE2ZugpAD2cdJAxlfZpRSEZj5hPOVVoGBS9NkSUPdsm3V0xF86UR+MsGeuIu1WlL+EMsuw0JxNqq1DoulyfP3DFkrI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 20, 2024 at 02:58:17PM -0700, Guenter Roeck wrote: >Hi, > >On Fri, Apr 05, 2024 at 01:58:21AM +0000, Wei Yang wrote: >> The dummy entry is introduced in the initial implementation of lmb in >> commit 7c8c6b9776fb ("powerpc: Merge lmb.c and make MM initialization >> use it."). >> >> As the comment says the empty dummy entry is to simplify the code. >> >> /* Create a dummy zero size LMB which will get coalesced away later. >> * This simplifies the lmb_add() code below... >> */ >> >> While current code is reimplemented by Tejun in commit 784656f9c680 >> ("memblock: Reimplement memblock_add_region()"). This empty dummy entry >> seems not benefit the code any more. >> >> Let's remove it. >> >> Signed-off-by: Wei Yang >> CC: Paul Mackerras >> CC: Tejun Heo >> CC: Mike Rapoport >> > >With this patch in linux-next, all microblaze qemu images fail to boot. Reverting it >fixes the problem. > >Bisect log is attached for reference. > Also, would you mind add kernel parameter memblock=debug and give me the log? >Guenter > >--- ># bad: [2102cb0d050d34d50b9642a3a50861787527e922] Add linux-next specific files for 20240619 ># good: [6ba59ff4227927d3a8530fc2973b80e94b54d58f] Linux 6.10-rc4 >git bisect start 'HEAD' 'v6.10-rc4' ># good: [a8fa5261ec87d5aafd3211548d93008d5739457d] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git >git bisect good a8fa5261ec87d5aafd3211548d93008d5739457d ># good: [ee551f4db89753511a399b808db75654facec7c8] Merge branch 'for-linux-next' of https://gitlab.freedesktop.org/drm/i915/kernel >git bisect good ee551f4db89753511a399b808db75654facec7c8 ># good: [ec3557f4b791d72d93bfb69702d441d2c9f8cd0d] Merge branch 'next' of git://git.kernel.org/pub/scm/virt/kvm/kvm.git >git bisect good ec3557f4b791d72d93bfb69702d441d2c9f8cd0d ># good: [48d51b3acbb237074014d498d76ea6b6ce5aed69] Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git >git bisect good 48d51b3acbb237074014d498d76ea6b6ce5aed69 ># good: [59972b98583cd97febf9ecc576a706a7c5046278] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git >git bisect good 59972b98583cd97febf9ecc576a706a7c5046278 ># good: [49aa15d761ce8976bb131f06886e89bd10cdb9fd] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching >git bisect good 49aa15d761ce8976bb131f06886e89bd10cdb9fd ># bad: [129b9b07cd69885a804319c3fac82ef79e012e07] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock.git >git bisect bad 129b9b07cd69885a804319c3fac82ef79e012e07 ># good: [344db92cbecc8da1f58d559926c61ceb72e72a03] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/srini/nvmem.git >git bisect good 344db92cbecc8da1f58d559926c61ceb72e72a03 ># bad: [ce8ebb95439459f7e24b02c6943e278f46d2d328] mm/mm_init.c: get the highest zone directly >git bisect bad ce8ebb95439459f7e24b02c6943e278f46d2d328 ># bad: [1a879671bdfd14698a839f30de8e6d76e1e858fd] memblock tests: add memblock_overlaps_region_checks >git bisect bad 1a879671bdfd14698a839f30de8e6d76e1e858fd ># bad: [3d3165193776ddacf59f101f0fa05cfab9f1a9ba] memblock tests: add memblock_reserve_all_locations_check() >git bisect bad 3d3165193776ddacf59f101f0fa05cfab9f1a9ba ># bad: [721f4a6526daafca15634f30c9865e880da3e1d1] mm/memblock: remove empty dummy entry >git bisect bad 721f4a6526daafca15634f30c9865e880da3e1d1 ># first bad commit: [721f4a6526daafca15634f30c9865e880da3e1d1] mm/memblock: remove empty dummy entry -- Wei Yang Help you, Help me