From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E10C2BA18 for ; Fri, 21 Jun 2024 01:07:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC7A58D0108; Thu, 20 Jun 2024 21:07:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D52F98D0111; Thu, 20 Jun 2024 21:07:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA3938D0108; Thu, 20 Jun 2024 21:07:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3E6D96B013E for ; Thu, 20 Jun 2024 21:07:20 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 94541120748 for ; Fri, 21 Jun 2024 01:07:19 +0000 (UTC) X-FDA: 82253107398.11.41F3F04 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf02.hostedemail.com (Postfix) with ESMTP id 97F9B8001A for ; Fri, 21 Jun 2024 01:07:17 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=figcelLw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718932026; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6WcM7JB/4g3tlaedpe628HW65yYWftbwOJ05V79pg8s=; b=Jwhd8m1nqNPXL1uIUdGGCHFcspXzLJ25wasiPkc70OqHmBg64qfZ5z8tj+3DyAZNWF7AGe V0JmaxhXthuFS/ZlLtssWsXgG1SgoqbmO0wVahSCaL91HKCpufzrb0GXEMFj54f6cE57tK 3k2ZLbGlpV9K84KOpiZKAwp56knaEMk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718932026; a=rsa-sha256; cv=none; b=Yr/l8I66PiR7DO6vTI7rehGRjRtGK2UEED+y9ltXXLueGPCy3m5A2wqfpihj53xPcp3dGp FKnQcsnzV5rquJIfspOKGSxBvCRK0c7VDhIwV8VPFzsQyrN/R/zCTGqu+5oocW0NdnTkiB 2tR2HUjh9UDizt/vOBoP2Iix/XC0gx4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=figcelLw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-57d1679ee6eso3185173a12.1 for ; Thu, 20 Jun 2024 18:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718932036; x=1719536836; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6WcM7JB/4g3tlaedpe628HW65yYWftbwOJ05V79pg8s=; b=figcelLwA40ScTrixeaqcS0yoZmAPiP0bsYq/0vBpun5tVvX3zlAW67AAO76ViJzbM MYZ3a/QrlupBHl+2Xu4KDzNdIWC67UEoigKtL4ls6amfMI0s8pcKmpGYRPjx9CW0Nycr yOODvgvbl/B2NVkZ1NtDzR56VxtWyjjkuE6sT6ICp/LfO0z6UKPU3+Lr2fXfjE625unP 5XubAKvURb1e6xwfen6wNit2FmPrgnl0VYkyoJ90MyH66yiljqB4qPlTEFYICztwLN5r n1EUJMpt3ZErgISTmfudQHRxF8kxUjh+z401Bj4tjnZIrkZ+m8cxZcyMK5LS72RElTlC TfZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718932036; x=1719536836; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6WcM7JB/4g3tlaedpe628HW65yYWftbwOJ05V79pg8s=; b=e654uSRTnhcO7N/1vPwwJYZBPV2eLOvZWgQ+e3cKwiJXNziRe+X6eU3U6vr0Xlz2i7 r59zerVIgFchg+xD8OZIwbaN1BVvJJQ01zbXwe3IaSj9CztQJG1XJa0WuhY/QtfNBIuA nMaHTK9+tIpYS+RT3pRWcz+sOEqJyaQ9tCJ2xU6lLCNIAg9WOMmGu2bvhJQwTOnZJCO6 6x6kHZyfb3I+Zr9E+rg/LSu8GoLLo6ktwuRg7cnTSzdEpMbrn9clPeBZyyzaS3AQfX5b byqcEJANBPzpZ21wumMBuWAChjqkFzfh9Cu6NRI86VlUKICOtiZ16g47q9ImCNFlFVRu IhCQ== X-Forwarded-Encrypted: i=1; AJvYcCURFSNkxC+1HtUoUCV6L1pSzhZO2qS7elOX8IUA+zve04tGab5CinRGbHVuD1xy35t9CyjF3XT7eA7nVskQBrn1jek= X-Gm-Message-State: AOJu0Yzj/4vW8kOoFsYjIYXV7OmwzUThKT1fiRAqJBPq2be41MHjUs3e t9JQAohaBrJwcp7FhvWJYoqapn0tQSiGLfum8ayrtQN5H3v6nrpu X-Google-Smtp-Source: AGHT+IHcw6F0J8S9WGILlXdulUbwJSYRaoYQu50ckjVaq0aAKNO95fHZkt00XF7U1Rf9kc7XCsXWXg== X-Received: by 2002:a50:d55b:0:b0:57d:46f:2cb9 with SMTP id 4fb4d7f45d1cf-57d06ab20fdmr4493308a12.13.1718932035665; Thu, 20 Jun 2024 18:07:15 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57d3042b9eesm222070a12.35.2024.06.20.18.07.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jun 2024 18:07:14 -0700 (PDT) Date: Fri, 21 Jun 2024 01:07:13 +0000 From: Wei Yang To: Guenter Roeck Cc: Wei Yang , rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, Paul Mackerras , Tejun Heo Subject: Re: [Patch v3] mm/memblock: remove empty dummy entry Message-ID: <20240621010713.cyai3pkucbp7v7r5@master> Reply-To: Wei Yang References: <20240405015821.13411-1-richard.weiyang@gmail.com> <8d6205d4-18fb-4e98-97e6-db226dcf48f3@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d6205d4-18fb-4e98-97e6-db226dcf48f3@roeck-us.net> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 97F9B8001A X-Stat-Signature: tzok5d84ad5cupn14ecci8zigww6tc8y X-Rspam-User: X-HE-Tag: 1718932037-983890 X-HE-Meta: U2FsdGVkX19jiQJI+Xy/tBg5I3ZQWl/9W00IZn8c5XFbRWaIg4OaubsaaTd8bLpd+M9Cg8Fnv7NbjhhlqIlpDUzTMDRtJ0owJSuAY6hS9PWg0/2o5Yx8pyHIOUzcnBJsxp5BRPeuZVdUyae/djm2P/M89eyoCxgFh260b2lS4ARKkFh/4dJTJyst+edQJPk6HaTdLeovfY1t8tOnMKNC2DWvuoKFIZfD3bqptrztUYXjOOitRVigb4M5B0PLzAM3Ka86jUA14ls9/okp6pCkrIaA1paY/KN2OK5eazqp0ORovjNjC4EIcLLMXFpHtwj0SxoJqM02mMradEGXE17gEGHpdGPdHxzIlmNdq1muWG/I1TAP2InxepfUGT3ffJFStgk0Yiz2J/O5ykUwAMb7SG1rluXseCzqyxjkyUXxUvg9IkgPkUzT/6HnPm9HGQkL6505I76CzCC07wiE2PtOSGbcs/mHmtgwV+eQUCG/7zuS57czcmuDkAjVdA3Pr514NgSJpP1AOUJFcrVQJMP6+1mAJ+nVYUuFibKpW4SlMruEl104eFqr2UVtQKWgtwrMjMPLTo0uzQWT9d0+5FLvE8KL7MmHuzAwttoqROyxriILSpA1nroeh0Nm9BbE1HKiW4iekyWLu92ni7oaqdInFVE0A1EFMjlCAQM8VAJtJgBrzSJJsyCh1mt3FBpweDNDdZQzUW0GL+h6UQbRr6EgScoogRUYl4OMexHSUR3EgTfVwlVczIMUqrdkjwFtcylazBXODrsqLbZG7DiVjTXmgsexvK0fK0XR0ktLu8NmYKoedq+WxCZuaAvXFIStgnWciMOTAyGIV+2+Yd2Gf2I6HbUEBG1bfSQ333MJhIhS3h/AMIvVg7l8mlFnvoj5nRApSIcYyq8y8jfMiiv/B4IZXDNYO4ex1D8qFb4jBS30lfEC164jNZErFIbVDtMbItcatmAG1pMlw5VdlKEn36K XYIjb2yp OA/32fmn1nLIWkzeEZin0utS7FZoM/983gTPGcgbjTF7T+QliRmxZBG76pasZxn3zwdjXx5WnbDhnyu0yeYVuwJV5hh7+TXyMo6iE5xpDOEmuZVA2c/ifbA9QSvIfUttTL6OWaZSikkE01TxlhyNlaEdE6az492Ra9Of+z68dAMm2lf0z71Xnv05KToztjvxydTlExu4l3qciQbD3pni8Y3GIaR+pWshW7c2peyL31Xn1f2Lpe6A2f0+Pwzt3yLWmgMjDNS45nflfL8RUtKArybKU7tSOvt/rXodL6kLIlLNyi6vatzwyGlcFu4nwPg+7gB0RYoNsjIa48sIUMjH8VqTXoWrvdPncEklFAcdoV5RHY9LIopHuKtmnarH0GdcpWFnFaX7jbXe6gdStjjGKzWJrR9yD716GpMK6ouy8U24eFaOliV5iz5SfJ5IdFiBMUVv/wrflPmSP0BYzbJ25vqJcVtlMsrJosFuk23m4hUkqCWyaynzdq4bYqjOmPBeKNId+o7GsRIABFV7GCWXMAjEq6p2nZjJmmy50R9WH8ER3Uj5EbwK/8+ZJb7+gJFvis4dDb+RGTpUUUU7d+upzs1peHCCWkk5c4piOyuLBLuolb3Zga24ERMS0d38rEcjAPVVHK/kRIigqOmflSz6sQEoGQPWdE+wJtgjfI61M4V23swv5uLmcDQUUkvcUOxYl1A0RvPJFs1g8a6RcsOK1SKkXHyeKQk5qE3RMATDuDhTKonOCHeDAEYDzmzdnFl3xdCSApVANQ4g/HKEl/Vq9po8D6C3vAj1Sy0l5wt7UJ/a/KmE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 20, 2024 at 02:58:17PM -0700, Guenter Roeck wrote: >Hi, > >On Fri, Apr 05, 2024 at 01:58:21AM +0000, Wei Yang wrote: >> The dummy entry is introduced in the initial implementation of lmb in >> commit 7c8c6b9776fb ("powerpc: Merge lmb.c and make MM initialization >> use it."). >> >> As the comment says the empty dummy entry is to simplify the code. >> >> /* Create a dummy zero size LMB which will get coalesced away later. >> * This simplifies the lmb_add() code below... >> */ >> >> While current code is reimplemented by Tejun in commit 784656f9c680 >> ("memblock: Reimplement memblock_add_region()"). This empty dummy entry >> seems not benefit the code any more. >> >> Let's remove it. >> >> Signed-off-by: Wei Yang >> CC: Paul Mackerras >> CC: Tejun Heo >> CC: Mike Rapoport >> > >With this patch in linux-next, all microblaze qemu images fail to boot. Reverting it >fixes the problem. > >Bisect log is attached for reference. > Thanks for the reporting. Would you mind running the test to take a look? It is in tools/testing/memblock. Simply make and ./main. >Guenter > >--- ># bad: [2102cb0d050d34d50b9642a3a50861787527e922] Add linux-next specific files for 20240619 ># good: [6ba59ff4227927d3a8530fc2973b80e94b54d58f] Linux 6.10-rc4 >git bisect start 'HEAD' 'v6.10-rc4' ># good: [a8fa5261ec87d5aafd3211548d93008d5739457d] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git >git bisect good a8fa5261ec87d5aafd3211548d93008d5739457d ># good: [ee551f4db89753511a399b808db75654facec7c8] Merge branch 'for-linux-next' of https://gitlab.freedesktop.org/drm/i915/kernel >git bisect good ee551f4db89753511a399b808db75654facec7c8 ># good: [ec3557f4b791d72d93bfb69702d441d2c9f8cd0d] Merge branch 'next' of git://git.kernel.org/pub/scm/virt/kvm/kvm.git >git bisect good ec3557f4b791d72d93bfb69702d441d2c9f8cd0d ># good: [48d51b3acbb237074014d498d76ea6b6ce5aed69] Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git >git bisect good 48d51b3acbb237074014d498d76ea6b6ce5aed69 ># good: [59972b98583cd97febf9ecc576a706a7c5046278] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git >git bisect good 59972b98583cd97febf9ecc576a706a7c5046278 ># good: [49aa15d761ce8976bb131f06886e89bd10cdb9fd] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/livepatching/livepatching >git bisect good 49aa15d761ce8976bb131f06886e89bd10cdb9fd ># bad: [129b9b07cd69885a804319c3fac82ef79e012e07] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/rppt/memblock.git >git bisect bad 129b9b07cd69885a804319c3fac82ef79e012e07 ># good: [344db92cbecc8da1f58d559926c61ceb72e72a03] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/srini/nvmem.git >git bisect good 344db92cbecc8da1f58d559926c61ceb72e72a03 ># bad: [ce8ebb95439459f7e24b02c6943e278f46d2d328] mm/mm_init.c: get the highest zone directly >git bisect bad ce8ebb95439459f7e24b02c6943e278f46d2d328 ># bad: [1a879671bdfd14698a839f30de8e6d76e1e858fd] memblock tests: add memblock_overlaps_region_checks >git bisect bad 1a879671bdfd14698a839f30de8e6d76e1e858fd ># bad: [3d3165193776ddacf59f101f0fa05cfab9f1a9ba] memblock tests: add memblock_reserve_all_locations_check() >git bisect bad 3d3165193776ddacf59f101f0fa05cfab9f1a9ba ># bad: [721f4a6526daafca15634f30c9865e880da3e1d1] mm/memblock: remove empty dummy entry >git bisect bad 721f4a6526daafca15634f30c9865e880da3e1d1 ># first bad commit: [721f4a6526daafca15634f30c9865e880da3e1d1] mm/memblock: remove empty dummy entry -- Wei Yang Help you, Help me