linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
	Alexander Potapenko <glider@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux.com>,
	David Rientjes <rientjes@google.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Marco Elver <elver@google.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Pekka Enberg <penberg@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Vlastimil Babka <vbabka@suse.cz>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, linux-s390@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Sven Schnelle <svens@linux.ibm.com>,
	Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH v6 15/39] kmsan: Do not round up pg_data_t size
Date: Fri, 21 Jun 2024 02:24:49 +0200	[thread overview]
Message-ID: <20240621002616.40684-16-iii@linux.ibm.com> (raw)
In-Reply-To: <20240621002616.40684-1-iii@linux.ibm.com>

x86's alloc_node_data() rounds up node data size to PAGE_SIZE. It's not
explained why it's needed, but it's most likely for performance
reasons, since the padding bytes are not used anywhere. Some other
architectures do it as well, e.g., mips rounds it up to the cache line
size.

kmsan_init_shadow() initializes metadata for each node data and assumes
the x86 rounding, which does not match other architectures. This may
cause the range end to overshoot the end of available memory, in turn
causing virt_to_page_or_null() in kmsan_init_alloc_meta_for_range() to
return NULL, which leads to kernel panic shortly after.

Since the padding bytes are not used, drop the rounding.

Reviewed-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
 mm/kmsan/init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/kmsan/init.c b/mm/kmsan/init.c
index 3ac3b8921d36..9de76ac7062c 100644
--- a/mm/kmsan/init.c
+++ b/mm/kmsan/init.c
@@ -72,7 +72,7 @@ static void __init kmsan_record_future_shadow_range(void *start, void *end)
  */
 void __init kmsan_init_shadow(void)
 {
-	const size_t nd_size = roundup(sizeof(pg_data_t), PAGE_SIZE);
+	const size_t nd_size = sizeof(pg_data_t);
 	phys_addr_t p_start, p_end;
 	u64 loop;
 	int nid;
-- 
2.45.1



  parent reply	other threads:[~2024-06-21  0:27 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  0:24 [PATCH v6 00/39] kmsan: Enable on s390 Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 01/39] ftrace: Unpoison ftrace_regs in ftrace_ops_list_func() Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 02/39] kmsan: Make the tests compatible with kmsan.panic=1 Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 03/39] kmsan: Disable KMSAN when DEFERRED_STRUCT_PAGE_INIT is enabled Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 04/39] kmsan: Increase the maximum store size to 4096 Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 07/39] kmsan: Remove a useless assignment from kmsan_vmap_pages_range_noflush() Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 08/39] kmsan: Remove an x86-specific #include from kmsan.h Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 10/39] kmsan: Export panic_on_kmsan Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 11/39] kmsan: Allow disabling KMSAN checks for the current task Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 12/39] kmsan: Introduce memset_no_sanitize_memory() Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 14/39] kmsan: Use ALIGN_DOWN() in kmsan_get_metadata() Ilya Leoshkevich
2024-06-21  0:24 ` Ilya Leoshkevich [this message]
2024-06-21  0:24 ` [PATCH v6 17/39] mm: slub: Let KMSAN access metadata Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 18/39] mm: slub: Disable KMSAN when checking the padding bytes Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 19/39] mm: kfence: Disable KMSAN when checking the canary Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 20/39] lib/zlib: Unpoison DFLTCC output buffers Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 21/39] kmsan: Accept ranges starting with 0 on s390 Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 22/39] s390/boot: Turn off KMSAN Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 23/39] s390: Use a larger stack for KMSAN Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 24/39] s390/boot: Add the KMSAN runtime stub Ilya Leoshkevich
2024-06-21  0:24 ` [PATCH v6 25/39] s390/checksum: Add a KMSAN check Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 26/39] s390/cpacf: Unpoison the results of cpacf_trng() Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 27/39] s390/cpumf: Unpoison STCCTM output buffer Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 28/39] s390/diag: Unpoison diag224() " Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 29/39] s390/ftrace: Unpoison ftrace_regs in kprobe_ftrace_handler() Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 30/39] s390/irqflags: Do not instrument arch_local_irq_*() with KMSAN Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 31/39] s390/mm: Define KMSAN metadata for vmalloc and modules Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 32/39] s390/ptdump: Add KMSAN page markers Ilya Leoshkevich
2024-06-21  8:20   ` Alexander Potapenko
2024-06-21  8:20   ` Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 33/39] s390/string: Add KMSAN support Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 36/39] s390/uaccess: Add the missing linux/instrumented.h #include Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 37/39] s390/unwind: Disable KMSAN checks Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 38/39] s390/kmsan: Implement the architecture-specific functions Ilya Leoshkevich
2024-06-21  0:25 ` [PATCH v6 39/39] kmsan: Enable on s390 Ilya Leoshkevich
     [not found] ` <20240621002616.40684-17-iii@linux.ibm.com>
2024-06-21  8:21   ` [PATCH v6 16/39] kmsan: Expose KMSAN_WARN_ON() Alexander Potapenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621002616.40684-16-iii@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=42.hyeyoo@gmail.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=borntraeger@linux.ibm.com \
    --cc=cl@linux.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=svens@linux.ibm.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox