linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: kernel test robot <oliver.sang@intel.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>,
	oe-lkp@lists.linux.dev,  lkp@intel.com,
	Linux Memory Management List <linux-mm@kvack.org>,
	 Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [linux-next:master] [vfs]  632586fb1b: WARNING:at_mm/slub.c:#cache_from_obj
Date: Fri, 21 Jun 2024 11:40:28 +0200	[thread overview]
Message-ID: <20240621-stamm-bauabschnitt-692ac8eb7c27@brauner> (raw)
In-Reply-To: <202406211634.7ef4671b-lkp@intel.com>

On Fri, Jun 21, 2024 at 05:24:13PM GMT, kernel test robot wrote:
> 
> 
> Hello,
> 
> kernel test robot noticed "WARNING:at_mm/slub.c:#cache_from_obj" on:
> 
> commit: 632586fb1b5da157f060730549ad45ba9f5e0371 ("vfs: shave a branch in getname_flags")
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master

Thanks for the report. This is an entertaining typo:

diff --git a/fs/namei.c b/fs/namei.c
index 7bb0419a083d..3d3674c21d3c 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -193,7 +193,7 @@ getname_flags(const char __user *filename, int flags)
                }
                /* The empty path is special. */
                if (unlikely(!len) && !(flags & LOOKUP_EMPTY)) {
-                       __putname(result);
+                       __putname(kname);
                        kfree(result);
                        return ERR_PTR(-ENOENT);
                }

Folding this into the patch.


      reply	other threads:[~2024-06-21  9:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  9:24 kernel test robot
2024-06-21  9:40 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621-stamm-bauabschnitt-692ac8eb7c27@brauner \
    --to=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=mjguzik@gmail.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox