From: alexjlzheng@gmail.com
To: akpm@linux-foundation.org, brauner@kernel.org
Cc: axboe@kernel.dk, oleg@redhat.com, tandersen@netflix.com,
willy@infradead.org, mjguzik@gmail.com, alexjlzheng@tencent.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH v2] mm: optimize the redundant loop of mm_update_next_owner()
Date: Thu, 20 Jun 2024 23:27:45 +0800 [thread overview]
Message-ID: <20240620152744.4038983-1-alexjlzheng@tencent.com> (raw)
From: Jinliang Zheng <alexjlzheng@tencent.com>
When mm_update_next_owner() is racing with swapoff (try_to_unuse()) or /proc or
ptrace or page migration (get_task_mm()), it is impossible to find an
appropriate task_struct in the loop whose mm_struct is the same as the target
mm_struct.
If the above race condition is combined with the stress-ng-zombie and
stress-ng-dup tests, such a long loop can easily cause a Hard Lockup in
write_lock_irq() for tasklist_lock.
Recognize this situation in advance and exit early.
Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
---
Changelog:
V2: Fix mm_update_owner_next() to mm_update_next_owner() in comment
---
kernel/exit.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/exit.c b/kernel/exit.c
index f95a2c1338a8..81fcee45d630 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -484,6 +484,8 @@ void mm_update_next_owner(struct mm_struct *mm)
* Search through everything else, we should not get here often.
*/
for_each_process(g) {
+ if (atomic_read(&mm->mm_users) <= 1)
+ break;
if (g->flags & PF_KTHREAD)
continue;
for_each_thread(g, c) {
--
2.39.3
next reply other threads:[~2024-06-20 15:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 15:27 alexjlzheng [this message]
2024-06-20 17:30 ` Oleg Nesterov
2024-06-21 8:50 ` Michal Hocko
2024-06-25 22:21 ` Andrew Morton
2024-06-26 6:43 ` Jinliang Zheng
2024-06-26 15:23 ` Oleg Nesterov
2024-06-27 7:44 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620152744.4038983-1-alexjlzheng@tencent.com \
--to=alexjlzheng@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexjlzheng@tencent.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
--cc=oleg@redhat.com \
--cc=tandersen@netflix.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox