From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5766AC27C79 for ; Thu, 20 Jun 2024 18:46:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B77FD6B02DA; Thu, 20 Jun 2024 14:46:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B00748D00A7; Thu, 20 Jun 2024 14:46:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9535B6B02DF; Thu, 20 Jun 2024 14:46:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 772056B02DA for ; Thu, 20 Jun 2024 14:46:46 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 031C6A04F1 for ; Thu, 20 Jun 2024 18:46:45 +0000 (UTC) X-FDA: 82252148412.30.3C2B0C6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 44D3820011 for ; Thu, 20 Jun 2024 18:46:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uK+JbPGH; spf=pass (imf03.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718909195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SmlXzNpa+9DpmGpkBocCXuwvqiVlFRCTHWCFCmpyNi4=; b=3AX6z6qY278BSR/RpCMP10pXAxpB3RcvOj7ZZM4mszb62gd4zwePdmFn0mzHkVV+vJICjo qz/g1Hpx/bU6etV9UOhxpDDN4DDyeugCBu7ivfSfLJCDM6csyUiYKrM+L1CeSfB6I5PwVd Ip4Nqu3S3QQOn0C4ccjCtB7250eimUw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718909195; a=rsa-sha256; cv=none; b=rS6/ZWNKUGi6DHaraUaDNt5sH5jEn4jkODG5vtEN+k4bJyuixUm1VM/YHT4m8h6XkPexAG lYuVJTfUhpELIuF99h7FFwodugUblMoB8qD05HG+cU7FaV32FLd8eCtBn346YG/fz2jUD/ Z+if1lfpwDL5AlqeQPj2FO4uL9NZLZ0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uK+JbPGH; spf=pass (imf03.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1828262278; Thu, 20 Jun 2024 18:46:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4DA0C2BD10; Thu, 20 Jun 2024 18:46:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718909202; bh=I3joilslbsTLNhXOXgFwVeASkXdC28bcARNwfLKI8vY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uK+JbPGHAN8r05cRgDkZQTsmELs6UZrtg2JBK9smm3uLdlJWaL4l8aS7al4jNu+KH /arX2rg8N8O+LOODJDJpA4nAiXuxMMUW6iA4EVO4/ycET4EkJgK/mk+60vIHHQ5yHS hLptnexYsErWkzpNLBnPe1HzGVCqUa5vrp2wILiLY3mQCVw8e2SV2KAkTvOcr5/OQi ByPyQKnQ/3VCumQRaojNgAwFL9ARtQzSFzh7a4rmVhdqno8D9OHj+R+rxGWkY7zrmT vGOSOUhoQYBJfCnvP65Ry+c2yGG55UMEI3PLXUCSGOu47ziiF1T6VQhMgkVBClpw6W ECXKB8H5QyJqw== Date: Thu, 20 Jun 2024 11:46:42 -0700 From: Kees Cook To: Vlastimil Babka Cc: "GONG, Ruiqi" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , jvoisin , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v5 2/6] mm/slab: Plumb kmem_buckets into __do_kmalloc_node() Message-ID: <202406201144.289A1A14@keescook> References: <20240619192131.do.115-kees@kernel.org> <20240619193357.1333772-2-kees@kernel.org> <7f122473-3d36-401d-8df4-02d981949f00@suse.cz> <88954479-01a3-4bbe-8558-1a71b11503f8@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88954479-01a3-4bbe-8558-1a71b11503f8@suse.cz> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 44D3820011 X-Stat-Signature: 4jy75tcxckom7yc47diqsswrikmdmk3n X-HE-Tag: 1718909204-478768 X-HE-Meta: U2FsdGVkX18WYsvrE/W/p84nBq9ZoiggYcW6lbFcFlU7iHa5ZbjlgVWxAiA0TCJsRoP26FHASSKmhtfAcbLH+LPhmvuiM2yayeNJJlDcH0Rh/puBXGiCt+QiCSJMA2gC9YGGeaEOEdxTVJ9d2hsbWApiVgPNBtOWETB9M5dagd33z3aXnQBBypKyQRoNBAmHBc+8lOprVienHFlyz3UAFNGoH1Ks8YXQ5N7zgeM5F+o61F/TcSVrC3BHtEeOYxUo+3K9QM/q5eIPDtJ8ENvINbtSpW9qX/fotreWOV85Jhn5pjA9kmGtYOJzkHmANvTnxz6NnuswIeyKo8Vz4NG5wJiunLIHuKoJHykWWuaPZA5dREDdC0Al04xFBPcJnwNFuZ50an/AcG/24FoRSiUrzuGDjg5A8qDzDRLF1AXqOJPPMGlARHjJkIRrUlayJ5lJsSZ+Blh5uk7XOx9QHUxycCLzpSw3XnRg8ev/8JzXOfduvQea67gGm8BlVZvkr4KrdaLokl5b4YofwSw963Qq+NoaLThiMa9xOzQWgD/PLBvBF3QcZ9/k5xRnPaCnBqSV6UOzmFFbr27+Ss1aVp8gpyDY3PYAKv2oBAbRBivvg4EowaBmTuUbW38JUQ80tyomRNh70RhvmyjuGLhwKleOR+lQiZTuaKpDDiWGFnqYZ8PtH93K0AfxrJIFzaBj/JhBR84ZQZnj23HcWS3Y/ZOYc5ZobChtFSHZZKMs4naWkulLyaM2fRpS1ZW2MnjSPQ/5omxuy1eVviVPehAaD9JR5KtiVmZW0aO1ogDrsl3tRlJeX/WtkiKA8wTTg7d75m4hbcMIMhoB4/zquMA5ghlXGZGvoAFki5sdmUgXaM+BiwfzK02jihw3LTAc3fwdJbhd5IAvayj80SkUqT6p58Xl02hD/o+xji42H8gBH7bEgRhi3AP45Fk5TqpWYzibDav5IuXOQe9RSaeVO9Qa9WO 0uYTVf24 FcVg/ZwlP6CdlJ07liF41IfJVjOO56iF9O+v6wL6ahEYHjtsWm2BCedNbH8ihhskMiqkwMLUq3B1qYcNGcwB9AnJZFnn9UZUkEmWFp2u3YdByciVUyfUxKjMQZaAKLEdDlH0asDvEvp9qlJklTN9y7kqkbbewP0grLJm4JFW1EpmNDBNNyIUUAnU6Iw1KyX31KKmic8BuluLII6DN4Qn43ELgiErkWxVIkyX5UZQxfR4uS5oEorDU8c12mBMePjzL0zpeNa5oULpYYX+yHufsn01lpjJg0Ml6w235nKe5hBI1IraLL8ljKxUU7H5Rd+82m9OjqO9mOIAkSHPxWCmRiZSpqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 20, 2024 at 03:37:31PM +0200, Vlastimil Babka wrote: > On 6/20/24 3:08 PM, Vlastimil Babka wrote: > > On 6/19/24 9:33 PM, Kees Cook wrote: > > I was wondering why I don't see the buckets in slabinfo and turns out it was > > SLAB_MERGE_DEFAULT. It would probably make sense for SLAB_MERGE_DEFAULT to > > depends on !SLAB_BUCKETS now as the merging defeats the purpose, wdyt? > > Hm I might have been just blind, can see them there now. Anyway it probably > doesn't make much sense to have SLAB_BUCKETS and/or RANDOM_KMALLOC_CACHES > together with SLAB_MERGE_DEFAULT? It's already handled so that the _other_ caches can still be merged if people want it. See new_kmalloc_cache(): #ifdef CONFIG_RANDOM_KMALLOC_CACHES if (type >= KMALLOC_RANDOM_START && type <= KMALLOC_RANDOM_END) flags |= SLAB_NO_MERGE; #endif -- Kees Cook