From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A46C2BBCA for ; Thu, 20 Jun 2024 01:34:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AB3C8D0098; Wed, 19 Jun 2024 21:34:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9591D8D0066; Wed, 19 Jun 2024 21:34:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FACA8D0098; Wed, 19 Jun 2024 21:34:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6200F8D0066 for ; Wed, 19 Jun 2024 21:34:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0FB3280972 for ; Thu, 20 Jun 2024 01:34:02 +0000 (UTC) X-FDA: 82249545924.25.AC8C041 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 4587040016 for ; Thu, 20 Jun 2024 01:34:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="jl/hVcXl"; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718847232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZZav4Oba6qkvidENNDtmqJm6DbNvE7Ei8N/c/SLLLuE=; b=KAq+fRrG0TxH7DQV9+3XYxo6HYfSbx7/XVEzgEhPEzVmylRezoyfvduBqmUvU72uE6fh3h Xu9VPZPGSMC5t4hbyz6Oq3CEIR6uREoLHd8L7FCi/xbSphXUm5fgPe8lmzHLtj+EpqEpF0 Mbu85/gUVl01ZLhVl51zcFP0uyEhiK0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718847232; a=rsa-sha256; cv=none; b=Wu28f9+CdiJVvwzkpjmXBDswFQKQSSZhlnB/+9y1XK5ra9JZYxT6+0QNpu9bDEvh8CTLd1 bfGVI8N2oT0jec55gQ4vl+it9XRPBBnS+hpE0H/zXrklRlx6tyuFkr8S/2mKcYVOpIlEIH 7WCFF9OQSjGDMIvhFnQcG4/ttAxF/Y8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="jl/hVcXl"; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 279C961E9D; Thu, 20 Jun 2024 01:33:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42164C2BBFC; Thu, 20 Jun 2024 01:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718847238; bh=Ehy3lm5mhs1TTZK3YUqvQ9iGlAo7Hoxuggu0HtqdSMs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jl/hVcXl6P595oLGK+xr71dKVq4p0qictftrZaaavAWkjAsh8MjQ17YZI14x/zxXk Mkc0Qck11qXCC2rlaS3g1cYbkVvhkdY0KdjumEJdPx81NtgzWjtomWDym5RK7lkHIO uI18VViBC4owKXW3AXPRstY67KEu6HlemJiwZXtg= Date: Wed, 19 Jun 2024 18:33:57 -0700 From: Andrew Morton To: Hugh Dickins Cc: Baolin Wang , willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, chrisl@kernel.org, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Bresticker Subject: Re: [PATCH v2 0/9] support large folio swap-out and swap-in for shmem Message-Id: <20240619183357.2ee5a818f8de1d4773be2ff6@linux-foundation.org> In-Reply-To: <2683b71d-aebd-5527-348c-18c0e021b653@google.com> References: <20240618130538.ffab3ce1b4e66e3ba095d8cf@linux-foundation.org> <475f0f2c-afc7-4225-809f-93c93f45c830@linux.alibaba.com> <2683b71d-aebd-5527-348c-18c0e021b653@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4587040016 X-Stat-Signature: jei5c4matdot6hju37d6m33uq6ga3jsn X-HE-Tag: 1718847240-565315 X-HE-Meta: U2FsdGVkX19viqR6EI0u4RaYo8VEg8A4lziCWmElT4l7wxovEaAn+KT6RX27CBX9xz4tB4OK1EGQt1k9EI0O1CEbQv4voYTLJjXdWwn8qaVs3VBqVbRnWVP6qmGkpKOtrynUE1Yy+CqdusVO+zxPxvHPI25OYrL2n0GBsctD2bgJr/L0En8AeEAdNM0wxvSBeKZ/mjAdBXDAgVxgHKOlcQ70WhaNjirpWvbRB+2FPXyvPpeKw55TvZqpdS6tSm2sJF08KXwVY6bVFgDkdcJwSvxUs4gaNYPy3WRY12xHK5D6f2e7XEuveejOnBI3rQ/Np/g13ckJhP4kETk0gZQXqu+ME6Gjhj00IgnSFimSakKZiIj6o55hYyn4mfP0B9HsHBi/W0loMK+PmY1gNefYTgJF73U8OAwoF2WfZqgcKUMJ1TrmY4Oqi0jkPdEXGTLo3T+4iN5ObM94yUVlH62v+fofeuzh1H9MPyedMBDoHO0tLRFZXLgmeEC5GyeROsnasC/EbcbpQokLc8T5k+k+xuCCLriRh2ZeyZFqDbSKeELnGn2zQVch+BtEOrTzpw1o/EfQ4D4BkjVZJEy/2EzH/iOooP+VDBHCVSQGHR0sehA4t6Kobl/WKxnlOS2vXHcQI5k66ZJzN6Y3B1+ZoXhfbk96O8MCyl73mOKed6+Y4zCJ/8IVEf5x8Df3lDZXF3z65lYDCo6hFBpPlYCXMNFKXuy8AeZaBelYGNZj/9XIN2W2Tu8BBkGNaiBt4W6ZKB7Mqc3JeBjGRvdM0xQWseLroEzY5cFsswnh3SiBH+wr37326eJYiviLqT4qQXq8XYggRRD2K/p0DfT86P7O2sb2pLCCC8/caQfohcwm8udhMBL4JG01/LfBCoJJxAfWum6lfm5gzbrHyb/gXfdEsntc5YuSqIwFW6ldGfNfyhV9PCKzsiJBuFP5E8yr6hG9aD9IEFUVY9RT8PhGMbge8MN ewQ95Mut +XPm3To9Xc3SS8LDjxoPBuJH4Gjda24NUyenMQS9x37DT/LhvpI1aeSS3NywQUIDDjiSo9Qedp4uitxFxX0bAlZCI7i57bmzMfctcQNvEk6g1wzqlHVkcue34zAboCxtSs3ibMf0j5HgxMzqzGqBMRXYxvDHQTciz+71Gz5b4OzXFWobtIea88ZjGrlIjLOz2SHuQBfLG6XBUvP7IOCn9UAM2XZ/ObQTizNtEkCDTuGZgbg25V+RtdVhfXFCyBM+y3J2+6+3u0oky19Kmo2DpXDGZsQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 19 Jun 2024 01:16:42 -0700 (PDT) Hugh Dickins wrote: > On Wed, 19 Jun 2024, Baolin Wang wrote: > > On 2024/6/19 04:05, Andrew Morton wrote: > > > On Tue, 18 Jun 2024 14:54:12 +0800 Baolin Wang > > > wrote: > > > > > >> Shmem will support large folio allocation [1] [2] to get a better > > >> performance, > > >> however, the memory reclaim still splits the precious large folios when > > >> trying > > >> to swap-out shmem, which may lead to the memory fragmentation issue and can > > >> not > > >> take advantage of the large folio for shmeme. > > >> > > >> Moreover, the swap code already supports for swapping out large folio > > >> without > > >> split, and large folio swap-in[3] series is queued into mm-unstable branch. > > >> Hence this patch set also supports the large folio swap-out and swap-in for > > >> shmem. > > > > > > I'll add this to mm-unstable for some exposure, but I wonder how much > > > testing it will have recieved by the time the next merge window opens? > > > > Thanks Andrew. I am fine with this series going to 6.12 if you are concerned > > about insufficient testing (and let's also wait for Hugh's comments). Since we > > (Daniel and I) have some follow-up patches that will rely on this swap series, > > hope this series can be tested as extensively as possible to ensure its > > stability in the mm branch. > > Thanks for giving it the exposure, Andrew, but please drop it from > mm-unstable until the next cycle. Thanks, dropped. > p.s. I think Andrew Bresticker's do_set_pmd() fix has soaked > long enough, and deserves promotion to hotfix and Linus soon. Oh, OK, done. And it's cc:stable. I didn't get any sens of urgency for this one - what is your thinking here?