From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08DE1C27C53 for ; Thu, 20 Jun 2024 01:20:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C8D86B0449; Wed, 19 Jun 2024 21:20:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 778976B044A; Wed, 19 Jun 2024 21:20:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 640246B044B; Wed, 19 Jun 2024 21:20:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 44D9F6B0449 for ; Wed, 19 Jun 2024 21:20:21 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02075A1618 for ; Thu, 20 Jun 2024 01:20:20 +0000 (UTC) X-FDA: 82249511442.30.49BE199 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 1FA7C2000F for ; Thu, 20 Jun 2024 01:20:18 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lbLv6lOK; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718846414; a=rsa-sha256; cv=none; b=r2BB0czopGPXpICr8Peq/4K5YKXxNfGlf1kZD8dQQ8KcQMFKgPieSw4WHgi1Sfv4ZXTupd 3Sptw0mvHSSO2jFf4FW/CiUpdrGl6q69D/Wvl92zlOUwhwa87ItWpNS4vl51J9bJbxeIb/ uxy13FXELjlQabQlLbQ7c4JRyK2ObGU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lbLv6lOK; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718846414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Plmnx/FXMHQuau9Q+N/dn5mQN+PssnHTkdcI3ZMNsuU=; b=NROBO/KzB8Ki7DkPJzEAztWMC/CVYS7bbW7GvUsR/DGY1Z0mPc7lwX0/+TuvC2QQpV4bib myplempjJM9ya/9xRy/hQwu2DhSC07JNgZroc/TkPnVzqnHw3aippNHy82PMYabSQKqaDD qjLlO5pjUwG4/Nsin3fpeh/Qug4cT0Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CA59262060; Thu, 20 Jun 2024 01:20:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2C62C2BBFC; Thu, 20 Jun 2024 01:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718846417; bh=bJXYMr4QXimk4q4LQjamqjErXLeD3MERsKZSARFMAYM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lbLv6lOK8F/j4jt0rCkWllzrJ0BueRMY3j24nX6IQVNjBb8R0XRXeO+BTJmN9GgzT VxeYYYQRCMKtItVqOPzP6nfKfxE04IqzS5te6nEbbOwM8BygqGiAnL+17AEYACNCf7 Q8GGFtrzO2QQpVjd8iSACuit5Ep6nzUSzNkF6/qQ= Date: Wed, 19 Jun 2024 18:20:16 -0700 From: Andrew Morton To: Barry Song <21cnbao@gmail.com> Cc: Christoph Hellwig , linux-mm@kvack.org, linux-nfs@vger.kernel.org, anna@kernel.org, chrisl@kernel.org, hanchuanhua@oppo.com, jlayton@kernel.org, linux-cifs@vger.kernel.org, neilb@suse.de, ryan.roberts@arm.com, sfrench@samba.org, stable@vger.kernel.org, trondmy@kernel.org, v-songbaohua@oppo.com, ying.huang@intel.com, Matthew Wilcox , Martin Wege Subject: Re: [PATCH v2] nfs: drop the incorrect assertion in nfs_swap_rw() Message-Id: <20240619182016.9e255f676792dde69a995974@linux-foundation.org> In-Reply-To: References: <20240618065647.21791-1-21cnbao@gmail.com> <20240619052740.GA29159@lst.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 7ieo39ppqdmmsqun9itb5xzpkqzz9zig X-Rspamd-Queue-Id: 1FA7C2000F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718846418-204979 X-HE-Meta: U2FsdGVkX1/0HVR6Rox8jKiGDbDTN/yb9pOc+z2+oj5NFP7A5wSgqADcseLiF2L0mwViMotwv4KKmCIRQpzzxMQn0CjXCWuAjpWkiHph9+yeLSIXvxje6s1L+VsA40HsQEL864UcDbRvZZ64h7PoDxlbcET0IsF4hxCEoqDFUKgkT2oI7U3Knn9VKB3u2i/MskPetEFtkehw8GQZmY0dWCNETMZlKIACKCdKnOb3mmUeyEJPvK3N35L3/hFTW5FOuSeDlvoYCJ/AwT5pJz2N0zbYDUy7zjY2abFJvp36u1n0rztg34+Nup3Whx+PgjIW+Yw+pij/32DKZrvQTGwYWmxA7FJ64QwNnBJYLb/WnTMkqAxVAtny/tARrT/TqZbCgo0wFiuu9rbH1aGTjLPJ7OAMFiz9KHLASxlFiunhqGX+14/Lpyfl7CxSmD8gxx1Mfv0iJ5HThnjT3JZCLU4EFb9eknOc3ldi/+nz7uSfbLHuv3r+kTzBCtUntvbxF2anbc5hvSQWLGmtTMTli5pphC8WmMEpcqlyKziHiRl2Z5H7rSzAZ/yYKlwhH8qY+wAne1uyELZ2iBwU+L66RvIElOmkSccb5zyrKt9l/urBVIfCQw2S+CtQxbn8KvbDS+kWhpnfdvf9HXdqOTL0OYeT5y1n3WqXw7azmbYWpzQ5zBllT3YcGGmBD8+hnnQYyNNr/Q76VPGNgHbLzvumsEeDmqA4CutYlPSTs0nQrdEMJv7edMeypG9JvYIZF80aQIL2xwaICsfkEWhzUIlDGf6Nb6i4T++27j00fAY9lA4O31p6dK6clYQefUR5uX54RLriTLl04Yz0533OYguqXtlmRKHbOaXHE5RjPLlWpeu97OgPbEoSB2BhZOvaa7bFZMGAdVnHtsVvxhg7J83Vf4BZWQmU4a2rf9TQB53mS9UsncLLfzLi2DG6uxBTVIKjPItB1H3rHgMhaz1fatDEejJ cXruJLGq DdYV8JxHr19sSxLJiWtrfMtg3uNJ3Fzw9XYWoocGai2aXKTqxUt9mzVxM9/PIcKFe6J7uDzNi0zUYLote+vnCEJZT8z+6Qzqh/iUsfsZ3/QTVFbjodWGqK7MexeT7viTyNJBRTC+nu6moklTQ0hv4DihFwte55voxU2X251sCbBwsoDhmNap9Ak4OJ65S8khAmRYCEXJM49B6HtDKaalME2MQxDk9/C/az6kDXwsrh+82oWHPfJM1fmw1+EK/2OBEa2rDmrN3eBjFP5gf5DRSxUm5NDM3ONUnT7RCFxG4JYn+LloQDzsRl3j1GwIqfvC9Zp8Yll0x1m805OYBPxg6iBSVemKlFItBN0flqAa+smqaHSOgzk1n6ityBSeS15uZoCrRX4NSe8HUPwY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 19 Jun 2024 17:34:27 +1200 Barry Song <21cnbao@gmail.com> wrote: > On Wed, Jun 19, 2024 at 5:27 PM Christoph Hellwig wrote: > > > > On Tue, Jun 18, 2024 at 06:56:47PM +1200, Barry Song wrote: > > > Fixes: 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS swap-space") > > > Reported-by: Christoph Hellwig > > > > > Signed-off-by: Christoph Hellwig > > > > A reported-by for the credited patch author doesn't make sense. > > Andrew, could you help remove the "reported-by" in the commit log? > Alternatively, would you prefer that I send a v3 to drop the "reported-by"? I made that edit.