From: Wei Yang <richard.weiyang@gmail.com>
To: rppt@kernel.org, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH 4/4] mm/page_alloc: reword the comment of buddy_merge_likely()
Date: Wed, 19 Jun 2024 01:06:12 +0000 [thread overview]
Message-ID: <20240619010612.20740-4-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20240619010612.20740-1-richard.weiyang@gmail.com>
For page with order O, we are checking its order (O + 1)'s buddy. If it
is free, we would like to put it to the tail and expect it would be
merged to a page with order (O + 2).
Reword the comment to reflect it.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
mm/page_alloc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 594176449890..d1df7929f003 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -706,12 +706,12 @@ static inline struct page *get_page_from_free_area(struct free_area *area,
}
/*
- * If this is not the largest possible page, check if the buddy
- * of the next-highest order is free. If it is, it's possible
+ * If this is less than the 2nd largest possible page, check if the buddy
+ * of the next-higher order is free. If it is, it's possible
* that pages are being freed that will coalesce soon. In case,
* that is happening, add the free page to the tail of the list
* so it's less likely to be used soon and more likely to be merged
- * as a higher order page
+ * as a 2-level higher order page
*/
static inline bool
buddy_merge_likely(unsigned long pfn, unsigned long buddy_pfn,
--
2.34.1
prev parent reply other threads:[~2024-06-19 1:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 1:06 [PATCH 1/4] mm/sparse: nr_pages won't be 0 Wei Yang
2024-06-19 1:06 ` [PATCH 2/4] mm/mm_init.c: move build check on MAX_ZONELISTS out of ifdef Wei Yang
2024-06-23 7:48 ` Mike Rapoport
2024-06-19 1:06 ` [PATCH 3/4] mm/page_alloc: fix a typo in comment about GFP flag Wei Yang
2024-06-23 7:50 ` Mike Rapoport
2024-06-19 1:06 ` Wei Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619010612.20740-4-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox