From: Chris Li <chrisl@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kairui Song <kasong@tencent.com>,
Ryan Roberts <ryan.roberts@arm.com>,
"Huang, Ying" <ying.huang@intel.com>,
Kairui Song <kasong@tencent.com>,
Kalesh Singh <kaleshsingh@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Chris Li <chrisl@kernel.org>, Barry Song <baohua@kernel.org>
Subject: [PATCH v3 0/2] mm: swap: mTHP swap allocator base on swap cluster order
Date: Wed, 19 Jun 2024 02:20:28 -0700 [thread overview]
Message-ID: <20240619-swap-allocator-v3-0-e973a3102444@kernel.org> (raw)
This is the short term solutiolns "swap cluster order" listed
in my "Swap Abstraction" discussion slice 8 in the recent
LSF/MM conference.
When commit 845982eb264bc "mm: swap: allow storage of all mTHP
orders" is introduced, it only allocates the mTHP swap entries
from new empty cluster list. It has a fragmentation issue
reported by Barry.
https://lore.kernel.org/all/CAGsJ_4zAcJkuW016Cfi6wicRr8N9X+GJJhgMQdSMp+Ah+NSgNQ@mail.gmail.com/
The reason is that all the empty cluster has been exhausted while
there are planty of free swap entries to in the cluster that is
not 100% free.
Remember the swap allocation order in the cluster.
Keep track of the per order non full cluster list for later allocation.
User impact: For users that allocate and free mix order mTHP swapping,
It greatly improves the success rate of the mTHP swap allocation after the
initial phase.
Barry provides a test program to show the effect:
https://lore.kernel.org/linux-mm/20240615084714.37499-1-21cnbao@gmail.com/
Without:
$ mthp-swapout
Iteration 1: swpout inc: 222, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 2: swpout inc: 219, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 3: swpout inc: 222, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 4: swpout inc: 219, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 5: swpout inc: 110, swpout fallback inc: 117, Fallback percentage: 51.54%
Iteration 6: swpout inc: 0, swpout fallback inc: 230, Fallback percentage: 100.00%
Iteration 7: swpout inc: 0, swpout fallback inc: 229, Fallback percentage: 100.00%
Iteration 8: swpout inc: 0, swpout fallback inc: 223, Fallback percentage: 100.00%
Iteration 9: swpout inc: 0, swpout fallback inc: 224, Fallback percentage: 100.00%
Iteration 10: swpout inc: 0, swpout fallback inc: 216, Fallback percentage: 100.00%
Iteration 11: swpout inc: 0, swpout fallback inc: 212, Fallback percentage: 100.00%
Iteration 12: swpout inc: 0, swpout fallback inc: 224, Fallback percentage: 100.00%
Iteration 13: swpout inc: 0, swpout fallback inc: 214, Fallback percentage: 100.00%
$ mthp-swapout -s
Iteration 1: swpout inc: 222, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 2: swpout inc: 227, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 3: swpout inc: 222, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 4: swpout inc: 224, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 5: swpout inc: 33, swpout fallback inc: 197, Fallback percentage: 85.65%
Iteration 6: swpout inc: 0, swpout fallback inc: 229, Fallback percentage: 100.00%
Iteration 7: swpout inc: 0, swpout fallback inc: 223, Fallback percentage: 100.00%
Iteration 8: swpout inc: 0, swpout fallback inc: 219, Fallback percentage: 100.00%
Iteration 9: swpout inc: 0, swpout fallback inc: 212, Fallback percentage: 100.00%
With:
$ mthp-swapout
Iteration 1: swpout inc: 222, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 2: swpout inc: 219, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 3: swpout inc: 222, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 4: swpout inc: 219, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 5: swpout inc: 227, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 6: swpout inc: 230, swpout fallback inc: 0, Fallback percentage: 0.00%
...
Iteration 94: swpout inc: 224, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 95: swpout inc: 221, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 96: swpout inc: 229, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 97: swpout inc: 219, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 98: swpout inc: 222, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 99: swpout inc: 223, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 100: swpout inc: 224, swpout fallback inc: 0, Fallback percentage: 0.00%
$ mthp-swapout -s
Iteration 1: swpout inc: 222, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 2: swpout inc: 227, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 3: swpout inc: 222, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 4: swpout inc: 224, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 5: swpout inc: 230, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 6: swpout inc: 229, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 7: swpout inc: 223, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 8: swpout inc: 219, swpout fallback inc: 0, Fallback percentage: 0.00%
...
Iteration 94: swpout inc: 223, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 95: swpout inc: 212, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 96: swpout inc: 220, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 97: swpout inc: 220, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 98: swpout inc: 216, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 99: swpout inc: 223, swpout fallback inc: 0, Fallback percentage: 0.00%
Iteration 100: swpout inc: 225, swpout fallback inc: 0, Fallback percentage: 0.00%
Reported-by: Barry Song <21cnbao@gmail.com>
Signed-off-by: Chris Li <chrisl@kernel.org>
---
Changes in v3:
- Using V1 as base.
- Rename "next" to "list" for the list field, suggested by Ying.
- Update comment for the locking rules for cluster fields and list,
suggested by Ying.
- Allocate from the nonfull list before attempting free list, suggested
by Kairui.
- Link to v2: https://lore.kernel.org/r/20240614-swap-allocator-v2-0-2a513b4a7f2f@kernel.org
Changes in v2:
- Abandoned.
- Link to v1: https://lore.kernel.org/r/20240524-swap-allocator-v1-0-47861b423b26@kernel.org
---
Chris Li (2):
mm: swap: swap cluster switch to double link list
mm: swap: mTHP allocate swap entries from nonfull list
include/linux/swap.h | 30 +++----
mm/swapfile.c | 248 +++++++++++++++++----------------------------------
2 files changed, 95 insertions(+), 183 deletions(-)
---
base-commit: 19b8422c5bd56fb5e7085995801c6543a98bda1f
change-id: 20240523-swap-allocator-1534c480ece4
Best regards,
--
Chris Li <chrisl@kernel.org>
next reply other threads:[~2024-06-19 9:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 9:20 Chris Li [this message]
2024-06-19 9:20 ` [PATCH v3 1/2] mm: swap: swap cluster switch to double link list Chris Li
2024-06-21 2:59 ` Huang, Ying
2024-06-21 18:55 ` Chris Li
2024-06-24 10:16 ` Huang, Ying
2024-06-24 15:52 ` Chris Li
2024-06-19 9:20 ` [PATCH v3 2/2] mm: swap: mTHP allocate swap entries from nonfull list Chris Li
2024-06-19 9:31 ` [PATCH v3 0/2] mm: swap: mTHP swap allocator base on swap cluster order Ryan Roberts
2024-06-20 2:30 ` Huang, Ying
2024-06-21 8:43 ` Chris Li
2024-06-25 2:34 ` Huang, Ying
2024-07-26 6:46 ` Chris Li
2024-07-26 6:57 ` Huang, Ying
2024-07-26 7:22 ` Chris Li
2024-07-26 7:29 ` Huang, Ying
2024-06-25 2:43 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619-swap-allocator-v3-0-e973a3102444@kernel.org \
--to=chrisl@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=kaleshsingh@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox