From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F27E3C27C4F for ; Tue, 18 Jun 2024 23:36:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 560CB6B03DF; Tue, 18 Jun 2024 19:36:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EA126B03E0; Tue, 18 Jun 2024 19:36:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B0E36B03E1; Tue, 18 Jun 2024 19:36:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E04B6B03DF for ; Tue, 18 Jun 2024 19:36:16 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B86B9A2EE2 for ; Tue, 18 Jun 2024 23:36:15 +0000 (UTC) X-FDA: 82245620310.01.7250782 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 16E77100005 for ; Tue, 18 Jun 2024 23:36:13 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dQH4RDlP; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718753770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eiXEoTOpk/YFrCWp+Ae/GsQeZDqQ3ycJ3duPscrt8zQ=; b=SEYOeveYDmIkfu3N4MDPeVgX0E+pGCpy0UVi4tnTHVHEKaDhVYhKfIgdp/QWJC7tusBcdk 5qlX7xjip725MPyepIQMkWEkTdWUMEdNA87UMBiI2+0DDndJOeiLUuI6Jng9YWw8B4NwDl HxbN5Kx7pnYCysCBJ4j126EbE/GdTyI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dQH4RDlP; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718753770; a=rsa-sha256; cv=none; b=pWnUYuyYj87emGXjBcY8cJtThk6ynLipZSjxv+sc9vmlzMzUyU/yK7KkF+HgmWDMK516XF fRk3ex1KVNkmpKOE3FwB7x+sVtyqz2ri5Xw/eKMmzkbLVICP1GrhLaXVhKpH2weT2ps94A dtjxHPTWxjkQyoRgB3+X+6kp6qT7ZQ4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 34C1A60EE1; Tue, 18 Jun 2024 23:36:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72D19C3277B; Tue, 18 Jun 2024 23:36:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718753772; bh=Ntqy76VFybkGcS9dAO++B//yYbRA0qUGQrrC/6+6gXU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dQH4RDlPa1PpVeiadkbxPDo+1Z8m5w5DDmDB254oqKyMk0Z+JCzcQKTn7elqcm7A2 n0I3xmucAWfB/zZL9EXz2GNDqW6p8rrH8ubnNJiqlWklcsUi17W2iJStzcdt7TV3qQ DEQTTsDjT/wvW806+UhvV+PG3oG5/42nZ5hzecxa1sbWPq2YXeygqBrxM9+4fVWSjT EgJworij9+ebI/JFcHtjQBmKA4I7EB1txR2MFfYiYGGjKuTrAkJ5k6NuLjeRRS7dTo G0lLgaMN3vr5eiXmiLhKAX6vuVj5xrqsGOHILQbpIdQgDrFpzMHD0fFamsIIzwrcXX ag8lTBLz+o2nQ== From: SeongJae Park To: Xiu Jianfeng Cc: SeongJae Park , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 -next] mm/hugetlb_cgroup: register lockdep key for cftype Date: Tue, 18 Jun 2024 16:36:08 -0700 Message-Id: <20240618233608.400367-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240618071922.2127289-1-xiujianfeng@huawei.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 16E77100005 X-Stat-Signature: ewpifht8iyys7cw89rcqjpub8cdwdjjd X-HE-Tag: 1718753773-520875 X-HE-Meta: U2FsdGVkX185aNnpdM7ylRGr5B747Kde+Y2+ukhkKbqEqmxIVuIdikQI56ngXX7Ovw8DLus4qZK45vdd61g8/8izkx2W0WG48Em5Ns1KZRIGBK+ZG4nWGJUhLoCHPQbz3Qg0GIlGZnHq2HMp4kKeG+uv7PJ3JMDdGKE6Nmcb+j0ulb61EyAgG5FqCDp49uzErroFEGQf0C1gqoKWfc8USgDDNUpFG7SZ7gOxzIrNvDsWNnnmLpMtDvLOVwc7rumOMM7NMv7I4sEh+r7snox18jENOr+e/keCReW1cz8+3OzglSq0uiPQrIGTt7ck124lpo738Q3Qjtjda8S0XNvvMPWoCqe0H2La2oU4JZ1+MMq7ahmR0v6diYnbmUZdIjYqKUN6wFacOF5RalQUw5OQZAMusvHWUoVKnqfDExTSAGOWhhonWePq/sO7/y5g48O1w+dIrbInqd/h6WK76sR5OPAm83pOYhgswignoqmOJ/DbOi+26qhdf4YqTqYELEroU+6TkVxXiZFap+q/6H0/nAkcR/sG/GhmGQUKST8M9zt/WsWM91/R89XRB2nYXO1Ke/oJJ4Ci/t7IAMjKgFlKrnkTkIFAwAfzVQGSNJ2E1LBIKuJp+uklnIkNnoTXNWj3KxFZmr/He6MKQeym36RsMyMEhhwf/O2fXQTk/17ZOPsFOTKlp2HPmZ/xM4Wi4iE86n5kRrfQjlzllThodOOAQG6PqYA48SuU3N+3LX/4yw1o3dZPMab1XIdyLwkxUG2ow4bjyc2su/RqwSzEf39pqY6juMlOXv/bembVi0HwMl7wxV5Vo3rS/GLClgnHen3HmKwRM+8CmDReyqVLt8W2vUNrbUQ1kolJmZeZfbo6vHVoV/TqJ35MZQHStik+W1eTYVLJMXbiP7umQONWQHk6pvzjiUA7d28wAaFuI5q7z9M7kRRUVpAgbKiiLfrzxSrqruNGqyklinzUTGrc2aC 2yIxWXNi pLvu73jkOFwanzPk/1EFIIpj1kdfDMUUjynSB7+tL5uEDTJB6xu4SQdALqSrQw7xIP/AVyE8JkLPv1Wv2D9ZAwS9IW1eYrvJIVuUAt6jKoKhpHHIQp7RUMbQ+nUzb7Xn/AHTCUTRiHXwpNwtoiEILRFJoxoIQY5Vuxa+LfvVykykubsIdE0iwgtdo2SL0dZtbGlZ5kb5VUwBcffiWjVHpCJWkPA0W1yzonBlPcsw0ccph4PH2C3ugnRaR5x1eqrEMiSi61s9eDHSb+o8ZiAIFZ8zagQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Xiu, On Tue, 18 Jun 2024 07:19:22 +0000 Xiu Jianfeng wrote: > When CONFIG_DEBUG_LOCK_ALLOC is enabled, the following commands can > trigger a bug, > > mount -t cgroup2 none /sys/fs/cgroup > cd /sys/fs/cgroup > echo "+hugetlb" > cgroup.subtree_control [...] > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c > index 2b899c4ae968..4ff238ba1250 100644 > --- a/mm/hugetlb_cgroup.c > +++ b/mm/hugetlb_cgroup.c > @@ -836,6 +836,8 @@ hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft, > cft->file_offset = MEMFILE_OFFSET0(offset) + > MEMFILE_FIELD_SIZE(offset) * idx; > } > + > + lockdep_register_key(&cft->lockdep_key); > } > } I found the latest mm-unstable tree fails build as below, and 'git bisect' points this patch. linux/mm/hugetlb_cgroup.c: In function ‘hugetlb_cgroup_cfttypes_init’: linux/mm/hugetlb_cgroup.c:840:42: error: ‘struct cftype’ has no member named ‘lockdep_key’ 840 | lockdep_register_key(&cft->lockdep_key); | ^~ Maybe we should take care of CONFIG_DEBUG_LOCK_ALLOC undefined case, like below? diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c index a45065698419..9747c2e64e95 100644 --- a/mm/hugetlb_cgroup.c +++ b/mm/hugetlb_cgroup.c @@ -837,7 +837,9 @@ hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft, MEMFILE_FIELD_SIZE(offset) * idx; } +#ifdef CONFIG_DEBUG_LOCK_ALLOC lockdep_register_key(&cft->lockdep_key); +#endif } } [...] Thanks, SJ