linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
	liam.howlett@oracle.com, willy@infradead.org,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: [PATCH v3 12/16] maple_tree: remove mas_wr_modify()
Date: Tue, 18 Jun 2024 13:47:46 -0700	[thread overview]
Message-ID: <20240618204750.79512-13-sidhartha.kumar@oracle.com> (raw)
In-Reply-To: <20240618204750.79512-1-sidhartha.kumar@oracle.com>

There are no more users of the function, safely remove it.

Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
---
 lib/maple_tree.c | 38 --------------------------------------
 1 file changed, 38 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index b2062e034f89..98c64aaedb55 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -4155,44 +4155,6 @@ static void mas_wr_bnode(struct ma_wr_state *wr_mas)
 	mas_commit_b_node(wr_mas, &b_node, wr_mas->mas->end);
 }
 
-static inline void mas_wr_modify(struct ma_wr_state *wr_mas)
-{
-	struct ma_state *mas = wr_mas->mas;
-	unsigned char new_end;
-
-	/* Direct replacement */
-	if (wr_mas->r_min == mas->index && wr_mas->r_max == mas->last) {
-		rcu_assign_pointer(wr_mas->slots[mas->offset], wr_mas->entry);
-		if (!!wr_mas->entry ^ !!wr_mas->content)
-			mas_update_gap(mas);
-		return;
-	}
-
-	/*
-	 * new_end exceeds the size of the maple node and cannot enter the fast
-	 * path.
-	 */
-	new_end = mas_wr_new_end(wr_mas);
-	if (new_end >= mt_slots[wr_mas->type])
-		goto slow_path;
-
-	/* Attempt to append */
-	if (mas_wr_append(wr_mas, new_end))
-		return;
-
-	if (new_end == mas->end && mas_wr_slot_store(wr_mas))
-		return;
-
-	if (mas_wr_node_store(wr_mas, new_end))
-		return;
-
-	if (mas_is_err(mas))
-		return;
-
-slow_path:
-	mas_wr_bnode(wr_mas);
-}
-
 /*
  * mas_wr_store_entry() - Internal call to store a value
  * @mas: The maple state
-- 
2.45.2



  parent reply	other threads:[~2024-06-18 20:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 20:47 [PATCH v3 00/16] Introduce a store type enum for the Maple tree Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 01/16] maple_tree: introduce store_type enum Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 02/16] maple_tree: introduce mas_wr_prealloc_setup() Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 03/16] maple_tree: move up mas_wr_store_setup() and mas_wr_prealloc_setup() Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 04/16] maple_tree: introduce mas_wr_store_type() Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 05/16] maple_tree: remove mas_destroy() from mas_nomem() Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 06/16] maple_tree: use mas_store_gfp() in mas_erase() Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 07/16] maple_tree: use mas_store_gfp() in mtree_store_range() Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 08/16] maple_tree: print store type in mas_dump() Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 09/16] maple_tree: use store type in mas_wr_store_entry() Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 10/16] maple_tree: convert mas_insert() to preallocate nodes Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 11/16] maple_tree: simplify mas_commit_b_node() Sidhartha Kumar
2024-06-18 20:47 ` Sidhartha Kumar [this message]
2024-06-18 20:47 ` [PATCH v3 13/16] maple_tree: have mas_store() allocate nodes if needed Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 14/16] maple_tree: remove node allocations from various write helper functions Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 15/16] maple_tree: remove repeated sanity checks from mas_wr_append() Sidhartha Kumar
2024-06-18 20:47 ` [PATCH v3 16/16] maple_tree: remove unneeded mas_wr_walk() in mas_store_prealloc() Sidhartha Kumar
2024-06-24 15:43 ` [PATCH v3 00/16] Introduce a store type enum for the Maple tree Liam R. Howlett
2024-06-26  5:37 ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240618204750.79512-13-sidhartha.kumar@oracle.com \
    --to=sidhartha.kumar@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=liam.howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox