From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 12/12] mm/damon/lru_sort: remove unnecessary online tuning handling code
Date: Tue, 18 Jun 2024 11:18:09 -0700 [thread overview]
Message-ID: <20240618181809.82078-13-sj@kernel.org> (raw)
In-Reply-To: <20240618181809.82078-1-sj@kernel.org>
DAMON_LRU_SORT contains code for handling of online DAMON parameters
update edge cases. It is no more necessary since damon_commit_ctx()
takes care of the cases. Remove the unnecessary code.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/lru_sort.c | 28 +---------------------------
1 file changed, 1 insertion(+), 27 deletions(-)
diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c
index f83542973946..4af8fd4a390b 100644
--- a/mm/damon/lru_sort.c
+++ b/mm/damon/lru_sort.c
@@ -186,23 +186,11 @@ static struct damos *damon_lru_sort_new_cold_scheme(unsigned int cold_thres)
return damon_lru_sort_new_scheme(&pattern, DAMOS_LRU_DEPRIO);
}
-static void damon_lru_sort_copy_quota_status(struct damos_quota *dst,
- struct damos_quota *src)
-{
- dst->total_charged_sz = src->total_charged_sz;
- dst->total_charged_ns = src->total_charged_ns;
- dst->charged_sz = src->charged_sz;
- dst->charged_from = src->charged_from;
- dst->charge_target_from = src->charge_target_from;
- dst->charge_addr_from = src->charge_addr_from;
-}
-
static int damon_lru_sort_apply_parameters(void)
{
struct damon_ctx *param_ctx;
struct damon_target *param_target;
- struct damos *scheme, *hot_scheme, *cold_scheme;
- struct damos *old_hot_scheme = NULL, *old_cold_scheme = NULL;
+ struct damos *hot_scheme, *cold_scheme;
unsigned int hot_thres, cold_thres;
int err;
@@ -215,22 +203,11 @@ static int damon_lru_sort_apply_parameters(void)
goto out;
err = -ENOMEM;
- damon_for_each_scheme(scheme, ctx) {
- if (!old_hot_scheme) {
- old_hot_scheme = scheme;
- continue;
- }
- old_cold_scheme = scheme;
- }
-
hot_thres = damon_max_nr_accesses(&damon_lru_sort_mon_attrs) *
hot_thres_access_freq / 1000;
hot_scheme = damon_lru_sort_new_hot_scheme(hot_thres);
if (!hot_scheme)
goto out;
- if (old_hot_scheme)
- damon_lru_sort_copy_quota_status(&hot_scheme->quota,
- &old_hot_scheme->quota);
cold_thres = cold_min_age / damon_lru_sort_mon_attrs.aggr_interval;
cold_scheme = damon_lru_sort_new_cold_scheme(cold_thres);
@@ -238,9 +215,6 @@ static int damon_lru_sort_apply_parameters(void)
damon_destroy_scheme(hot_scheme);
goto out;
}
- if (old_cold_scheme)
- damon_lru_sort_copy_quota_status(&cold_scheme->quota,
- &old_cold_scheme->quota);
damon_set_schemes(param_ctx, &hot_scheme, 1);
damon_add_scheme(param_ctx, cold_scheme);
--
2.39.2
prev parent reply other threads:[~2024-06-18 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 18:17 [PATCH 00/12] mm/damon: introduce DAMON parameters online commit function SeongJae Park
2024-06-18 18:17 ` [PATCH 01/12] mm/damon/core: implement DAMOS quota goals " SeongJae Park
2024-06-18 18:17 ` [PATCH 02/12] mm/damon/core: implement DAMON context " SeongJae Park
2024-06-18 18:18 ` [PATCH 03/12] mm/damon/sysfs: use damon_commit_ctx() SeongJae Park
2024-06-18 18:18 ` [PATCH 04/12] mm/damon/sysfs-schemes: use damos_commit_quota_goals() SeongJae Park
2024-06-18 18:18 ` [PATCH 05/12] mm/damon/sysfs: remove unnecessary online tuning handling code SeongJae Park
2024-06-18 18:18 ` [PATCH 06/12] mm/damon/sysfs: rename damon_sysfs_set_targets() to ...add_targets() SeongJae Park
2024-06-18 18:18 ` [PATCH 07/12] mm/damon/sysfs-schemes: remove unnecessary online tuning handling code SeongJae Park
2024-06-18 18:18 ` [PATCH 08/12] mm/damon/sysfs-schemes: rename *_set_{schemes,scheme_filters,quota_score,schemes}() SeongJae Park
2024-06-18 18:18 ` [PATCH 09/12] mm/damon/reclaim: use damon_commit_ctx() SeongJae Park
2024-06-18 18:18 ` [PATCH 10/12] mm/damon/reclaim: remove unnecessary code for online tuning SeongJae Park
2024-06-18 18:18 ` [PATCH 11/12] mm/damon/lru_sort: use damon_commit_ctx() SeongJae Park
2024-06-18 18:18 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618181809.82078-13-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox