From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 00/12] mm/damon: introduce DAMON parameters online commit function
Date: Tue, 18 Jun 2024 11:17:57 -0700 [thread overview]
Message-ID: <20240618181809.82078-1-sj@kernel.org> (raw)
DAMON context struct (damon_ctx) contains user requests (parameters),
internal status, and operation results. For flexible usages, DAMON API
users are encouraged to manually manipulate the struct. That works well
for simple use cases. However, it has turned out that it is not that
simple at least for online parameters udpate. It is easy to forget
properly maintaining internal status and operation results. Also, such
manual manipulation for online tuning is implemented multiple times on
DAMON API users including DAMON sysfs interface, DAMON_RECLAIM and
DAMON_LRU_SORT. As a result, we have multiple sources of bugs for same
problem. Actually we found and fixed a few bugs from online parameter
updating of DAMON API users.
Implement a function for online DAMON parameters update in core layer,
and replace DAMON API users' manual manipulation code for the use case.
The core layer function could still have bugs, but this change reduces
the source of bugs for the problem to one place.
SeongJae Park (12):
mm/damon/core: implement DAMOS quota goals online commit function
mm/damon/core: implement DAMON context commit function
mm/damon/sysfs: use damon_commit_ctx()
mm/damon/sysfs-schemes: use damos_commit_quota_goals()
mm/damon/sysfs: remove unnecessary online tuning handling code
mm/damon/sysfs: rename damon_sysfs_set_targets() to ...add_targets()
mm/damon/sysfs-schemes: remove unnecessary online tuning handling code
mm/damon/sysfs-schemes: rename
*_set_{schemes,scheme_filters,quota_score,schemes}()
mm/damon/reclaim: use damon_commit_ctx()
mm/damon/reclaim: remove unnecessary code for online tuning
mm/damon/lru_sort: use damon_commit_ctx()
mm/damon/lru_sort: remove unnecessary online tuning handling code
include/linux/damon.h | 2 +
mm/damon/core.c | 333 +++++++++++++++++++++++++++++++++++++++
mm/damon/lru_sort.c | 53 +++----
mm/damon/reclaim.c | 62 +++-----
mm/damon/sysfs-common.h | 2 +-
mm/damon/sysfs-schemes.c | 94 +++--------
mm/damon/sysfs-test.h | 10 +-
mm/damon/sysfs.c | 81 +++-------
8 files changed, 425 insertions(+), 212 deletions(-)
base-commit: a7b6f23b7fa3f5d1f3ae64034a4aff12fb8c1df0
--
2.39.2
next reply other threads:[~2024-06-18 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 18:17 SeongJae Park [this message]
2024-06-18 18:17 ` [PATCH 01/12] mm/damon/core: implement DAMOS quota goals " SeongJae Park
2024-06-18 18:17 ` [PATCH 02/12] mm/damon/core: implement DAMON context " SeongJae Park
2024-06-18 18:18 ` [PATCH 03/12] mm/damon/sysfs: use damon_commit_ctx() SeongJae Park
2024-06-18 18:18 ` [PATCH 04/12] mm/damon/sysfs-schemes: use damos_commit_quota_goals() SeongJae Park
2024-06-18 18:18 ` [PATCH 05/12] mm/damon/sysfs: remove unnecessary online tuning handling code SeongJae Park
2024-06-18 18:18 ` [PATCH 06/12] mm/damon/sysfs: rename damon_sysfs_set_targets() to ...add_targets() SeongJae Park
2024-06-18 18:18 ` [PATCH 07/12] mm/damon/sysfs-schemes: remove unnecessary online tuning handling code SeongJae Park
2024-06-18 18:18 ` [PATCH 08/12] mm/damon/sysfs-schemes: rename *_set_{schemes,scheme_filters,quota_score,schemes}() SeongJae Park
2024-06-18 18:18 ` [PATCH 09/12] mm/damon/reclaim: use damon_commit_ctx() SeongJae Park
2024-06-18 18:18 ` [PATCH 10/12] mm/damon/reclaim: remove unnecessary code for online tuning SeongJae Park
2024-06-18 18:18 ` [PATCH 11/12] mm/damon/lru_sort: use damon_commit_ctx() SeongJae Park
2024-06-18 18:18 ` [PATCH 12/12] mm/damon/lru_sort: remove unnecessary online tuning handling code SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618181809.82078-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox