From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81BD7C27C4F for ; Tue, 18 Jun 2024 06:13:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E50DC6B02C2; Tue, 18 Jun 2024 02:13:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFFF56B02C3; Tue, 18 Jun 2024 02:13:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA0BE6B02C6; Tue, 18 Jun 2024 02:13:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A64BF6B02C2 for ; Tue, 18 Jun 2024 02:13:50 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5253E1604B2 for ; Tue, 18 Jun 2024 06:13:50 +0000 (UTC) X-FDA: 82242993420.29.08CC045 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf03.hostedemail.com (Postfix) with ESMTP id EFF4320014 for ; Tue, 18 Jun 2024 06:13:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718691222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z0ihB4dlJ0rZyFEVuag4BebCNBdxinDNVO+76UvcaQM=; b=B2eTkhvaIuMu2V6CGN5Pd7kUen1Lt3UO3sIRQKKtXYOSkUEHWJPGJeSHF+Liblt9YKeWst ju+8xxswevnhvwVDkHjE2LABPNWDx3UdMRGR+Vh0vQsrCvgMQ9aqYTfsj6Fq+aegnZjaZz mu7qnxOAs1w6MRD08YNoeLbwM+t3BUA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718691222; a=rsa-sha256; cv=none; b=3+HAW3jMGi5Gs0yCAswAXXkLXW5Yb4fYs+h5jMv0HfOH1VHKPXSe0QNBhdF/G8f61X5zZR rT7v1XhN3YDMmJj75IJ8T+VAX5HbPMzNh2u/0saw2eBF0Ywc+ZQwfeD9OOHTyK4ao3gknJ KrAcuzbrCxG20QhOyB7Fjmmt/1oA/iw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 1C10267373; Tue, 18 Jun 2024 08:13:41 +0200 (CEST) Date: Tue, 18 Jun 2024 08:13:40 +0200 From: Christoph Hellwig To: Barry Song <21cnbao@gmail.com> Cc: Christoph Hellwig , Andrew Morton , Trond Myklebust , Anna Schumaker , Steve French , linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, Barry Song , Ryan Roberts Subject: Re: [PATCH] nfs: fix nfs_swap_rw for large-folio swap Message-ID: <20240618061340.GA28200@lst.de> References: <20240614100329.1203579-1-hch@lst.de> <20240614100329.1203579-2-hch@lst.de> <20240614112148.cd1961e84b736060c54bdf26@linux-foundation.org> <20240616085436.GA28058@lst.de> <20240617053201.GA16852@lst.de> <20240618055253.GA27945@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: i63cymof4yjgh41gzk7qf8uerfx38c8w X-Rspamd-Queue-Id: EFF4320014 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718691227-397532 X-HE-Meta: U2FsdGVkX1+PuPlG7DLEn9pPfoaCak5EfjxyFoNEjbaXG71pqsCKIrg1nSjM3S7MtyRNvqpjLqW5+jCZ3FWvtq2iPlyirZT6lTjLwlJ79hKBH524IhmbJ+3l6rVPl9ysfEEhbmZ65YiWgo6DfUYvzlmIPKlAy0u10p7yDUpN2JC7pPXTs+o9QnrLXAApBfRygG5ZnrnKrRRZG+mYQWgTzrr270lR/HmQfiDFC4MXEuSVClALRNtyX5qBrHjYx2Awpm7RdXunhhABdNYV8MlUSSwXibqt8a7pYvg+5+RXGImBZbjPXanemNHGnKVABrYx0K15R2ho9asNiD2zZW7afvvZ1GQdiJRTcBoZFATESSrrudcD0x/0VRDugOoB9YcbvRWBKUXseo70KtmNM9p+myD1BgjoAuLfVsASKU3gXnEh5Y6guII2m+DqcxxAGKMJlppMcABruEmiKiZ2yVg3oPakG7brqtHsPq4Qaj6xUgdFJmf2mIL4tTo04V+RwTci6ZF90g5oiLOfC+1EPOGprTEh845Zso+hgIz9R0IxP2kYyMIWnA5/CB/2V6wHdT6uykSdyYBCL/BmgQ6R7arfkGxKGx5XgafftwZFzuQMv796FlM8blHl7NPEVrmZd03AEV0gkOqz1rcxmka7B3HTJpncqgO8ZZFASyKtc2NfuaSr3hCOLWpXk09nyGzqIWQq5liCPcpxJ4oROl8gcNP5SLY/OO2KEJ3ssw2EV+c4NwQo1A3CMajuAM0Nx2Jygdd8yg8eJFTPrmBJ2rFSYt4LwbKm6ZUsLgrkdJLU4Y25IOfKaJQYZbu5L1jWbSJgOqi6N4O+LvPJ5qySItG0Jm/saAPyz+y+iKK3w2fQrAAxruMnz+VsPaIjknWBtk0ZswCsn5OnPO9GzQgNjaJr1aEy2w9XCOtHqK1JSnLvl83iVVphcHXz3QZWQA2vnTvmqreTGR2KndtNTITPjHcPOYk IM2XTCvX Q/XItywIRZKSwpwWwArbXQg7MkUciIGGtQ6uR1T3V+/Bi66Ln9K87ewfNeXZbp1hc3QokCRtlHdXc+YLTxDIqoAHFG78YRWf+OuUZTPDlGV54NAmSQjWO2ytx3tY+iYI0Epg4cNrIOwG8eef0L44ZCG2elah76mztWQq9qQPvcy0CPMXE22AVmoSMd19uZTKXapg5xHK6igFNxYk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 06:05:33PM +1200, Barry Song wrote: > Yes, that was exactly what I missed. I then figured it out, reproduced > the issue, > and discovered that the root cause was unrelated to large folios. It > was actually > due to a batched bio plugging optimization from 2022. You can find the new patch > here: > > https://lore.kernel.org/linux-mm/20240617220135.43563-1-21cnbao@gmail.com/ I don't really see any point in keeping the VM_BUG_ON. The underlying direct I/O code doesn't really care about the size at all.