From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A6AC2BA18 for ; Mon, 17 Jun 2024 16:39:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5862A6B020F; Mon, 17 Jun 2024 12:39:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50EE96B0213; Mon, 17 Jun 2024 12:39:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AF556B0246; Mon, 17 Jun 2024 12:39:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1C9A86B020F for ; Mon, 17 Jun 2024 12:39:42 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B58101415B1 for ; Mon, 17 Jun 2024 16:39:41 +0000 (UTC) X-FDA: 82240941762.11.E347DF4 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by imf15.hostedemail.com (Postfix) with ESMTP id 992ADA000F for ; Mon, 17 Jun 2024 16:39:39 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=eE5bGXUg; spf=pass (imf15.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718642375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IWxRtAR5qJF4uBtiIKe8eNonYfcI1Je3yK1kKPqzj0o=; b=vB79jB8FkfCzu03G56jDzpLehA+o7L0/MEbQ7WezFtBOa6aO9ByzWiDTl1fwVy11FZm8S1 037Uemokl5haYZalVUcQxxEvfJRUyCEc2KqaLjf6CQL6MNLVHqMvsrKrKgrKkkpNyOZCjA K2zd2NC8q9jXNsBHZuQfVQNVwmC+kQk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=eE5bGXUg; spf=pass (imf15.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.171 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718642376; a=rsa-sha256; cv=none; b=XDoelvVcNM+amBjKKoolMoyoWRxerFAGQnMhK4Qdx7zUYtGCvTx/v5yx+8FPdPsPnh7G4p mbZ2hhAVOwTbLMbeg7zZNVdXdHsY7q1d4nxXIJ2vwYhxCWmgPL7bFLwJ4Xzr/VaATF8Mnr UIZ8YODWLmQbxqZMi8b86U+kII7NiuE= Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4W2wZv4GCQz9skk; Mon, 17 Jun 2024 18:39:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1718642375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IWxRtAR5qJF4uBtiIKe8eNonYfcI1Je3yK1kKPqzj0o=; b=eE5bGXUgFljt74LCs5lsGulyZtpMxSfBydpsTmqyARyPVMi+u4j1VAGX+vDffzu+QEYco/ LkLV9+3nYyyLeHM/ACHBW258FwK1bmMIRxgxPlfeAFK0T0x4/Z2phd5lWyWfmSJObV4z+f 4jBZmIh09D72GwavVyvhYdIQVPfPG1Bi9ASwMVvmHBnuhk08aC1MOSweTLMhC5twUe92OA uHxpZYXgYJIOw3Pa1YTIFR0Agf1FTey8BGuUf7VMOwiCj9UqsxK4Cu1srFPwmJWNpFGW1J RyengNIrx0GHgoZ+BQxCnOyceyfhMSSEAP7TAotUZFgyuqAteMsJyODpGNgN7A== Date: Mon, 17 Jun 2024 16:39:31 +0000 From: "Pankaj Raghav (Samsung)" To: Matthew Wilcox , hare@suse.de Cc: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, mcgrof@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 04/11] readahead: allocate folios with mapping_min_order in readahead Message-ID: <20240617163931.wvxgqdxdbwsbqtrx@quentin> References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-5-kernel@pankajraghav.com> <20240614092602.jc5qeoxy24xj6kl7@quentin> <20240617160420.ifwlqsm5yth4g7eo@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: unz7oxh3zwq6peee1gra34jors7pesfj X-Rspam-User: X-Rspamd-Queue-Id: 992ADA000F X-Rspamd-Server: rspam02 X-HE-Tag: 1718642379-668311 X-HE-Meta: U2FsdGVkX18zXK5LXruudi2mcGWmbkFxCHisN/MKG6aqXKpeC0b31PCe1ckZiQy2wqD84oxsTzZvfwQ0DBET3qM2KCR+Zy66lLNuH3YnRMPSgrbvT2unBxozeKg78sovgUfaC/fG9iYtBOvAI+akEUuvIm9MBtJK9dvFx1cXn37r1uJ/an3Ys0QfAcVUirkOv/b/KPWo0QrQKXj93MDYyNPqD/PuxQJznct/hX97d6r9tmQWG8nkH09lgKS9rQByauiBQvseP2EtsZwep5Tg7TWK4e+9BsXfQzQ7smDQSlfVI9phjMEX9BGKOXjKH3YrJH7YRNn8a3yf3xRzbTsNvZt7CHMtLocj381Jxwvd21aYZ7pqYDkandha5srpEHRBoKM/4a/z43ZBiQXvywiKQujOoEtc/s8det5sM+fqJw+vVMDd2Op3UG6iqbIjsaCwZ8e6JGmPi6uDeRBzfQLRCEEd3hrNDFGg4rGc2DmxDxVfz/dpg/8l0A9W93/yt1ZCakNL8UTQ2xhkL9IGM2FIvQSM8qXUOR7w7AvXzggYx54KVJYzzNfOQk7Akl/VbzSbVs28zT/8aBGd/OnkBaAeFLSyumu7zpS5vpJGfUGMyaZF/ebS7XtGS0XkasdvycYybgFnV5V1WXZdSBkUkCd4fUxYSz/tWM+jniI8gt0m1QAnaEn9TqZ1UL8rs7b/BaYVcrg5RF5c0BOXnelmoh+BsE7URzxszzxN7c+t0T0unFBVOcsRNAAnOGXlbUbvFAs3Q1paD9rmLQBAjoolP8FhQVyHBNdWTT48EQa3qshT17SU1tpzRbG5PdxcF7RdXgT2tR8uWd6248ne5lP1XVAwq7sA/FSOGalYa+vLP4shEQN/q9emh9V9qLS2N+QtKIhvRsutsepuiotn78o2f04/NM12y7vemVROnkiU2HV15pcKgwqTvvxjjU1nsdClzWxQHAX8T5W313KfsgqeiUN HS+yBVcd +2MkuyHxruk6IXrVIkLjq0nU+Smm8EAuJcnPIVCBcykaEsyt/MBEB5oAPKsFVZxfdb7oTNT6Ul64tYrfxv0v3VTuJ7ZUW3Ms2WWZ+N3vfFY5HvHShW+UiSvDFCquVY9/u4lKgj6SHkUpImj5UtlKzEoOWkxrNqSmhVyIpVt+CI+GNncVGy6/iFTTKGfCqvy11f38WNfqtR1xwoYMqAdLKJCU/uanvuDJjBttVh/tEBiaAU1jg7kSmzQ77U/XpKdr9G4CoG3U1YqwvlCU2L9NsXHrhsbCKO09E3akfqUf4oLSCQxo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 17, 2024 at 05:10:15PM +0100, Matthew Wilcox wrote: > On Mon, Jun 17, 2024 at 04:04:20PM +0000, Pankaj Raghav (Samsung) wrote: > > On Mon, Jun 17, 2024 at 01:32:42PM +0100, Matthew Wilcox wrote: > > So the following can still be there from Hannes patch as we have a > > stable reference: > > > > ractl->_workingset |= folio_test_workingset(folio); > > - ractl->_nr_pages++; > > + ractl->_nr_pages += folio_nr_pages(folio); > > + i += folio_nr_pages(folio); > > } > > We _can_, but we just allocated it, so we know what size it is already. Yes. > I'm starting to feel that Hannes' patch should be combined with this > one. Fine by me. @Hannes, is that ok with you?