From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC43C27C79 for ; Mon, 17 Jun 2024 15:08:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD4196B01FF; Mon, 17 Jun 2024 11:08:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B82056B0200; Mon, 17 Jun 2024 11:08:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4A0D6B0201; Mon, 17 Jun 2024 11:08:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8353B6B01FF for ; Mon, 17 Jun 2024 11:08:39 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 17333405CF for ; Mon, 17 Jun 2024 15:08:39 +0000 (UTC) X-FDA: 82240712358.12.BE8EE2A Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf12.hostedemail.com (Postfix) with ESMTP id 4822D4000E for ; Mon, 17 Jun 2024 15:08:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=bKvQ9GU4; spf=pass (imf12.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718636914; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HZmaK3/av/+pYCO8JH+DfV1hFjKuc0xucbwt8WDUoYk=; b=5RU29lKCK6lMLeWn/u/gcqH3ZYoHzjODFt+jLRdOK6oSma3p8KyHqDPW41+WDfDngmgD3Z +eil3nb3HTepAlxSuiGWP3+U0OX2Ooxb8Qfgbxl+cttB2FJYHb6K8s4jBE7rkE/OcrzNnX 45tqhY3e4ooS4O9YpGRKPHdAZMKREzk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=bKvQ9GU4; spf=pass (imf12.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718636914; a=rsa-sha256; cv=none; b=vmmICYYl4ZeYz+NGztog9O+XCxpZ1NuxIhSWc6wI6xARlzl0BhRuIBxlz31uXGa/Il/TFF PvdZGnXZnuDRv74Ns+lpcSPTIDgYYYW9Md7eRzTU5Wu5Yb/nL4bjNgfP2F33MeI1dk+iEc MLPJ2sDK97KX2ocky9K3C/JYOXWYr88= Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4W2tYq1NFmz9sRD; Mon, 17 Jun 2024 17:08:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1718636911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HZmaK3/av/+pYCO8JH+DfV1hFjKuc0xucbwt8WDUoYk=; b=bKvQ9GU4432FpITPMwykUykx1s6cXFn0dgCan0zb3jRVjd49al+ISqMn3IZ5bqFKIrM9r9 oU+wehwV+gD9fmPYL99Aj4P0uTOQPprZ/eD4GvdKiNAgoiNjHwldBAhUza9ZdGrkv2vffB luVCyJ1jYCUGieiM+NCsB4/y/wAAis0f20MkJi86Epbffkc3DgYXRqPllJpyJmqGR93TaA QXbduQ9zVP8VWnyjFHYeD/sWeJx/zlAVQqylhwpnGlo2vbvUWGbNYJ7YnQJ4JlYvtLLaFH zB1lRVAqQxvE8DX05z1qsugqB2uZt1cfk/5eopjdSfHk5Fy+nDMD1zNI34U/rA== Date: Mon, 17 Jun 2024 15:08:23 +0000 From: "Pankaj Raghav (Samsung)" To: "Darrick J. Wong" Cc: david@fromorbit.com, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 07/11] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: <20240617150823.tet4e7y7pco44dw7@quentin> References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-8-kernel@pankajraghav.com> <20240612204025.GI2764752@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240612204025.GI2764752@frogsfrogsfrogs> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 4822D4000E X-Stat-Signature: 31dtpugs1j5kcxi86oaoyfed7ju58ff5 X-HE-Tag: 1718636915-991282 X-HE-Meta: U2FsdGVkX1/wUA4C9aO5nfe5AAWpr909ROv2TUj/gz4D7TOHgpBzAdL1dxCDABuRQMdaxq1/1F94JMBoAyATEazMvPpy4FZfZPcTd67qfWRhGtG+gHFh+RU1vu/HFI5ojJj0xMzWvcVK1z4uRTaZd6G+B7XTCV4UJ6Z7BEx/5zrwCcdxx7r4x6RrL/Ya/gE9eztJXUQy6CjhQPlSbYuODL3LBecWvtDUwHsVVPV6IGPsJ9U4PVgnk39MBBXpaupLXH2qfZgmgPHnedXB3LZO5niOmN9kIupZPoIHnLhig+xvLyHHkhri+zWyXd8r/H4ndjX9LapaXj8AfQ8FOm5eVNelz8CwBl6PLtLpqU7LAJUYJOr/Am8VzvG20ghhgGL7pcUNYQZRD9sWnOJTBKhbRtPLfwNQdv1Jzh1ZGc+be8KbNVFoQdXn422euUQ8UtbhmSdEDbrVHtnV9ORCs+qWwLLiXv45utcw889e1MnLRr6f5M+DMfWHdImXPPK+yVnZMdzR9HGYCHcmsrXvGax95J9jri0pu1hVndaH4RGKIsyke/AreiqSQ42MmIkKKw0YNFDGQC/XAlptPPWICL0EhFTO11dnLXyBm/In1S6dTmBpAv+1Eh9cVOnfc5n4kd8vgYU1ivsR2hQ/hkc8+n+IKcnHZS84h9iKsTbMjAMUyHIOLmG1Ni2vd3OMbOkWallDXEuOvlYe+1mh5md4g4X30YZhouoCCd5cPsqXvpW4s+5e5jQt7AJuz9pw9QVdVrhNTKfGAbDbAsWe8SdPdNYAhDyi2usd5YZZh9TOPqjMfrlv4pOUvsfm5Z3dUCcOqGJ8IsC+d6KTkpwFzGC7LcdXidNZoIPY8C/3Btp24SVBbefQa2aeXC9x8XkS7/c4LBVo5zfB6njzXg5vd2/uL85fFVpQ4O8qvC3g8fXlRFrfeJW44HueV5O3YrSqvKwBSCYXjpYvEfuLQr+rHqURJ1M BB6XiV+T ZT+uLmyqDWTns1DJ6KolyC8Kx9Jeg2W9H4kfE9H7g7KkEZKHjdgRD18vuYBQuodXjgyoDC6lNR4t9TCn5MBssl5PYMwG8cxKvmSESykTZuDhrwodq+VerQWKuVUop3aqtU8YqeHQxZ6c9M1lKqh+KUJyc3TuPcEJMqgN/PodR73X7ALE4ZXJ4zG5VVjBTiFjKkDxdGv+/xtPNLJmtHpxnemCb2CkAS+yzgha6keo4b3mhz6TxkOP9sMZlBlWqG7dueYWe66u6/fe7pvjGZ3e+QlduaBaxVJzu1+IMGIrdaErCGToHE7QKB7WZw5zpAq3LtqUN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 12, 2024 at 01:40:25PM -0700, Darrick J. Wong wrote: > On Fri, Jun 07, 2024 at 02:58:58PM +0000, Pankaj Raghav (Samsung) wrote: > > From: Pankaj Raghav > > > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > > index f3b43d223a46..b95600b254a3 100644 > > --- a/fs/iomap/direct-io.c > > +++ b/fs/iomap/direct-io.c > > @@ -27,6 +27,13 @@ > > #define IOMAP_DIO_WRITE (1U << 30) > > #define IOMAP_DIO_DIRTY (1U << 31) > > > > +/* > > + * Used for sub block zeroing in iomap_dio_zero() > > + */ > > +#define ZERO_FSB_SIZE (65536) > > +#define ZERO_FSB_ORDER (get_order(ZERO_FSB_SIZE)) > > +static struct page *zero_fs_block; > > Er... zero_page_64k ? > > Since it's a permanent allocation, can we also mark the memory ro? Sounds good. > > > + > > struct iomap_dio { > > struct kiocb *iocb; > > const struct iomap_dio_ops *dops; > > @@ -52,6 +59,16 @@ struct iomap_dio { > > }; > > }; > > > > +int iomap_dio_init(void) > > +{ > > + zero_fs_block = alloc_pages(GFP_KERNEL | __GFP_ZERO, ZERO_FSB_ORDER); > > + > > + if (!zero_fs_block) > > + return -ENOMEM; > > + > > + return 0; > > +} > > Can't we just turn this into another fs_initcall() instead of exporting > it just so we can call it from iomap_init? And maybe rename the > existing iomap_init to iomap_pagecache_init or something, for clarity's > sake? Yeah, probably iomap_pagecache_init() in fs/iomap/buffered-io.c and iomap_dio_init() in fs/iomap/direct-io.c > > --D >