From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2880CC2BA1A for ; Mon, 17 Jun 2024 09:58:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADFCC6B0167; Mon, 17 Jun 2024 05:58:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8EC56B0168; Mon, 17 Jun 2024 05:58:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 956B76B0169; Mon, 17 Jun 2024 05:58:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 72D956B0167 for ; Mon, 17 Jun 2024 05:58:51 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1009C16150E for ; Mon, 17 Jun 2024 09:58:51 +0000 (UTC) X-FDA: 82239931662.20.D4C1771 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf24.hostedemail.com (Postfix) with ESMTP id 305C3180017 for ; Mon, 17 Jun 2024 09:58:48 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=umgAJ6Pd; spf=pass (imf24.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718618322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SRAO++uIw1OUPfCgvfEWhKZYeaVhnnf0jX/BR+wX6Vs=; b=H40NcGQCAyOqlB+Q6lxhKpfeKdTDXK0Eu70g2azIdgYW+kvpTjb+mrjHEbInQNGVw59oBa yVq20Rf61jZ637NjGSAKbkz9b7FZT1C4HtMbGIt1MmIFzP3ymjwz9r70XFBeG1mIqtFc8S TlqJDO9xw2RzGes2j/X2fEd3Pe6va/8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=umgAJ6Pd; spf=pass (imf24.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com; dmarc=pass (policy=quarantine) header.from=pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718618322; a=rsa-sha256; cv=none; b=cGcwNfL+QEhcG14YG0PCj0cQUZtNjfiqxx9nNL+tt3d++FIBrOTR10rUtzjZ/u/dGcH6o7 836lDx1YKjlUy+KPkKNCRpzCFvPzDJlDJSbVst6JbbgP9tqjjL+qxIstBXtF7RO0wE558Z nWjeuhN6JxZPWqWRxxMhLOvet4MSIFc= Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4W2lhN23x4z9spd; Mon, 17 Jun 2024 11:58:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1718618324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SRAO++uIw1OUPfCgvfEWhKZYeaVhnnf0jX/BR+wX6Vs=; b=umgAJ6PdVIvo1wrvo40xC9EWOxHYypeWr0lw6BtV9NA/2Me5+5OvAtUc1A/Nnk9QDeWBj/ zW2B9Y7M6R+mc40tNnuCFKX5VK7/51W50WOtQK2diJavDG9ddfhPZwv/Pt22DKvS9eda9U TNQFQ+xejRkMez8YcZe65whPPPBpNlvGvLnoclr5yT0rJNrO4XXwTBt62Y2XgIoa6mZ+42 zKFgtPvP0zFDKKv/kuv2xANddBq3awOf+OHay7/HAFWtKW1MWMu7GnIHGwa2tujZ9j5c90 X0wWDh6Z7bxCpIak+bkdqfPusHr62lqpAnjaxqj+eonmTPYwVoZxK9KNh49oKA== Date: Mon, 17 Jun 2024 09:58:37 +0000 From: "Pankaj Raghav (Samsung)" To: Christoph Hellwig Cc: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 03/11] filemap: allocate mapping_min_order folios in the page cache Message-ID: <20240617095837.bzf4xiv2jxv6j7vt@quentin> References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-4-kernel@pankajraghav.com> <20240613084409.GA23371@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613084409.GA23371@lst.de> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 305C3180017 X-Stat-Signature: gstyzngieyj1onum45fuqxzy6seisbxp X-Rspam-User: X-HE-Tag: 1718618328-185800 X-HE-Meta: U2FsdGVkX18BhBrEJgLJh/JFxfQuFwfOG07QM99ljfAtFGfKDwU8Ix4okKycEqwAolYNAHiqUy0NRFKypH8qVeqbJQ8yTIH+qHi8cfLvqkwgeKDfsXj5sQSfOIICdpReKORy2zkNwpvdVwTLXknf92oXM+ycI5tMO2vDKg8JArg6Dvmf5kSDCkC7snNDz6jislONoFUTYCLoq0mvxRwEvtasfXAsr+uuG59iYY54GJNkSYG0I4bdtPdMmIHLHhu37YxXZfS7WGeRA7TAXO2AgpZQJrlfkyaY9fNOy86onPZQv+ARljd90BRkSQiuNpFApeceadYmUplnH0QwPvqMp8dNS7EV6YkkgZUrw6K6me1ffo5DYD/5P3evGw9B3se8Vg6gy9p0LuXqo1kjwAMZjFDNAcVbjOJgHrECrIIMde/QmtAjOrgFLv73MwpVs7936/nE/gs1IP+CKpA0JZxELGUvoR+iYM6/Kkp7b9uWgQo+OHbg/V0TSehmkYNNCzl7n6caHFK/YB7UHmV12fDaUYBTd8elgBmNDLuCZMduLN09Rcb03fn6G1einnIszQUjKQBMlO15IpXW/+qD0d2OvLnnx+1mCWFsJLr2MIzdiR2dBNbs/qvEvYpGh053Dn9T5Ef0Iu5V9iYnNiNdZT1XkeSgtjGS+QcKYTub7rRwhMXLFh6IWnf74R29op06pFf1RZaz/X+hWaPVhBycqrTB46inXcHIkwKUN2O0eLICDXohHysm6Y0Yz8ULLYQg2eOS8hTiI3gxyDQcAl4YtvsMzRY+YvKJ0smH8r2xczQ3oW66kUt4j/3ecalh0qlzJl6TDNdq3GG174gI8FDzW2xZ9OVOZAcW501tuiK6il+8e4iVE7WUtjK56bOpZnAMp/t4zXbS3221BGIUqm5ll3iWKs9meJ7oMKMyhkF8BVIZq17Ds3aSeWvZwbBIcwER+0NRBwdIhOvpwEDh00jYFsM HerpTJAm 5YNSBYCpkuzh7rCyxaXmndemmYQcXLbeWNlQF0ocIPf8/7oJIcYJEF7AhTy2rit0mphrQPWirSk+HyQb2KiXOt6yhYUvqjBpt1/DLOMMiVPmPiAoLqP1r/tJYoM31hDVaX9Wdo42pFWDIMTxfCTLvW+MrwJ8SMQhPpayuQAUNu1yjfvEkbQH2PgZ6Uh+U/FH7Rm/wOFWy8RRmuiXXJ02KVaIIbD8Il/UQTKIVcVC0GfgeAaV4R4JCek+5sESMKY3zDVB151lAmvHZ5brnP5pu9it2+cs2H4sDHbgjjkx0mPUuEek= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 10:44:10AM +0200, Christoph Hellwig wrote: > On Fri, Jun 07, 2024 at 02:58:54PM +0000, Pankaj Raghav (Samsung) wrote: > > +static inline unsigned long mapping_min_folio_nrpages(struct address_space *mapping) > > +{ > > + return 1UL << mapping_min_folio_order(mapping); > > +} > > Overly long line here, just line break after the return type. > > Then again it only has a single user just below and no documentation > so maybe just fold it into the caller? I do use it in later patches. I will adjust the long line here :) > > > no_page: > > if (!folio && (fgp_flags & FGP_CREAT)) { > > - unsigned order = FGF_GET_ORDER(fgp_flags); > > + unsigned int min_order = mapping_min_folio_order(mapping); > > + unsigned int order = max(min_order, FGF_GET_ORDER(fgp_flags)); > > int err; > > + index = mapping_align_start_index(mapping, index); > > I wonder if at some point splitting this block that actually allocates > a new folio into a separate helper would be nice. It just keep growing > in size and complexity. > I agree with that. I will put it in my future todo backlog. > > - folio = filemap_alloc_folio(mapping_gfp_mask(mapping), 0); > > + folio = filemap_alloc_folio(mapping_gfp_mask(mapping), > > + min_order); > > Nit: no need to split this into multiple lines. Ok. > > > if (!folio) > > return -ENOMEM; > > > > @@ -2471,6 +2478,8 @@ static int filemap_create_folio(struct file *file, > > * well to keep locking rules simple. > > */ > > filemap_invalidate_lock_shared(mapping); > > + /* index in PAGE units but aligned to min_order number of pages. */ > > in PAGE_SIZE units? Maybe also make this a complete sentence? Yes, will do. >