From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B1ABC27C6E for ; Mon, 17 Jun 2024 07:58:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 749C76B014D; Mon, 17 Jun 2024 03:58:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F8BB6B014E; Mon, 17 Jun 2024 03:58:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E7B16B014F; Mon, 17 Jun 2024 03:58:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3FF9C6B014D for ; Mon, 17 Jun 2024 03:58:05 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AE90CA14A3 for ; Mon, 17 Jun 2024 07:58:04 +0000 (UTC) X-FDA: 82239627288.29.D59A0CF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf13.hostedemail.com (Postfix) with ESMTP id BD4EA2000A for ; Mon, 17 Jun 2024 07:58:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eA4aKwt0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Tj8nkiOI; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="iV4/VjvN"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HsOasgVE; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718611078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1OWs18jQXFDiEgM1u8rR79jHDrXS+3IONMQeRLW12dc=; b=rBaxiL840T/y7iXyX5sTapzc7QVE3tjH/QmbNfM/f/DkRGFy9sSxFqjhgo3rjrnHwuq+Jl 7vZBVr0VE1T3bgUwXuQ7AxfK1/htPpUpTuZL+Lptu0zasxhz4OXgCTar7URgrrOD3We3MW 8PUUg5Q+uvXwAwM1wNV8DyjY7D/tAjg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=eA4aKwt0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Tj8nkiOI; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="iV4/VjvN"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HsOasgVE; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718611078; a=rsa-sha256; cv=none; b=wjqzVJBTFPuL/XcJYtD8TGVxMrro+owpbpBFMjfbJrxWDLFAGg9Bc/CKJ803GKPHIntsoz WX0csbzpmvBr+s5+QjOxLWIVXQCaAiNBrM2OqdJzynRtewDl8A9AJSKtXPEMI522PVKd/1 3IHEE4KUMvUme9rFNALSCILCNckhG0Q= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E0E6F5FCB3; Mon, 17 Jun 2024 07:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718611079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1OWs18jQXFDiEgM1u8rR79jHDrXS+3IONMQeRLW12dc=; b=eA4aKwt0F+sd90WSHWD2UNVr9+xY36uhNEWEK8kIjQ6alr5ZAYSUfSc65OTFkpBhjVIjT8 yVcF5K/RtjeijjGP7qbynY81VE6fE//4DSzatOwyhCbZdoO+WJQBpaXM4mrgN9JnyG5CsL 6RXiBy58m5+MRJGGn2uKFQJQv1xTr/4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718611079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1OWs18jQXFDiEgM1u8rR79jHDrXS+3IONMQeRLW12dc=; b=Tj8nkiOIQjt5eNnI0I0rcdGVCqHqQpg/yo9KTGGdBWxmoNKlig26EzuZfcsCq12SGoU0lz QSA04Syj9xRLrIDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1718611078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1OWs18jQXFDiEgM1u8rR79jHDrXS+3IONMQeRLW12dc=; b=iV4/VjvNqHWk3K7xEXCS0xXn3rkfIYQIWBGKSXApuMB6Wo09mdlVVERPJiyIbaaGwcd5lM ZgzLZfcLtwBZvZMcKWRDfdXlhGZUgBQv6PIVW3j5TypR2Rvp8YBdpzJYhxqJm/PZNROK6S kjImWecNiUR9t9W1xXWKhIAZ9U+hs04= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1718611078; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1OWs18jQXFDiEgM1u8rR79jHDrXS+3IONMQeRLW12dc=; b=HsOasgVEinePImewMQ1+yrRscfwDziQtI1ND8hakeJvO+yylbnToqQcgMfYfpeeSQDwdf8 VbZG0ZtRpfNQsGCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D6BBF139AB; Mon, 17 Jun 2024 07:57:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id W/doNIbsb2b/VwAAD6G6ig (envelope-from ); Mon, 17 Jun 2024 07:57:58 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 7446CA0886; Mon, 17 Jun 2024 09:57:58 +0200 (CEST) Date: Mon, 17 Jun 2024 09:57:58 +0200 From: Jan Kara To: Hillf Danton Cc: Matthew Wilcox , linux-mm@kvack.org, Jan Kara , linux-kernel@vger.kernel.org, syzbot+d79afb004be235636ee8@syzkaller.appspotmail.com, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org, Ryusuke Konishi Subject: Re: [RFC PATCH] mm: truncate: flush lru cache for evicted inode Message-ID: <20240617075758.wewhukbrjod5fp5o@quack3> References: <20240616023951.1250-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240616023951.1250-1-hdanton@sina.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: BD4EA2000A X-Stat-Signature: rcsxgrgnmjad6qj5zq8uqry4bb3ufz9n X-HE-Tag: 1718611080-187055 X-HE-Meta: U2FsdGVkX1+KhibUT2IW66Kc6BB58acMNPEqBvJ1bCIwJKlnA+pdmNDt5mmC2Ehf0w7TimyTx5Pm6yXMGbh03ROMo4xTPHHWOyTBVS7DQZWnWlmimXmBpByxvMNIeVi8ohrMObjKFeAGHLxckRqfz+gmr0GMrz07DzkCYF3Vg5gyjlSS8Kw9+xQPOBVO2n6Hq4GeoLsjL8CHN14LXioot0f9nLQ8E/LYA/gWDO8JetVtz/pPtRcDUB/cPioKOtogUnAyduKxoAhr2tv3Jpi7D5v7Z5cs0RWZRt19JZOGrbdTgDJtdOSXFPZ0wHyx5sAQL8GUcK81cucm5/oyCVpEBZMojpsfof6PtbqCH9mw2/jFs7urXcm06HN35GiQy6wgBKOmVvPot1BTSv/hJhJNftvABZfWq8CsZwgxr+IgX9gciw25RzwdBTPvdpRpeRshHmXAc4VPm295DUlTbVKCPN+AINSy6hN918CuQgMwgJDxg1Wk9+GAHrAVgVw3IUAobf/TQHS5jx5z2cen2awG65Pr65h7G4VWJTuXksTObJ8bM8y/83aS15DUZZjW9NWXtla/gmUSbXOK/LiZ8NSvpOqyWkmfcEdPp57/sO7Vca+Irhifk0E7Fi7ZPidNQ3lhoCzFOxxu+61jOoXu8ff6a7bs19lcPT8rkjCMmhtH8CcwiHYkKkCJLWR8IwHc3b3iF+juOAwtD8aXNw2R5sN7jKLO12ogHiWQqoMieHe/cybsgBSpsMunK4MxnyrjHqHxMDggl9vSLPsPsHefhECOpGGGHahOvIo8aonABGOZUWypxwnros6g6D+kxqbq1PAPNEEk+IIkWScGLytCkcyB5YzujUV5Qb02IaGo/9ZLS5meLh60IiKBHcV5R/7c7CsgZNXU5ohhC6gkbzAWVsvYIiNODfAkbMUBXSU+g4kZagYlSeuH15X/1yMo7SA7f4lUIbw6WzGJe3+pdjBvbqN 9xVh+z3e vLhnyBGkop/blI8kB+R2qHscBMypRBH5ocS7gN2+frZ9XbaTdszvb/Pa2ac+ZCdpi0s9+XnIzPNXDLry/NQtxpvqWcfObELUFZ8SAZL8LgSaF8EtvhtIXXlKIcNubnQVw3KaY1Ka6wYY148LF5E0Sphmi7Oo7eiP60iZcF24zmjBoY4HadppyUPNGK+BB+KMV1enVjyhEs/o8tYkqnDZKgIHVBymlx+up20ncUx0hji12mgdsLZAsTN0MnTuZsj8YGgY9w/DX9eyKgy6f6EJ//sK3lpPqKifNwdu3U2wC30Y8Ti3x8k6fMf8RTKyjoRopmhztyyiX/xBRtlXcXENwiPhzSKvA0zZX0ZDYQmWY8YoEtRFFmzNBRFQ3mPkqt5sa8UwBxP0K9/20BFl5YcXeuMZlB5X8zerWOrUawQONU4ws5oHAJAaSTV1DBQKi1k/TNCODxPZqu/DQfTfawZVx+YWIaWewfuSJTZxllEHE9dEmCUQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun 16-06-24 10:39:51, Hillf Danton wrote: > On Sat, 15 Jun 2024 21:44:54 +0100 Matthew Wilcox wrote: > > > > I suspect this would trigger: > > > > +++ b/fs/inode.c > > @@ -282,6 +282,7 @@ static struct inode *alloc_inode(struct super_block *sb) > > void __destroy_inode(struct inode *inode) > > { > > BUG_ON(inode_has_buffers(inode)); > > + BUG_ON(inode->i_data.nrpages); > > inode_detach_wb(inode); > > security_inode_free(inode); > > fsnotify_inode_delete(inode); > > > Yes, it was triggered [1] > > [1] https://lore.kernel.org/lkml/00000000000084b401061af6ab80@google.com/ > > and given trigger after nrpages is checked in clear_inode(), > > iput(inode) > evict(inode) > truncate_inode_pages_final(&inode->i_data); > clear_inode(inode); > destroy_inode(inode); > > why is folio added to exiting mapping? > > #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 83a7eefedc9b OK, so based on syzbot results this seems to be a bug in nilfs_evict_inode() (likely caused by corrupted filesystem so that root inode's link count was 0 and hence was getting deleted on iput()). I guess nilfs maintainers need to address these with more consistency checks of metadata when loading them... Honza -- Jan Kara SUSE Labs, CR