From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 884CBC27C6E for ; Sun, 16 Jun 2024 08:54:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 546266B011C; Sun, 16 Jun 2024 04:54:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CF536B011E; Sun, 16 Jun 2024 04:54:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36FAB6B011F; Sun, 16 Jun 2024 04:54:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1957F6B011C for ; Sun, 16 Jun 2024 04:54:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 791CEA327A for ; Sun, 16 Jun 2024 08:54:46 +0000 (UTC) X-FDA: 82236141372.13.7063FAD Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP id 89CB4C0007 for ; Sun, 16 Jun 2024 08:54:44 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718528083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ro6JB8C37V9YdMrgRBVxij9ik5Zo84f+MsAiQBy6M/w=; b=WqUC9vCKzndIKYFS9o1ISOfSNXy3QO3UOaIeqhruA+SmASXBzg89u4Ie5lnCAUxrctGw9a dsKryI/FqXUXMeQqbF9R2GS5CgE0RkI/uF4maMAiLC65kh3+zABb6uw7XL7iZJ+vaA5wRN tXMVEW2cS/Wvmx4VTIY5M97T9uD8ftk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718528083; a=rsa-sha256; cv=none; b=gR13OgMyxF1MOF1+3+SdGIdq7NNkHJdCWab9K0pbo3EdDC1shzZFrcy46M92ww8p/CF/// EC1/5VyMVp1xrGV9stmeF+lqq4J2b7cSsALdcwgafmXFNSBI1G5zAVN3Yvpm0UdmF7hIyP 7OEZhBOcznzj7OFQxgtelO8k36PfFGg= Received: by verein.lst.de (Postfix, from userid 2407) id 42E6168AFE; Sun, 16 Jun 2024 10:54:37 +0200 (CEST) Date: Sun, 16 Jun 2024 10:54:36 +0200 From: Christoph Hellwig To: Barry Song <21cnbao@gmail.com> Cc: Andrew Morton , Christoph Hellwig , Trond Myklebust , Anna Schumaker , Steve French , linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, Barry Song , Ryan Roberts Subject: Re: [PATCH] nfs: fix nfs_swap_rw for large-folio swap Message-ID: <20240616085436.GA28058@lst.de> References: <20240614100329.1203579-1-hch@lst.de> <20240614100329.1203579-2-hch@lst.de> <20240614112148.cd1961e84b736060c54bdf26@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 89CB4C0007 X-Stat-Signature: 1ztakbt84bgn75718ps5owwbmu34zr51 X-HE-Tag: 1718528084-198949 X-HE-Meta: U2FsdGVkX1+V+HzaTVfvsUCoLWjxWKL8pdvxkE3shPFf5+Y6Ysp3EY5XNVgiT3YiypTAWu4pge+XgiKtyODqn+NEoi5TjQJmxqQLuuVdrp34isgFx+1IE7SKruCBPosUJ382BMRk7xr5ND65u1UXtwCvlrAa+HCC/OAdtj1kM9MaA10dGKyfKt0jk8NsxnXz7se3kWnTGUOxUH1euodqr0vl2JdyKYLPw5WA55ATlzL6lHmJYPdJA//91Sx3UmmWOIKzY2fqKqIFQXYtpxgCN93Tl4iPfs2EsgKaD7OcPDOsdfTZ6h3RVG0OLRE/JMzEs5HoARQfDPoJhYRBVtZxS4iLoU9RrezGKVGvQrdcgl3qWOcPM2ljURP+e6/GtzJJ8JeZSFOGqGhqnj4wTGneN01brK9sGNVmZGxPe3zsYiq3hbyCcKvqKs/Ve6Z9vCjIUogqkpcsLn1rlLAZ3XdwUPgH+NKpibgWKQyRrXcwCwG4cjy/kf5gC6I8xEFGUqmj/lpuYnQirj3cO88NlXJes+nG3KrFeoUyAK+ggatb5LDJsFCPP9OEDRFuMcPaR7UPyG1Eo95VeK/8vFN2DCst3PUtmGcl4fZpi4FV4sN2oZZVT4UbT8U2fjRSFpkwzRegL9IrpIICn4EodLC8ZArJxkIk8/06tPCIcIcWAc8R1WQEJyzk/gcmPh1+2h7C9tTbnpyvMAEMwlJypMmsFZlAabrJFxqvCKbFthyoUsX83CJeEBZpx9CoIHL46RxFU/EnUd1AdnKFUcsxFSSTLPv9N4edB7NusqmlOC8kDw2CCp0odsHwkl3mlz2EecduPCyTMmBZ9PEXX4we/WpK6SNs26QScqtZG5/zfQVDOOxoGuss2ubbDa1n2r536bQpfFgddXMdADLCjffZkGOSC2TtfVocwYbq+GV/0cP8nixuEqzt1HRBrZawBKyD49xVeq8ibHx16Znw2E1Ds0w/Os7 ijJi1Vl/ k2exXa7snwmmwFqqLQhLCD1bTmrTYa4AfXLiMVip28XRC7VUDR+gB9A/hCPMwkEJ5/PkdaDYDwzdvOxJ7wwXsxQCaqYr2Ifbf0Vct957/hfni7TeIoAIyRDPwbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 16, 2024 at 12:16:10PM +1200, Barry Song wrote: > As I understand it, this isn't happening because we don't support > mTHP swapping out to a swapfile, whether it's on NFS or any > other filesystem. It does happen. The reason why I sent this patch is becaue I observed the BUG_ON trigger on a trivial swap generation workload (usemem.c from xfstests).