From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D3CC27C4F for ; Sun, 16 Jun 2024 02:40:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75CED6B0111; Sat, 15 Jun 2024 22:40:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70C406B0112; Sat, 15 Jun 2024 22:40:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5887A6B0114; Sat, 15 Jun 2024 22:40:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 37B3B6B0111 for ; Sat, 15 Jun 2024 22:40:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7719FC0E64 for ; Sun, 16 Jun 2024 02:40:10 +0000 (UTC) X-FDA: 82235197380.13.99F7B13 Received: from smtp134-31.sina.com.cn (smtp134-31.sina.com.cn [180.149.134.31]) by imf02.hostedemail.com (Postfix) with ESMTP id D6ADB80006 for ; Sun, 16 Jun 2024 02:40:06 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of hdanton@sina.com designates 180.149.134.31 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718505603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j1AdtiIcHZTR6u7TiAugDJh0MLfCRYph4GCrQzaketE=; b=qKXlsOgzKg7oGuxQe2DJaCMBK/ynzezBMMv6vudpNe6hj+I9iPH6PNRAa+MK72v/y/VKla DUIhFQDdfUTHy/vWsqVX60h9TwYf7lIS9RzWUon70uoJf22i7ozPTlLCu+s0BJMfqrwNPW gVQwXpo8Qr6XFqv2ZE0p09dEOvjyRnU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of hdanton@sina.com designates 180.149.134.31 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718505603; a=rsa-sha256; cv=none; b=ykUjeaUbvRHsnGVb7h2XvCpVKnq/2iZbpdV+WxBJmwpsFVSuNg1Cwu79jpIOUi34C0OIkT HCyoaRDa96IjvsdS/0/RY+6/wF89LQVqfUMm3oPFGEfLCbYPjOHQWzyCoDZKNtclLG8DaJ ZElS0WPiI7b4jsSy1rtULOKPkE1oGzo= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([116.24.9.2]) by sina.com (10.185.250.21) with ESMTP id 666E507E00004EF8; Sun, 16 Jun 2024 10:40:00 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 7761573408381 X-SMAIL-UIID: D0200C16404743458945B9D848C2A235-20240616-104000-1 From: Hillf Danton To: Matthew Wilcox Cc: linux-mm@kvack.org, Jan Kara , linux-kernel@vger.kernel.org, syzbot+d79afb004be235636ee8@syzkaller.appspotmail.com, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org, Ryusuke Konishi Subject: Re: [RFC PATCH] mm: truncate: flush lru cache for evicted inode Date: Sun, 16 Jun 2024 10:39:51 +0800 Message-Id: <20240616023951.1250-1-hdanton@sina.com> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D6ADB80006 X-Stat-Signature: ej57pem54pzqwffnd5zemewwwcix6fmy X-Rspam-User: X-HE-Tag: 1718505606-451154 X-HE-Meta: U2FsdGVkX1/vNe/fPofYYARXCEsDwGeHgTK5FJi50rexry1KFJfOkDgUE/dF8o3M74vcrn/vDITZnj/StWfd+dAUmbVAoYSkBGimxFQyQyPe4vIe3JYc5xhw1xmdV30OuLQXlsNGhvZ3kX0pbsO74MPZqyWJAvHDfW/xaGLTXKUjMgHxRZVZowv7zDCXYx+wP9MfQG3lWjVneS8cP4czLq72dR3topVsOAU2XzIDzUckTFZiX3m0IS5+LxItYsmtA/qaVedcoATTjpgZM4iMmHf7cn56nlfJmIRWhZ2M45zWI+z1QXjI18SvZ1WBjF6U9mGv2TocmgIxyKmC0y8dInwWQxFbBj2AE6Y2bH65jfSQJRowTfM1NU4gxc4ljjk8C/xjyL/ajeVk/NWayfaAqMb63MiZ4qimbUiFXXGfCyWFACFwCRgOaJFx10mnhHQBI9cPXtsNQP/+s/IYm1TJ9PO31x2yMIBjG5bHEZFCz1Y5VFt7CD8yMTCwFxxsJNyNTkYwH/J5GpMipv0/T+6tK20SFN8KCE4qnkzElDaeEF9qt2bZ2YHlCwU2HTN2Y1BsGLnLy0Y6silMU1ya0zmq0onHGXjtPYaRZ8a2PyTBeo+fY3Jkmc5RyFEfKQI0xn700dhQYCiuTqIS5+UUo14OikNJIRMHLLlQMss19AVUvv+qS5LKUqyN2jJDPi5I99RpI9+dOFoPDSy6sAePqJzTSA16ZjEvB3A+BgYkV7BQ06jcvmXhjZjsjc0E15QN7h868drdD2CKTU3P0Drg3KrF+NLVm7m7EGA6JATAQEzHXg2lry4vLaX5Pjm+fX1O/Ct9p9/5tLn11NnGM9skEQMiSHvRswVJVBz6KUX/deCCdNQOQgkgpQxcXDpNxAbB2wA4YtJWw5zTeLwAsx6rQ46UbxA3eD04+wU8Ptk2ivjHdA8LsTjktQDFxL1Vw1KYNM8p3GL46oUrpEKb+VcpZtM 4Zkm4Cxo 1hgmzuSn/gQg+Ewj9ZxTnCcH7XaiMzDIIZENNoHTJm4nQJcbiAAlF3RBXZf4QsFUiMG/7xkH8hOf28zaQljxUIuHxQfCYdAVtY1S7VW1fPk7qJFPnqJfQ4AR/haRlZgLbqtiT7Y2+CO860Ng64Q+hv1nnu3RDF2myqFwIPnbJqpHCZztHEwsggjfyXbJOrkuGHkjSfGK9MC6GNDpQ3YJa3h6Pm2ANYIfTX6DrSCKJMDNpF/+ktiRH4NNvFxpyj5LG+pa7YbsuYNwVYJSRqg7qNoixrMXsqYlELHjgCkI9Pm7j5nyJVJ+2HK8Yk8OjmYmMgeDNyx+kUdq2KTc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 15 Jun 2024 21:44:54 +0100 Matthew Wilcox wrote: > > I suspect this would trigger: > > +++ b/fs/inode.c > @@ -282,6 +282,7 @@ static struct inode *alloc_inode(struct super_block *sb) > void __destroy_inode(struct inode *inode) > { > BUG_ON(inode_has_buffers(inode)); > + BUG_ON(inode->i_data.nrpages); > inode_detach_wb(inode); > security_inode_free(inode); > fsnotify_inode_delete(inode); > Yes, it was triggered [1] [1] https://lore.kernel.org/lkml/00000000000084b401061af6ab80@google.com/ and given trigger after nrpages is checked in clear_inode(), iput(inode) evict(inode) truncate_inode_pages_final(&inode->i_data); clear_inode(inode); destroy_inode(inode); why is folio added to exiting mapping? #syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 83a7eefedc9b --- x/mm/filemap.c +++ y/mm/filemap.c @@ -870,6 +870,7 @@ noinline int __filemap_add_folio(struct folio_ref_add(folio, nr); folio->mapping = mapping; folio->index = xas.xa_index; + BUG_ON(mapping_exiting(mapping)); for (;;) { int order = -1, split_order = 0; --