From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B67AFC27C6E for ; Fri, 14 Jun 2024 13:06:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9608E6B0089; Fri, 14 Jun 2024 09:01:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E8936B00F4; Fri, 14 Jun 2024 09:01:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7630E6B0152; Fri, 14 Jun 2024 09:01:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4FF906B0089 for ; Fri, 14 Jun 2024 09:01:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0021BA04BF for ; Fri, 14 Jun 2024 13:01:26 +0000 (UTC) X-FDA: 82229505372.19.36B7AEF Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf07.hostedemail.com (Postfix) with ESMTP id 6FE8F4003E for ; Fri, 14 Jun 2024 13:01:20 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=m81n540M; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf07.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=j.granados@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718370080; a=rsa-sha256; cv=none; b=ez6NB4tvGtbtyqhp/RHkIbdStdvYd2g0kiu7YL/mhvMa76dU1gpsNesNsY1HueYsTEW8Y3 ZYaBV6+VVAPW1kkE8S7DeCIspicJbD3d3Lv4xyjbNTjZ+325dtUS85Iczqp8G82bR3HtIK dQszEimigFBLYhyeRhvupSCpFZgcuM0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=m81n540M; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf07.hostedemail.com: domain of j.granados@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=j.granados@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718370080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cu9Kth/VrhXwdZCe9UNE3CqQju5jHEgy4z5jh3by9oU=; b=RcF7vGVzBuFcHktEvnTp+j/o3XnL8sbvvZ+TVEfaKzgWjnW9CcoDqUD/oYmC8chn9oAWLD 2Wkq5TbCE9iYrLiabzT9hvkfnS0rMyvUaMn58tf0xQrNISMCwp5bDdHpTP8JUVyQ1ge6Tt BpQltg4hijSdMthfX+SIF4RY/Fwlrwo= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20240614130118euoutp02dfecc4453e4d5565d87e9eb670493aeb~Y4HtQGnK-3084830848euoutp020 for ; Fri, 14 Jun 2024 13:01:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20240614130118euoutp02dfecc4453e4d5565d87e9eb670493aeb~Y4HtQGnK-3084830848euoutp020 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1718370078; bh=Cu9Kth/VrhXwdZCe9UNE3CqQju5jHEgy4z5jh3by9oU=; h=Date:From:To:Subject:In-Reply-To:References:From; b=m81n540MYWTAA9ydrCEFZoh5sPrQ3Qz8hD/mLU7LAD8raEfX7M3BXmZ5BQNE8jawp x2EX1wDs8vdMzyNoYeVjXPiiT7JPk4BUINRz0R01I94fu3ui6GGwxfaFoB2/j0Y0In vTwvo8IV4g7FfBTbGoqs6zTLJdzoAtf3QzSOQiik= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20240614130117eucas1p1c39ba449271398be15a5ea68c843d411~Y4Hs5JJlv2271122711eucas1p1P; Fri, 14 Jun 2024 13:01:17 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 57.7C.09875.D1F3C666; Fri, 14 Jun 2024 14:01:17 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20240614130117eucas1p2657abb565497200b6f1425771ae37129~Y4Hsgg1rh0312203122eucas1p2F; Fri, 14 Jun 2024 13:01:17 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20240614130117eusmtrp11437275246ceae19229be6dbc6195987~Y4Hsfyw_q3250832508eusmtrp1L; Fri, 14 Jun 2024 13:01:17 +0000 (GMT) X-AuditID: cbfec7f4-131ff70000002693-9d-666c3f1dc2de Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B8.D7.09010.D1F3C666; Fri, 14 Jun 2024 14:01:17 +0100 (BST) Received: from CAMSVWEXC02.scsc.local (unknown [106.1.227.72]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240614130116eusmtip2e539933a9e2dd0d084995254c57ec5fa~Y4HsMU8NA1374913749eusmtip2N; Fri, 14 Jun 2024 13:01:16 +0000 (GMT) Received: from localhost (106.210.248.168) by CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 14 Jun 2024 14:01:15 +0100 Date: Fri, 14 Jun 2024 15:01:10 +0200 From: Joel Granados To: Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Suren Baghdasaryan , "Kent Overstreet" , Andrew Morton , Luis Chamberlain , Kees Cook , "David S. Miller" , "Eric Dumazet" , Jakub Kicinski , Paolo Abeni , , , , Subject: Re: [PATCH 8/8] sysctl: Warn on an empty procname element Message-ID: <20240614130110.rovlk7be2ytkcm6x@joelS2.panther.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240604-jag-sysctl_remset-v1-8-2df7ecdba0bd@samsung.com> X-Originating-IP: [106.210.248.168] X-ClientProxiedBy: CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) To CAMSVWEXC02.scsc.local (2002:6a01:e348::6a01:e348) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrIKsWRmVeSWpSXmKPExsWy7djPc7qy9jlpBu0vlSzmrF/DZrFmSyOT xZzzLSwWT489Yrc4051rMfv5V2aLC9v6WC327D3JYnF51xw2i3tr/rNanD52gsXixoSnjBaX Dixgsji2QMzi2+k3jBbHew8wWUy+tIDNouWOqYOQx+yGiyweW1beZPLYOesuu8eCTaUem1do eWxa1cnmsenTJHaPEzN+s3gsbJjK7PF+31U2j8+b5AK4o7hsUlJzMstSi/TtErgyju48ylhw iKtiwoQpzA2Mezi6GDk4JARMJE4/AzK5OIQEVjBK3P68i6mLkRPI+cIoceGGM0TiM6PE17Yz YAmQhjn/mpggEssZJZbun8sOV7X04V1mCGcro8TLia0sIDtYBFQltk6QBulmE9CROP/mDliN iEAvq8T/LacZQRLCAk4SE7ZNB1vBK+Ag0bRpLSOELShxcuYTFhCbGah5we5PbCAzmQWkJZb/ 4wAJcwq4S/y/eIkN4jplieWnZzJD2LUSp7bcArtUQuASp8SqhkOsEAkXiVcLtjFC2MISr45v YYewZSROT+5hgWiYzCix/98HdghnNaPEssav0ACwlmi58gSqw1Fi8/R+VkhI8knceCsIcSif xKRt05khwrwSHW1CENVqEqvvvWGBCMtInPvEN4FRaRaSL2ch+XIWwpcLGJlXMYqnlhbnpqcW G+WllusVJ+YWl+al6yXn525iBKbC0/+Of9nBuPzVR71DjEwcjIcYJTiYlUR4Zy3MShPiTUms rEotyo8vKs1JLT7EKM3BoiTOq5oinyokkJ5YkpqdmlqQWgSTZeLglGpg2lj+um2ldGWZXL/o 2ReTMhVb89hPVhx0CG7je14w84j+S871C/gOC5i+TttwX8p3BqPrjvnahmbv+udJyLLt/m95 ooBj4hq/1/uzIi8mHLcpmWzFcirhe0F1N7vKd9PoyYtuB2V9iJP+8jfk1betk5Tkoti6GK4e nnRhT8sP0XmfQiMiyyskZuzeMZf7trOJ1IX7mZyOFd2zxHSvpbnd4N1X3+Zxxs+xaWcqu96t WZvUdrYUdD+5510np2i8PfjZ/XPO1r8jfkuuE4pZ/mXyqf1eNZtPun78IbZ0/bmbZSl3T2xp v2Tg2noo223PtAi7Q2vTv87yZDkvEOGfYCu2qkhJm39u3rIzIhx3f9/Zp8RSnJFoqMVcVJwI AKUgeSX0AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t/xe7qy9jlpBl/WclnMWb+GzWLNlkYm iznnW1gsnh57xG5xpjvXYvbzr8wWF7b1sVrs2XuSxeLyrjlsFvfW/Ge1OH3sBIvFjQlPGS0u HVjAZHFsgZjFt9NvGC2O9x5gsph8aQGbRcsdUwchj9kNF1k8tqy8yeSxc9Zddo8Fm0o9Nq/Q 8ti0qpPNY9OnSeweJ2b8ZvFY2DCV2eP9vqtsHp83yQVwR+nZFOWXlqQqZOQXl9gqRRtaGOkZ WlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehlHN15lLHgEFfFhAlTmBsY93B0MXJySAiY SMz518TUxcjFISSwlFHi44EFrBAJGYmNX65C2cISf651sUEUfWSU2Hy5gw0kISSwlVHiyD3L LkYODhYBVYmtE6RBwmwCOhLn39xhBqkXEehmlbi26DYjSEJYwEliwrbpTCA2r4CDRNOmtYwQ Q68zSlxt+MECkRCUODnzCZjNDDRpwe5PbCALmAWkJZb/A7uaU8Bd4v/FS2wQxylLLD89kxnC rpX4/PcZ4wRGoVlIJs1CMmkWwqQFjMyrGEVSS4tz03OLjfSKE3OLS/PS9ZLzczcxAmN/27Gf W3Ywrnz1Ue8QIxMH4yFGCQ5mJRHeWQuz0oR4UxIrq1KL8uOLSnNSiw8xmgK9P5FZSjQ5H5h8 8kriDc0MTA1NzCwNTC3NjJXEeT0LOhKFBNITS1KzU1MLUotg+pg4OKUamNT+r56rsGbGjJeF On6TZnsEztogKpO/sPfl5yw/t9id3dNUK1Y9uFpg4f/EpNYn6PYciRPiksf/df4Td47LlpcU m1HjbVHbL23yUdJN5nTawzvLLxw/2n0xu0BOy5ElSSX2hKKzQuupTbqTZl9r/s9W16yn/ULz 1NTaydznVWe8CGK8yl6Ra3Dv59RDqSoXgnwElbe7aPY/37G06N6rBZVd05d4nun6GRYkMGFR nb29SL1trHXyhVkCTEZnNR4+jXhudVLksOGWG8km7S90X3Uzbpa+rZ985Nwm4QWvEqa6HbWz uslzb34z4/TuvUbtPx2/PPTRnPTzrPtsydmyh7XvP9Q0kjjx9G6avkngNiWW4oxEQy3mouJE AF8X9TCGAwAA X-CMS-MailID: 20240614130117eucas1p2657abb565497200b6f1425771ae37129 X-Msg-Generator: CA X-RootMTR: 20240604063006eucas1p144c1d1a90606e5cd0c1852c6270ed3e1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240604063006eucas1p144c1d1a90606e5cd0c1852c6270ed3e1 References: <20240604-jag-sysctl_remset-v1-0-2df7ecdba0bd@samsung.com> <20240604-jag-sysctl_remset-v1-8-2df7ecdba0bd@samsung.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6FE8F4003E X-Stat-Signature: 1rkwjnxfiaffinn8rrz4h79uhstpiugm X-Rspam-User: X-HE-Tag: 1718370080-379741 X-HE-Meta: U2FsdGVkX18PJRwBD7vNn4Amxx2X/Df10S/dsifeJPbJo9wX9llwyy7bFyreoE7oxS5VztAtEuwxs2HqBBu7TRMoX6OAOd/klObuS7r5gWbqsrpj0c51KnFb6l1qrD+rtk4OYUudx1/6TJOd2v77Keak7t4+ojKk3aF8CxZilkMnfYM4+l3YhwM3HCRnFau4nFcldEIvk5ugWKRZWT6rKSRd2J5gPzFLCiJ0KEq9ODpP47Zc+RbOU6oj31FHigcvvnCgBy5ZD/vo6tK5K1LJ0i/7+SDJq+taw4I9AeVoZhZe4/pgzQ6AW3kAublhSzXrS0kNXsu5waqEwPT41k6Drn+/YPCwU2AvGezOveoPGpnHpopdec2miePAMb+2gqxFxdWRJD+8rvsz1IqnZ9Hu5hWDSVKXiHo/VB4rkgyf9VzrfuVgLhn0J+axQ2+Je/0bEksiWZJKZRLcDKTX+1ZeqOZTWfoPfh8kzzUQFLJY8QLJmTRjCLTdMYQtnAbsTjlHtzJlhG2yZYMyhH0Og+0Xctw4irO8tErb9BN9NtFXA+qMrlvvcR7DbIWcWd5cVRBMNj0GoX3QPb9K6lktle5Vdr+ml3rFEgdm3hNbGMaGLOTlF1qL0c6FuRHZNPGB54bq6hOqmZ/nx9K1gYLTtnwhmrNwAdFfSf6HNtu7Lw6fcB0zOyU7IiwAo0/m8KioAGFqe4M/Ll4+vWjJHzAYO5sr47+TyWi3vSbkGvjtzbmsLO88hgdAdv9oG2E7Vd77mdTYAf1JItrtauUMiSHYzL+Aix4TquNkNcwHO8sr457EDwaCmiOyRCIQcbH6VqvGcQkxf1vby94II+kQ62zmbCaa2ZEzBBsWfosJAW96tVcqfHShGg0e6D7pjyR1PX2Zqo7Sy47bHhITP90kSdtzahDRHaEl2v5VqX5NOgs4pJAik5GQdbkrb/qMxp+OOV/NXiMFB3HdIPh35qSYgeH0nqm iotkIO4f gljooSGKnRgFt/OPWW39VNx6OYjmp7jqnMAs3ZjNPZItNbsSxvp+iBTN0WPP8oB17NBMhbMUIeu3+RHFNa7ZWOxjGr8ojJnrcQjwODhAaZyStgMb4gKQojEbCKQvPji6RSKl9LNPmN8TE+JNpsjghBc+938oU3ijtoLzEGy3K912kTvp9owAe7HVZjNnZwx3LZsMy42Gw58IcdcC26OiHQwg4UbX67knrgl4M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 04, 2024 at 08:29:26AM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados > > Add a pr_err warning in case a ctl_table is registered with a sentinel > element containing a NULL procname. > > Signed-off-by: Joel Granados > --- > fs/proc/proc_sysctl.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c > index 806700b70dea..f65098de5fcb 100644 > --- a/fs/proc/proc_sysctl.c > +++ b/fs/proc/proc_sysctl.c > @@ -1119,6 +1119,8 @@ static int sysctl_check_table(const char *path, struct ctl_table_header *header) > struct ctl_table *entry; > int err = 0; > list_for_each_table_entry(entry, header) { > + if (!entry->procname) > + err |= sysctl_err(path, entry, "procname is null"); > if ((entry->proc_handler == proc_dostring) || > (entry->proc_handler == proc_dobool) || > (entry->proc_handler == proc_dointvec) || > > -- > 2.43.0 > > To add to this check, I sent out a static analysis check to smatch in such a way that a warning will be printed out if there is a ctl_table element with a procname or prog_handler that are NULL. You can see it here https://lore.kernel.org/all/20240614-master-v1-1-c652f5aa15fb@samsung.com/ Best -- Joel Granados