From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185D3C27C75 for ; Thu, 13 Jun 2024 21:28:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A2AE6B0099; Thu, 13 Jun 2024 17:28:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9522D6B009A; Thu, 13 Jun 2024 17:28:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 819FF6B009B; Thu, 13 Jun 2024 17:28:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 63D046B0099 for ; Thu, 13 Jun 2024 17:28:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 25F8F4031D for ; Thu, 13 Jun 2024 21:28:37 +0000 (UTC) X-FDA: 82227154674.01.CF36A40 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 637534000A for ; Thu, 13 Jun 2024 21:28:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718314114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bb90th8kXQ2jWVzPthxfPjivb6yfbtDU/yMaCpfj870=; b=EU9nJ+S7QY/fKuvZ/dL7kVGV7tJAzRi1U4n+ihYOwjAvrhSyVz5BlGDCBZGHVOBONKPOzL Fl/wxKCu6pi3d8XDqRlGZx91jMWzF1spWsM4dRj+o7YHz2Ra+knQPR4T7Hfg219lX4qFwC 3An/+xjK3SOGXa0W7uYKElthPjZ9+yw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718314114; a=rsa-sha256; cv=none; b=0wZXNzj2M7GhV3k9pMNFsGk5qffuf8Mj9ZJ8FW+TgmMTV4BNWLHvyevEnmxxiybensDOuf UBZBDp/TzUoPRJxmn9FGc+1lu+AVwxBI88ByB8NMJd8Av85LdkVAK2R0g1M/50sJ5LJtN1 CsYrM4EBLQOggQjKoe3xbb33X2/NQl8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3340B61B91; Thu, 13 Jun 2024 21:28:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B108AC2BBFC; Thu, 13 Jun 2024 21:28:32 +0000 (UTC) Date: Thu, 13 Jun 2024 17:28:31 -0400 From: Steven Rostedt To: Andrew Morton Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] linux++: delete some forward declarations Message-ID: <20240613172831.5e7f762f@rorschach.local.home> In-Reply-To: <20240613142110.30019a4084d922d63c6d4352@linux-foundation.org> References: <5ad5556c-7c32-45b7-89cf-f723c9d7332b@p183> <20240613153402.3b067d4b@rorschach.local.home> <20240613130420.a62ed8965a73b0f8d35890d4@linux-foundation.org> <20240613161012.1dd2ff60@rorschach.local.home> <20240613142110.30019a4084d922d63c6d4352@linux-foundation.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 637534000A X-Stat-Signature: bxugofg16hmzz8argtbe1957xsy5n64c X-HE-Tag: 1718314115-420998 X-HE-Meta: U2FsdGVkX18AI0yRn7J+TswYntBafCFR0iFmf9WCfFl3cAcmzNh84kH+dWkvkXeiyzXQ7NOxWEopm5uH0+QnIXjv2zoezW5rj7OjFQyJFLGz1Jw5+7TO9M9dusB6htcyoTbueiwvEmVv9mbh9C5UAwdMKXgp/xIjwNoiwo/5EPrfByB8rF0nApc3WhmcgclPg6CCl70RIeZbNyvtCVdOgLhlBs4oq84kjIBsYpduvYk7fPscP0mtHyVNttSF392nVrchkvVxVKkgI5il2oOVbbGcCZ6bmPwlHaISGpQDGkhGTv4ZhjyqS3ww206URaDrLaAKjKzwpVYxqlTeJRxW8rUSHCu5anOFhpZSbxCG/62LdtnG7No5WlW/g72oDI2vdFP3mSrQ6pnBJtH1ZGXuAYvWF+H4LICFr4QtLx7mAIs6XofqJB+N/yZoSD74bWB8VekyEjccTVDebQcWtxE8LJzOafsqyWUPr7ShYThq6tpw4RfhQQLF1PPZspkL8lziOMpWrDmpAwdxKWPAAXuFvZHFiCgmJyPg+Dtm+2lBasCrtRs4dHw+9g+hOPIkTiTJuAi7WhYyNwFz2n1QP+SEcJGW7P9DYQfrLbhMq98JzB89NRL/8B/dQNnCvO58S+de/18roel6cg8XnxFkj5pb1flIutjXP2MIcAPmVxCz4SCkaqA3XiPnh4tEJ67E16v9/4UZBTLH77DEKojNkkgCc5wlP435eEBb2vYv6bqFVoMVNeksbHGBq2f3ey8X2pjBvcPYkAnUwWUsegWumAAXCQSWD+0uRWjmM18g5OFSkaLNwsU1UgsFrFplqOlj4JWeT5j1zmk9jQwaLzvYuSV/+wRvT6qLx8YWWKprr6Ez9V8DGhRPatmRitOzr/fXP3STz5CSh/88I/4Qrt/9RohQCKxHoE9kJFwi7qzL010F/O2z2BeI20Ep60UVZIaL1HsxUiV/g6ujJ+kQzyOenX0 eFDeF3tk 9yUNurNp6pl32TXxNB3vypSzTq58RdykK1txigHRqWQXi9+SoZH5jAPR3CPgI5juHm/TG/TE9/xwMP743s1e+a790KLxHYuDOWB95z0fFQpZAVU/BJU46qw3ZJS8DSs2fmZShe7NqVMYMde0hb0cf6nDYIRQY4ECG2hwFtJY5qf34wV0nOC5eeJrCRiIkHtIE+Gct3CHq1d5ZZptozNx22m3wW/o/HfxD3qY2KKyagYecd/3M1l+c6ygpyYALjWVELOk1Aqa2WN0zuePyMDsfEg+P99EcGBW2Tftcj+GrdYJ3F4qfumdeOTIHYSR9WMa74uj3j4Kd9/rwaA9pt4ZhxFd3HXzqdgkdHSADc7kdXaz5mwE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Jun 2024 14:21:10 -0700 Andrew Morton wrote: > On Thu, 13 Jun 2024 16:10:12 -0400 Steven Rostedt wrote: > > > > And... I'm a bit surprised that forward declarations are allowed in C. > > > A billion years ago I used a C compiler which would use 16 bits for > > > an enum if the enumted values would fit in 16 bits. And it would use 32 > > > bits otherwise. So the enumerated values were *required* for the > > > compiler to be able to figure out the sizeof. But it was a billion > > > years ago. > > > > Well, I only looked at the one change in ftrace.h which has a > > "struct seq_file;" that is not used anywhere else in the file, so that > > one definitely can go. > > The risk is that something which includes ftrace.h is depending upon > the enum declaration. You mean forward struct declaration. And if so, good! it needs to be fixed ;-) -- Steve