From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26562C27C4F for ; Thu, 13 Jun 2024 21:21:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD44A6B0092; Thu, 13 Jun 2024 17:21:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A84586B0093; Thu, 13 Jun 2024 17:21:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94C1E6B0095; Thu, 13 Jun 2024 17:21:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 77E0A6B0092 for ; Thu, 13 Jun 2024 17:21:18 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0144C1C07DB for ; Thu, 13 Jun 2024 21:21:17 +0000 (UTC) X-FDA: 82227136236.20.DC1138F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id D934E40023 for ; Thu, 13 Jun 2024 21:21:15 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ufbtqggP; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718313675; a=rsa-sha256; cv=none; b=EoNesaWJfq7JO34sYy372L34MmYD+sI8pOA+bLehFi9dHYUEXVWwe5IVWS1hsuh/1De7BG l14WyZCKJIAYiPW3U6qFy2R/UPTiLEMPmIB7QxIrjBdEY4zyVbcyhEyWdVtSdD3gnMQrkm GapudpIMyR7AqIRn/IPx6M0BKkVpKKA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ufbtqggP; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718313675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bgqVnxvHM4IyYNyliLdLk097AI4+kaSENwwxxQ+TAWg=; b=WFY9+Fc/6BVrrX8VQUgXhY00yFofBrc5hPJ+Oub3wpJ/fNLvckttiNf136qGaX5LPkvrPY Z+OmZPC03Z4ZLFvrgQ5a7UcOcBnS5SG9+DqyEBXUOgSIn9Zfst87bnqXY6LZeUqVU3U9Y5 eeLj50YUf7O3ciFn5HUr+gll5N2jF64= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2E385CE2792; Thu, 13 Jun 2024 21:21:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CA7BC2BBFC; Thu, 13 Jun 2024 21:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718313671; bh=tIVI8sDxoP6vcgbRqp/b+XMQGtqvU/991pldqPDDpVo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ufbtqggP0qaJWrdyuqK5JCm+amuWgHEKBTQAJvq5bYk1bRoaLGybAa033rBWFP5EC UlzfQnjdB/G2RD3fX9gn+0HedIfldL8bmA0C28PVro8Jbtc5B6gef5OYfZeGFDay6Y mlvkoxIoQt0gOnqRVafCCcl8uX0yOtsDDIlEeP7Q= Date: Thu, 13 Jun 2024 14:21:10 -0700 From: Andrew Morton To: Steven Rostedt Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] linux++: delete some forward declarations Message-Id: <20240613142110.30019a4084d922d63c6d4352@linux-foundation.org> In-Reply-To: <20240613161012.1dd2ff60@rorschach.local.home> References: <5ad5556c-7c32-45b7-89cf-f723c9d7332b@p183> <20240613153402.3b067d4b@rorschach.local.home> <20240613130420.a62ed8965a73b0f8d35890d4@linux-foundation.org> <20240613161012.1dd2ff60@rorschach.local.home> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 19phuswedjbtc6uiszfjyn1ggakaz7wh X-Rspamd-Queue-Id: D934E40023 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718313675-255402 X-HE-Meta: U2FsdGVkX19t9voI7ocUWh67z6UxsHNV9j5oDEXYNY0RcN6v9dEsKOYij8IXjZbsUgwFvyHyDILYP2Yo/xApg5qrvrScKR6tlfsfHr2hXLeXYRZCU8PVouiicI1M4NqhV646YdDioNM5kML+ha2wvc7CQ21SJXGygBuniX/PiY+xW42iPghkcaSBCo+u2FiquQ2/D/PlBOvLs3xvCl8ehKQlZ+VmnaUa7MwzMItxN+gjvDTsaxAzHG8YQWMH9bs5ON3r7TxM9bkhkh9lGWDwceHqCazd+tPiiU2HNEhwo/1oQcCChhZ71xJdtBvEyCCmbnigZc5d5Hk5SoQtzQiailyo9YMBBd6Nf3vPyEcXf6enaDAuyO96R/DYsT7D5H9ck9QZJJMBr0XLeS6cKubtUDRGh7FufxQZT7hQp2EWVLNxyvEi6o4K5xBdNSxB5dyLBo6ZLAJrfG6YRsfO2bDFoBwBazpo6cn/dRp3M5aD4xYHsLC+JUVc8hfkJDQi5ZD/+qx4wEzUMdSL3d6UTs3fEQKMD3Sw+4Z70xmVhsuS9Ev1UB3FzdOCGfKAKr1a8YjwzvLf731OSeoLLr4yUnBNNEPE0/eq5V2GMHh+F9dSMwhwJn5DUTC/MbXwuJrG+yWd2yYLu3zyWQyMq2WpolvWkWagz5PwOqjPtlAJYWZJbNgqmPDg0v0JyT1Ght+wsXk4mo393IF+QQarb0dcuWpQpO2SSPEcsLpnHAQ+6HgZ61wSFHE7/pJDsbzymGgThb6I3aWC8j/C5XzRPYay+cptvGR5RXwwvajFJExVahRgCW2YbGjn/5icSu9Olz80lJFEkRoK1vKUSAzZStkhp6DRZBL84NzVYh5aJtCldd+aGUfAHb26IQaq9iOUMVSXtXMTCF3Y2A81yHGjxgHM0JyshHftfldebFvcTqtdGbvyirk/6HPO1G/EBMdhX8TJK8fLyh4h0PfuzTc09ASKbD0 pxos2vLw qfmuBl104bMWsibYtsUsdFSdniR0cyeB1H11Gs/2KRc0FegNv86zNv4xaAIXkGw5aq0zoqeXBqVtO/cxQN0K1kPgVszpiGbQjsPMmpUC+gNoDFqIn6oJBtcSLYidj14+Oi6f2xPGpOWfR7jDOM+qq1d44E5eOoHuEzG9qhDC5m8hovY3U977uUw2Ytubi/pqj986KX9GuOyXCxqf8pkKn5gtyAM7w3VBEt19U1DMPxGsCGjDNJU4nHkRDO66rCse9Y4QI92jIK6We+hqctKbVdyFz4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Jun 2024 16:10:12 -0400 Steven Rostedt wrote: > > And... I'm a bit surprised that forward declarations are allowed in C. > > A billion years ago I used a C compiler which would use 16 bits for > > an enum if the enumted values would fit in 16 bits. And it would use 32 > > bits otherwise. So the enumerated values were *required* for the > > compiler to be able to figure out the sizeof. But it was a billion > > years ago. > > Well, I only looked at the one change in ftrace.h which has a > "struct seq_file;" that is not used anywhere else in the file, so that > one definitely can go. The risk is that something which includes ftrace.h is depending upon the enum declaration.