From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0956C27C4F for ; Thu, 13 Jun 2024 14:07:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 794F66B00A1; Thu, 13 Jun 2024 10:07:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 744F86B00A2; Thu, 13 Jun 2024 10:07:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 633FA6B00A3; Thu, 13 Jun 2024 10:07:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 438036B00A1 for ; Thu, 13 Jun 2024 10:07:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DEB59120134 for ; Thu, 13 Jun 2024 14:07:49 +0000 (UTC) X-FDA: 82226043858.28.CFC411A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 3076A180027 for ; Thu, 13 Jun 2024 14:07:48 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q2Gh31x0; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718287667; a=rsa-sha256; cv=none; b=5Os87AxMQcG1dXSO4Dfmk3tfpc+THg6Xe9Fjxp4CZlTrXLBQpSNrmqKqmfV1E9FykG7iRZ ziX8+DUM0twXYd/a/tsh8sWGwHXj6gByD2lnwQRAaOarq5ZG3Hr86VcyBr2GDp5mxsZRhA dGMXQNCGkdNtrVWY56uDuIPXPA2nj/0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Q2Gh31x0; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718287667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to:references:dkim-signature; bh=cAi3uTPHOhTOds1569/cZOW+Bo/ZhwjwFMbuAaQh6bE=; b=P3uSlfXaodbGzui7Jf5zI9F0aQMDYtdcbQti0YVsZOcTjcmSAvGLVFDKOpc78jn7cKMOvy eJEcFu5oytZNEjkyqKRCl9O0qN0jHQ15aFulFuKSQpsS84ADF4L2cxmbnuHgzGv0Zehnzi 6xDF2a8oPoY2GTkPCyyqSxAYYwMHzEA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 597F861B5C; Thu, 13 Jun 2024 14:07:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 830FEC2BBFC; Thu, 13 Jun 2024 14:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718287667; bh=odfp1TpgeErbFjJ61Se8vEzIbx/qU6+JD3DTGwxuJtk=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=Q2Gh31x0D8g+FDWZnBJ4HAyMYMjVk7RRlq9uO/0AyrM13tWmr2HVLbcigsBbvVBBW 1VjNa589ejVuxOYtWXUj0IKD9Xfx977Gg8zRrx9cv7+bNbGExDAVOcpBQqpj4aJ+Z1 MD4HjSxYbfUSAttpDVRdLUHUO5KY0VY8WbYlm7pcoBYWQ4x8Ww+ztMuR/h/9i+wXxx ZT86AZO+IFS2ELHnLt2kAqh/IdrAENiicumNSjxi7SdBL1qL9HX7i2Stlq1HD1uyAh 5frETOxA7lkrf/IZuHk13SkQwy6m8fRZiVJLZ5qn8sZIZAOwdeSpTQHuxUKItzKTDW 0rycJZY4fktsA== From: SeongJae Park To: Honggyu Kim Cc: SeongJae Park , damon@lists.linux.dev, Andrew Morton , Masami Hiramatsu , Mathieu Desnoyers , Steven Rostedt , Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, 42.hyeyoo@gmail.com, art.jeongseob@gmail.com, kernel_team@skhynix.com Subject: Re: [PATCH v5 8/8] Docs/.../mm/damon: add more damos actions Date: Thu, 13 Jun 2024 07:07:29 -0700 Message-Id: <20240613140729.27177-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240613132056.608-9-honggyu.kim@sk.com> X-Stat-Signature: sfqa85segdyx44k1qhk11p191aabjqdg X-Rspamd-Queue-Id: 3076A180027 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718287668-342060 X-HE-Meta: U2FsdGVkX1/8VveFjkNm0tpqdmdLYDIanHoMYKgPAz72cmrq6/S1iyXO8IYrw0VUzrPfWCCSFvTUDVpvUgK/j2uRR81MVliCqRwjN3tiZt0WFK1r0jaLFcaoKAg+ljypU2G0RbkAZwx4m9KQSkCEs0rCxs1Ti1461Lbjd0ILS8mIjzZkAIVWNCDzWsyvbu2XMIVVN3xES34wgLCmyQnLHaFqi8P4JtpWz8m4Kfdd6BXRnz8AlOwVrefq1HSB4DSs4hJYpeZPf4XEWys7pLtpBMertGzMSVKAtZ0QZZwc1Z+uEd9gQ+HbTxM6x7ZgYId/Lkqc91oK4jd7wxt9B1tRWcyOa4T6WLZtu+cYHBIHamMOL+4yd01M+0wq11lXc/jC9dR3Ifk3M1dEr2aG69oEmrV3daNgxxatEpmDNrWvvfF6MaZR7SEdjIGLch00f9eM3r5dm3MYkHG5RGTOTrufy98vEEpW251yljskNnLefZe9oUhpNXt7sMLW7I46VW96N6VJunLoJaD+TTI0ZvMyno3Bo5UC5L7EfJr8YxU2Nm5RLMJyerpjxemI0vt1aVkuIzeS4AvKhkistYl4rrfSdke/RMWb0HQbctNu86ms5yNPdvJXAvsI1JaN5lmvKzcAZVkqxnkRWL7ZdT9EJA17t4OGBr2RiJo4HXJJCYfvoIkd4+4pBauENde7OLn2HlilCGya95LVyKe5H01IEJLnx8/cPudCGYs9EEKGO81EFwFrBRIT35THJoSqCPiMKmudTtSg/Xy28vK4WzpkfNEp99Ltg/l+47aDeVWqG7SIeyNlqrNCSNZdTELrKqi0SuVoin1PNdp1S3z6wmgOC9EC8B5kk8O1E565fL8BkzvVX4uGeV2pmKykWvMq3DNCNWRbO5z557cUpJr6xnxo+2ZCzxn2X49xrc3iftOQgrHgWu7Nbtl8bz19BFbxnMlUj9uubsHe/KZne5NrDho14A+ hYlcprHG w3IihKqPoFfWkB9LxGHdA3tZCqJhg/H5FUjFYBRUv4IuDCEiqv5TJygA2v6eIigBknNUqgN1kkUM6BWy1Q0V5wHeIBnRKcj1nq7klHJHfrKjgX094kfiz2+fbQUIQZIyzPuCM3gSwo5KHkmOyC0ZxMNi70TetVHZh1GO1gcUiDk9+A9TMsGQwYJRWltJ5hItjKlQO0R4gWJxYwdo8wRV627RPItKzSengp39qFvPDMKxEM5RpGa1osCnMDm4gGiUm6dTHtOTvtxUFEfNFmVz6dqome1b6xcXTODbYVt7TQ7LJqsBXH8dURZYNRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000060, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Honggyu, On Thu, 13 Jun 2024 22:20:55 +0900 Honggyu Kim wrote: > This patch adds damon description for "migrate_hot" and "migrate_cold" > actions for both usage and design documents as long as a new > "target_nid" knob to set the migration target node. > > Signed-off-by: Honggyu Kim > --- > Documentation/admin-guide/mm/damon/usage.rst | 8 +++++++- > Documentation/mm/damon/design.rst | 4 ++++ > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst > index 7bff54963975..84d62d16c9f9 100644 > --- a/Documentation/admin-guide/mm/damon/usage.rst > +++ b/Documentation/admin-guide/mm/damon/usage.rst > @@ -300,6 +300,10 @@ from the file and their meaning are same to those of the list on > The ``apply_interval_us`` file is for setting and getting the scheme's > :ref:`apply_interval ` in microseconds. > > +The ``target_nid`` file is for setting the migration target node, which is > +only meaningful when the ``action`` is either ``migrate_hot`` or > +``migrate_cold``. > + > .. _sysfs_access_pattern: > > schemes//access_pattern/ > @@ -759,7 +763,9 @@ list on :ref:`design doc `. > - 4: ``nohugepage`` > - 5: ``lru_prio`` > - 6: ``lru_deprio`` > - - 7: ``stat`` > + - 7: ``migrate_hot`` > + - 8: ``migrate_cold`` > + - 9: ``stat`` This section is for DAMON debugfs interface. And to my understanding, this patchset is not adding support of migrate_{hot,cold} DAMOS actions on DAMON debugfs interface. So I think this part should be removed. > > Quota > ~~~~~ > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst > index 3df387249937..3f12c884eb3a 100644 > --- a/Documentation/mm/damon/design.rst > +++ b/Documentation/mm/damon/design.rst > @@ -325,6 +325,10 @@ that supports each action are as below. > Supported by ``paddr`` operations set. > - ``lru_deprio``: Deprioritize the region on its LRU lists. > Supported by ``paddr`` operations set. > + - ``migrate_hot``: Migrate the regions prioritizing warmer regions. > + Supported by ``paddr`` operations set. > + - ``migrate_cold``: Migrate the regions prioritizing colder regions. > + Supported by ``paddr`` operations set. > - ``stat``: Do nothing but count the statistics. > Supported by all operations sets. Except the DAMON debugfs interface section, this patch looks good to me. Thanks, SJ [...]