From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CF4C27C4F for ; Thu, 13 Jun 2024 20:18:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF8386B00A7; Thu, 13 Jun 2024 16:18:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C802D6B00C0; Thu, 13 Jun 2024 16:18:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFA5A6B00C1; Thu, 13 Jun 2024 16:18:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 90B636B00A7 for ; Thu, 13 Jun 2024 16:18:58 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1AD168030D for ; Thu, 13 Jun 2024 20:18:58 +0000 (UTC) X-FDA: 82226979156.16.A4EF721 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 5E23F80012 for ; Thu, 13 Jun 2024 20:18:56 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="Bf5/YajK"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718309934; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wx6jOPXztgYs/zdxpsoEV9iH4lRhvPv83o7h0HWZtgg=; b=H/789vu05lr0JpVifCj9rbNwsmRyDbXLOL4WNN5sqQ6AT1TGavQcxbUcPjlN0AvOPI32fY JB/cXtE75pfy7gchgIMYAlLeFd2/F8rQVEBJSzJBvcqvX+8MJ6gxa/W7SocjJCR2iNYaGG DytmkkJiaSd9glfzXi2VuwZUyuBtwAA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718309934; a=rsa-sha256; cv=none; b=s3EPri8F14uYP4YuTt4oi6Y6wOeJpLA0KOWMpWYvQejeAH1Q+hprdTxlMqpuIiwen3XIc+ 1fxnwRScrR2P2FsxX/djt61ulNgg6gBOA92v+M5EFOyXiFDAAw4CgR/J1Hy/1CbBEXnbB5 2/Mblnl50POlKAv2Y2Xra8GEup9a/WI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="Bf5/YajK"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5F9AD61D33; Thu, 13 Jun 2024 20:18:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D924C32786; Thu, 13 Jun 2024 20:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718309935; bh=tZkWlPzsEIJD0w2s0YudkX0DW+VefZKFhtp6mC0r2IU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bf5/YajKc4bfbaMnNBJtRIpnDJlNphOAbPvgJhaNCxXLBU5O1cF2Vv2cdDksmwZ8t 24wyy/nVoSssXL2C+IQDaESgQcRd2hVNQwRF4vQZqJDdiaf4+wuo3rN8uEqqqzl1Et OW0XOY8HY+vtdqMwTvzMuRNA1pMauFSPHlAQ5qao= Date: Thu, 13 Jun 2024 13:18:53 -0700 From: Andrew Morton To: Uladzislau Rezki Cc: "zhaoyang.huang" , Christoph Hellwig , Lorenzo Stoakes , Baoquan He , Thomas Gleixner , hailong liu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [Resend PATCHv4 1/1] mm: fix incorrect vbq reference in purge_fragmented_block Message-Id: <20240613131853.814a40233d36d57f868f9a39@linux-foundation.org> In-Reply-To: References: <20240607023116.1720640-1-zhaoyang.huang@unisoc.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5E23F80012 X-Stat-Signature: 8x8mm9m4wsihdeuipe861gmb6fzkpo47 X-Rspam-User: X-HE-Tag: 1718309936-575695 X-HE-Meta: U2FsdGVkX180Tg3W1q8cnuv8k8Isq22hOMSmlXWbYdZsyoEeD8RzluOQLKHLnc+Cd0wwP6QEY3dk4YtbzNkJdWlp+qP33pOFzAIn9Nf1qeGqItzCXzx0BCOZg/4Lp2sM119JAuL8YE+maZVDVTSqriajRLb8FcXwK6ynYRiX0l4pKp2G71IMHOud/TgpbKpc6MObNsQPo83rLUlpSoCapsFUo/jCSPi4TzlVe10eQybqONgTondUU9NOuV0q6fOInrN9t5OFIKfA2ZTHiW2HJa1WvbSQ/CNSiWbxjGbbBkSvqQ0PHonsnVHLmTvApclm/kEFD5iY/ZljvcHv3r/VAzWm28fRZ7CkbqG4NLTvx4Hc1/7W9hMxvoCUx5Br8XAeOnT3ASnXvhCRU8+U+kTqxveNpzfOWQdcR1KWwnZWSw6rVCBV2hsA2xorN8cw4v3//7CmhhQ6wkPKxJLKrQoR/g56aQ8vjVQpWOQU/J97+RPGbg7pbK+f750fc9JeebKOO1GZQQPLK4gJzJbQov7JzUGWhdLQmMYFmDcZuAepsjZdeMp+l8M/voD0jparGEhrM4c3lRm5svQ/Y1CFGrYul/2pfZsK8xWo3CWCo3qumCsDglffl/D3//kI6yHZLtrB98IMmsJJlzv/9u5GPZf5IXshgI2/1LtB77NP4vUIp3CPZ9DX3XdKnlRcLIYXJQ2DWXyTb8ibBN5WsvE8NI2xbwkaZpk9tIWer+3EKUHphNNpNksGqYCyAHBwe6cXvHMYor6gd5Pq3/9JWAZNhoAIhQQOLUgC+t/3aHwWj+rBIguVFkHBMQzJQ7qnVaMktQn5lb6AWvWBSBai40DKndOxNg65lQot4Pf/XdhjV0h4sCgefYICsjDJP/NAy/8SHRxr8bC1t3lG7uBMKdRXyWKxSY1tjIm5kPGLoWOuA5wgxcI9UFiysTNVR1nyGYJXOWMTphoZ0zOEc3XXrnATVsy VVcRsVet 6fkmQ5tUnmY1WD20JjQbzwPdkFoM5uxwzJJy7OPwERGISaMPbKYK7h8mcMTpYgcwvjkJxViRhomMSVzWWsey7SuzGKxSoiV17vKFphMY98GNyal3+8EsGoM1GdQZaxWImrte2k9ap2PNtPlGGmnIiS1Gnc498e23gqAp73YtMAhLri3v0Ia6ZrP8iua9PL6TUKSVWxZ6JpdsLfw3JkH19MUlZ6UcuXycOYxDSfGc+AUBvd14FvOop1NhxDYzm7V0ISt4C24UmPH9jAQgNGVFoF2kE63A1qHk2d65pNlKukWVclkXdR24iraNOuJtJ4NCq1p+S1a5MhvkqGSTGgikwIOhnymvkkmqJOQi4p/s46yVXFEIj4owyWnMUHAvYrD+8JCZbAn967ThoMo15I1H26xt6DMIVm2XfbT+t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Jun 2024 19:33:16 +0200 Uladzislau Rezki wrote: > > 2.25.1 > > > Yes there is a mess with holding wrong vbq->lock and vmap_blocks xarray. > > The patch looks good to me. One small nit from my side is a commit > message. To me it is vague and it should be improved. > > Could you please use Hailong.Liu explanation > of the issue and resend the patch? > > See it here: https://lkml.org/lkml/2024/6/2/2 > > Reviewed-by: Uladzislau Rezki (Sony) Thanks, I'll queue this (with a cc:stable) for testing and shall await the updated changelog.