From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AADBEC27C4F for ; Thu, 13 Jun 2024 20:04:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC12F6B00A4; Thu, 13 Jun 2024 16:04:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E70886B00A9; Thu, 13 Jun 2024 16:04:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5EC86B00AD; Thu, 13 Jun 2024 16:04:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B80FF6B00A4 for ; Thu, 13 Jun 2024 16:04:28 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 45455802F2 for ; Thu, 13 Jun 2024 20:04:28 +0000 (UTC) X-FDA: 82226942616.19.AC46308 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id 03F5440022 for ; Thu, 13 Jun 2024 20:04:25 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ePHLIVEv; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718309065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l/UDouX2eR39eIs19JeRDpsYn4gvZ58aHbTbEq5SZ7Y=; b=CUK4VcOEkomiU/sqH0OQxBaeC0rqTZT5B3JcAmfHtxpKAXPoUCuJ9gZ89DWS5wJTuP/THu 8nPep+E7hUs62UWAis4bG94WZcKGF3b8dFPNCu1bkoGOj4BQRStDJohct0F439VEUUC0CH uFG5alUHGbwmpJegAw8VUFFP/05KaCo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ePHLIVEv; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718309065; a=rsa-sha256; cv=none; b=IaJYQypIqfWYRGqZGNIMdC9c0rJbGSOOqIhmiPsAjM6aWGf/R4lWKWicZCMOuSa4JvzZik NynDuv4WKo/0U5G8SJ8r0ZF/gv/v2hi/KLoeVUhEBcujhaki4v+IfhoMffu0igPnBsYAsg C7MTThSDpOB9/osfSIOVjCB43SxCnMA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 18D5BCE203C; Thu, 13 Jun 2024 20:04:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DBD3C2BBFC; Thu, 13 Jun 2024 20:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718309061; bh=MEYJeXpmEp6BsUZfvlLwZ3nWqwRD7HkRoo2XmzDvoq8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ePHLIVEvf8YkzFBvOsUPZOXxGRHALYvuZtGNX5BBtWzd3MVoYIbpOuUjGZIoy45vY l2wUwpQXJrsqaHe8kYhTYe/HbJCZ41HiWLztGV9odkdwdUzLh/bV9/ej1kW/PAYVZ3 jr33auWyfX2eFeOywquKIjzxXlNEpP4kn02ojBfo= Date: Thu, 13 Jun 2024 13:04:20 -0700 From: Andrew Morton To: Steven Rostedt Cc: Alexey Dobriyan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH] linux++: delete some forward declarations Message-Id: <20240613130420.a62ed8965a73b0f8d35890d4@linux-foundation.org> In-Reply-To: <20240613153402.3b067d4b@rorschach.local.home> References: <5ad5556c-7c32-45b7-89cf-f723c9d7332b@p183> <20240613153402.3b067d4b@rorschach.local.home> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: ifkgsjfe7t56793aby377bdomn7oky4t X-Rspam-User: X-Rspamd-Queue-Id: 03F5440022 X-Rspamd-Server: rspam02 X-HE-Tag: 1718309065-609596 X-HE-Meta: U2FsdGVkX184N7Yk8Uy0Ueu2nLChdvsPvqHWj+eJBSwkedRtvzLDDZtYhnsEfQgSTc5gvoU4Qil+dN9H4ZkaoUahqkag8ZQUXwjnoKGGEX31gj+HV/wTOmoLRMx8yrvwSiZvjPRNTVdRpo2Tb+WtVRWy39XgweGlodm1IVU9mnrzgCWhnCkkze/vX4qloCrNpVg3SmXOVO1aqKlB7ATPS3bB+m7he3Pj3oAkK3gkUm/yZzd1XrnR+pzy7CT//Q6I+FuHr3J0GvIg8z4ad3lhu2D+GiBUDneeBSm1wjgB4Eaf9TuWwF2lWlboyQy/oOS2IkLSpY4C4UfVGk+tMKK74LQkKQ3W9BWTdlR569phMoKbEnjQdzi/asi7N73Y203BIuc0bDs8RA3HDDhWrlQmqyA+nBNi2lxWZBN0B4YN4ZLVnL1RP4cibh24G+GBd9dq99sdYa5tuxVW8bhrPmeSCQpwW42KjtuhH8dSIRI0mv3Y/7CSHbC62sx0zVDPgAoVaQ78GBG7cSAAqj1lUd0UXMXvRvwy3UUcduQsDXnDqOG6KwxJZgmaOABx8BKG0VydyBkMVRJBQjJQEGRWW4sMKJxj7WVTJ3TgzPrwwplyzJlh6kNZOxmaZePdxjrXZeUdMjS0AZRiiv3Vdqhz5mqr9yXU+8f0nSlK1BkCo79syO8BczbYNH5oon0mT1mGbwyoWKyJeCZaoSqNW1pOdVy17oF4VXpZFEGmsKFbwLTtZsok3jsjzpiCyK2Oc99Smgn6qD+ezGHIeA78A1UNlNLJcQxjBUJHe4yzFj3EzrTwE4pQE+Q7xPSvHts2lpho03mFt57p0yCKpuVvWYvlZEvs0F5LgeBI/suv5FdeDt5+arWsaZrHC6FuX6TjNK/aJ+nrsjZD5/lnYqMnJa98O/J5zNJXfGNq5FcKB8p6Qon+4kKkT4DQjyFECfIWb7OpY7KuC4qRBpmmRGbKKl6eaTM 1qHiKoAA /5s9vbsj/Zl3G/HITfWWEuk0IFxG4R8yZdDUyzsKQCuYfFX0bQDHnLgfMUij0Da6UbBUSBIqfPx5+ldujAKKzYJP//scqqQfNmR41DaJV1IPJmfu+laK6dB1FtkvLKp/vaNZoIwMPZaVdMfnPGgvzBMkT5XmkakjWagyy1Q5Q7ak14ws6oVcqdlfzBGFAMnaMDUlaxASvBW8ucCKyL2KkPvokgaDl/DxaSlv9g5D/CSCG2p37nHehuhrvpVchbn/nPKrTZ2PsR6mgwmR5aUj8wqbNhbGMwReV8uYJtY2EmkYTI4fU3mX5I3uqM7Nl2M9ESoViKnKbfGoE15s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Jun 2024 15:34:02 -0400 Steven Rostedt wrote: > On Thu, 13 Jun 2024 22:22:18 +0300 > Alexey Dobriyan wrote: > > > g++ doesn't like forward enum declarations: > > > > error: use of enum ‘E’ without previous declaration > > 64 | enum E; > > But we don't care about g++. Do we? It appears that g++ is a useful enum declaration detector. I'm curious to know how even the above warning was generated. Does g++ work at all on Linux? > I would make that a separate patch. What are you referring to here? > > > > Delete those which aren't used. > > > > Delete some unused/unnecessary forward struct declarations for a change. > > This is a clean up, but should have a better change log. Just something > simple like: > > Delete unnecessary forward struct declarations. Alexey specializes in cute changelogs. I do have a concern about the patch: has it been tested with all possible Kconfigs? No. There may be some configs in which the forward declaration is required. And... I'm a bit surprised that forward declarations are allowed in C. A billion years ago I used a C compiler which would use 16 bits for an enum if the enumted values would fit in 16 bits. And it would use 32 bits otherwise. So the enumerated values were *required* for the compiler to be able to figure out the sizeof. But it was a billion years ago.