From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3E12C27C4F for ; Thu, 13 Jun 2024 13:26:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85DB26B00A7; Thu, 13 Jun 2024 09:26:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80C9C6B00A8; Thu, 13 Jun 2024 09:26:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D42A6B00A9; Thu, 13 Jun 2024 09:26:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4DF836B00A7 for ; Thu, 13 Jun 2024 09:26:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D6D5640548 for ; Thu, 13 Jun 2024 13:26:50 +0000 (UTC) X-FDA: 82225940580.09.3FC91B8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 32110180006 for ; Thu, 13 Jun 2024 13:26:49 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718285208; a=rsa-sha256; cv=none; b=zjoi7lkd4lkywmK5Loj+9hDSSDuiCpQG0F6fGUIqOtFM7w0ONb5fJwxXfkRNtUSVkVx1LJ qH+QPWITMqf/wQRfF1TNbERTHwY8vAW9eTm/6IjtE/E4sSOcCyAWQBMBHgGTdUFwI1dsDG cpktzTASoOGKsqtaj8JknFyr7MRxiYw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718285208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rtNg4t4TRGzGpJBJihi+Eeh3vsgaKyLkPnShxp1Unkg=; b=bmfym+l5ZY4KdI2RdeD23wuJmP5pbgUTCIqRTzRylPLE/K1tJbo/XGawULhcUfd46Uae5q xrup47XIWW1sNej+Y/XR5Vd9cq0U7Ip7k0rhtSQK7MNRg73oWiQt00IWIf87n0oDYZGVpb lII401sQp6sgA782y+Tc1qANU+lN1PA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 32E8E61B29; Thu, 13 Jun 2024 13:26:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C307C32786; Thu, 13 Jun 2024 13:26:44 +0000 (UTC) Date: Thu, 13 Jun 2024 09:26:42 -0400 From: Steven Rostedt To: Ard Biesheuvel Cc: Mike Rapoport , Kees Cook , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon Subject: Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option Message-ID: <20240613092642.385461d5@rorschach.local.home> In-Reply-To: References: <20240611144911.327227285@goodmis.org> <20240611144949.703297941@goodmis.org> <202406121145.8860502D7@keescook> <20240612145228.5bf426e0@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 32110180006 X-Stat-Signature: bme6mds7yrdjf3btnpb77q91pu16zkn1 X-Rspam-User: X-HE-Tag: 1718285209-842716 X-HE-Meta: U2FsdGVkX18J/mEgZLvvmC6WcT+yuU/EXlWH1xEDr7dv1e2j7NeIdcP/HuLnbMAE3HlN6zPBbrR2K4/vqS+JTjJShQRO0PV8HqU+SXFjh9AwpeTdBPOjCqgMUMZ5iQzctqJBI6XNnmxmDuCX/wSWzPeEeDOqMjHiecih4LlgT4ADEleCBRjr5kh4NYLX1FQ0pxrYIpmbN1z1SRWAz4c/s9JRY28nlO3rCydaQgMx4kTr0Ik+2IRcNda52mQ0P73w5vJYHUbDRUtgXyZluLbXcI9VdnExnKMpmr1v4bCofGwtPW+5QtONcP3+xMYUFkprs3JwdXpU1Za3ZU7Fg0tAmvXd0ffELrkwI0MkmF6qYQJkC5hZ8fDDlSMjy+/+Mn5UJmq4pC0i6NoOz0Hi6DN4DmhP4SGXdYBJoHP3DRHzxQma7JUArNP8PKaQ7fg5PbdUYUzhkAr1HuPZuupTMHqkhQaPe0DB0SDShyAURmNJtJ+j96d8zQTLMTTozF7zGB9LK/aQEnFpfEKXy2Vh+ceUPRfoDJ3rymcIDiKGNRD53U2sM5nPxU++GWsDXXvn3l0Cdw1JingL5ov6jS76XHecVyFiW6hJavmFOj0/fYMCp+bmH8G62IITqpTQudMGugz+D/do49JBFTGTEyolKQGrIIAypdmY5zaS0EDGZBl7GNThf99Pc03sV7H3n0oneB8myoDIpnfyR3xYPFOW0htt0cgpamblQiHyXY8YRKMxMed2RcIaRXwLs7OILDHfXA3wPbseSCMYQxCl6bqYaQwsok62gpGrv00la69ja0bA0hSOXvAik3N07usKM/LWDgPSsT6nqIXStEaYIJCeYKrCQ0TsowhsHPYV+/NxW/hm5SRfpbl7WLy7CgEEveyWRpw8gdgp588BdTxo5nptPFFVzFL9Yitt/BZyHw3+w6/hq656wlpbzbr4RZdbVMsf15VmbvvZTxWvReyJehLLYRz sRTaUyUT GVntQVaJFPf98G0GkZlWYt/58FEi+0RP2wkTn9ShOpr4wBfJT1SFaMqhlVPkCjzAucclSkkfHh8KJkqmDbQ6/rrDtBtbazD9XOnLIuQNKNeoU55+CIGA/LveyNs+w0vH0PZFkrODReexep/tWXHZNLQfKepZG8kbXcgismTQapjlhcJUoEQoU4+x/vYaViI9I+lWUP5gGUfGuAMdhy/Td3hli3/QXPZLYrsAEykkyVxdUE8JsxsnwaAlEFNOZ8zTnSGd9p57GL+62PhmBEdWhzhvp41uygd6qxrt9EHe7eP8eAzTo8l6Lah7QYyYruTCh90u/MWDSqxE+fXIJFp5pUa6b/BCHaOuq/Ltz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Jun 2024 08:11:48 +0200 Ard Biesheuvel wrote: > > > > I've added one more comment to v5, with that fixed I can take this. > > > > So how is this supposed to work wrt to the rigid 'no user visible > regressions' rule, given that this whole thing is a best effort thing This has nothing to do with user space. The kernel command line has broken in the past. If you update the kernel, you can update the command line. There's no "no user visible regressions" rule. It's "Don't break user space". This has nothing to do with user space. > to begin with. This needs at least a huge disclaimer that this rule > does not apply, and if this works today, there is no guarantee that it > will keep working on newer kernels. Otherwise, you will be making the > job of the people who work on the boot code significantly more > difficult. And even then, I wonder whether Linus and #regzcop are > going to honour such a disclaimer. Again, this has nothing to do with user space. The rule Linus talks about is breaking user space. This is about kernel debugging. Something *completely different*! > > So this belongs downstream, unless some guarantees can be provided > that this functionality is exempt from the usual regression policies. I disagree. kexec/kdump also has the same issues. -- Steve