From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D547C27C6E for ; Thu, 13 Jun 2024 13:20:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DFC16B0096; Thu, 13 Jun 2024 09:20:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0691F6B0098; Thu, 13 Jun 2024 09:20:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4C306B009D; Thu, 13 Jun 2024 09:20:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C65646B0096 for ; Thu, 13 Jun 2024 09:20:23 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6E4DF120B0D for ; Thu, 13 Jun 2024 13:20:23 +0000 (UTC) X-FDA: 82225924326.18.2226A5B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 53BD280002 for ; Thu, 13 Jun 2024 13:20:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718284820; a=rsa-sha256; cv=none; b=akq9Wyf1PtgFuZyRBW5/UM5tkQe5NojCvLbsxevJB2gFqBRHJQWwzoYWGXomNa5W+Wb7Ee jyuiXYNHMTK2L6qH+gbzlaMCr48csuIA2idiNjNTfPyHAzZT6zSPIjpHbg0J3eDvGXa4xf whm9tZyTlsqxK76N8/dI4kv4kihsF5c= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of "SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=ySKb=NP=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718284820; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zGFP+b/COca0mlG4yMNIePS5t0koFu7QdtN6l55WWac=; b=0hkv7D7dSUWoeAvfi7BY6TmNHlrgLKVtPH9NTSOz0CqZ8dOjoIXyhmBryq7lIABAdWOYXL StOTATrAciM3666DwkdHEE2anBm2JShlQ/HZ/USXce9vcqPXwOF9udziX0MVZ2dABzB4xR Udnwyjsn9ZqD8nKUGjTdpE/RTNr03pM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 58184CE2638; Thu, 13 Jun 2024 13:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAD09C2BBFC; Thu, 13 Jun 2024 13:20:11 +0000 (UTC) Date: Thu, 13 Jun 2024 09:20:09 -0400 From: Steven Rostedt To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon , Ard Biesheuvel Subject: Re: [PATCH v5 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up Message-ID: <20240613092009.5fffa4f3@rorschach.local.home> In-Reply-To: References: <20240613003435.401549779@goodmis.org> <20240613003508.752963299@goodmis.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 1y7tr63tgoua9yj6bnuxwpds8hp5uor7 X-Rspamd-Queue-Id: 53BD280002 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718284820-131127 X-HE-Meta: U2FsdGVkX191+Z2oWBYp/W45868BohPdJN28TaZN/rHULiSDNUV2M344vwE0nZ/Iw3/O2lNPxuQYM0Kla+bnBfhlgY8XXLt+IYtyz+m40xcIPD+cQUOSR/Y7edg+/9q3O1xqLAVKm2sROOesl0vzIpsRfnou7dgg+JomEiPkgDCidA+7DK5xTa6G5NeDcvNzer2NZbfpO3bWYJUU77C1+FwBlElVnsEfbtgrg77Fb1T5IvbiRxwom+vzUrU8rXZbwZH3/WMus5BhJd4fw+z09UrY1H1Q8a0NFs9jxonc7HTiG9mjTX4vHD86SEZdIdpocLibiskPSuj68a9HxylHpA5ywrIY0S39gdbIcPR6B4LdFu9wC0oEGJCRhbMjJaYZOUOMregSaKyIgm4bHzObrvTWe5IcQluRix1pWXmpwz4aAG3U0B0bogOL8ldxk9s8p7ORdlF18EBagfReXFuWvPfUG/CSrGtj8J7+E4o7wRE+hR84DnCVMs7+pNHVpl5MREjUj9a1ZbDBdm/KH2GOhl76kvomZULGRvNy13sYEskX+S38qwDsjtv0ojT0aIPnG/a0A10Ve9bqvsKEwFDVY+T6A00zrfeOxhGhRcY0MvkWxcqfz2pICEIJZl3lGgSTz7Ywwzk6zsKHy5yiKlUVeYY5vxdXLYOx6CjlEKXs4ZcxG/1RM80gcfPvXGP9rsy8eiQczvn3I/nLWNMv+RBw0VgxfpLu5Xp+QjqbIehQhBTzronIX3oHoTGfGrWm3RqLaxwR05vwm5LsOZUn1bscnnRsRBh5tQAi/Q0JlZEmS89NxYzg74yvq6PEtd/k0/KD42Uo9CBmr1CO1cYInl5uPG9pQgvY+RANFAHHvSrmi8ie4JyCIKZT7RA53m69uA4utXK/N7Rifh6BB2rW6vUb7VDRRRKhH1o4x0xFF3kR7xTr8UUZOEPcRgphiM4LNFcO1H4PD7Bjua2bZ9/0Iou OYdpq12p wnkBo4T6U2HFqyAZz+7WdbPpbOG44VQc+eNd3bPZ8IuyFK5ypa8ZIeeKA6tM64JuRNqFgbJWGbV9iQrYYUCbb6JEdyCZGv2QLGkABxbwFnS+llUYfa/d1ZlLXL9Cdy4g56OgvVSwptj0egJREUnokwJf9SBx84bTkj9T4gQtmIpGTnlyW9Np4/d5UupGfFjv2Mmv09R11cx4tLAzSn547qen9zi1oyxxR0BJMLWdRyKdPut6k9WLQtYl0Ed80Gn2NIE0OPT4UkdTx916RaOwPoTL8GjeE2P8u+VvLwvJ+SmMaWFSX7aIaF1aPMKo9oyMbb5DLey/9/Z0EXTUvmC+1J/hj3WRmAV7UYv19 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Jun 2024 09:00:31 +0300 Mike Rapoport wrote: > > + /* Make sure the name is not already used (size is only updated if found) */ > > + if (reserve_mem_find_by_name(name, &start, &size)) > > + return -EBUSY; > > I'd prefer another variable here rather than size. Will be more robust IMO. It's a damn habit of mine to be frugal on the stack variables. I'll update in v6. -- Steve