From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888F9C27C75 for ; Thu, 13 Jun 2024 08:47:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B6716B00B0; Thu, 13 Jun 2024 04:47:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13F686B00B1; Thu, 13 Jun 2024 04:47:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F22A36B00B2; Thu, 13 Jun 2024 04:47:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D29F96B00B0 for ; Thu, 13 Jun 2024 04:47:31 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9EC30A18DC for ; Thu, 13 Jun 2024 08:47:31 +0000 (UTC) X-FDA: 82225236702.02.58A59D8 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf21.hostedemail.com (Postfix) with ESMTP id E12741C001E for ; Thu, 13 Jun 2024 08:47:29 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718268449; a=rsa-sha256; cv=none; b=DIrawytF3SkVmrkmdfXrTQwK04k94nBCNNh0X0aICYhhBpZRsZEcO8YKx7djBbWhRya8Q2 dOoVfPvQtsb5kycFTvYRqvZxnR3aJ7EZymOWS6yV6Hw1rRRC1CzEVNbYkuJIByu9ppdRIV JFRRQ3y4HvH2c4vTp0GOdREz3yzZP7Q= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf21.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718268449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sb7qCGpsRvDVcL0lT7LWEy/O5ghwWni7YwpIn3Z6Uvg=; b=S/TzjkfAlqhafTvdRZh02gsRap7Rf1cazggkB5Noawy6w7eGe2P5DGDuaq14WQDTlW8lyP npHIM/6XuO8utj5b01OvdageMm6t/P3DlCwFnmjlLWkM4ikctUQaoVPvObGjbpXerupXOO rb6KDkQ7ziSI8VG7GqO9bBp7kgkrCm4= Received: by verein.lst.de (Postfix, from userid 2407) id 6F2D968AFE; Thu, 13 Jun 2024 10:47:26 +0200 (CEST) Date: Thu, 13 Jun 2024 10:47:25 +0200 From: Christoph Hellwig To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 11/11] xfs: enable block size larger than page size support Message-ID: <20240613084725.GC23371@lst.de> References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-12-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607145902.1137853-12-kernel@pankajraghav.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: E12741C001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4s3jjtg9typ43gnimkusbgy7uepo79k4 X-HE-Tag: 1718268449-452272 X-HE-Meta: U2FsdGVkX19qgpR9YP7obLzN9orexz3SAJpKpoJjwgOYcXuMzRhbvI/KDG7wuVWYr8g0IcQlziw5JwgYD/jB6D266cN/gotrlKtcw5Dsb2Zq0SPVM5W9Ph6thAZyIUWRGnQs+0WhYOPQAQPW6ie94qkZjT144AyO47GC4upHiP/p1m2qsVeOMvsulcGPatvrqI0vOE3YjSAvoLrE9wrG8IZVH9T0oitX1eK8GBrmZ9t+6FGyo0uTgvgSkLTbzvlzq2h6ssMzuKK5OvXJUcIs10e81JIGOdz9LRagd7gZL7OVc3UUVyzAZp6W9qAMrvpYLZWqQV5+/z0QDNWfY0eJEMynXGT7aSfRpiHFKLPvrkcMOcjPnM4yUM5oUMs0+kJlRIr2+Xc7AN12z8fHuuBOUJ9OuNIcYHbOMm64Bp03vxSElxAawuhlvu/hMtDThYmkbAQunrdIa2J55falR3K+i7+w4qhzSamB1X8Wp2e25F7REKrMvr/l1y1BNfOPPl0QidyIZctTN1oVG4FUghF1HRLmxK9SKCJDlLfz0oX9HmPxFXqUWZQq65cyFudIUN91Lt1b23JKsq7Z2SsaD6ClHnL9VbYYX1MMyj0YpZyT5FRUlNM0SuxhrCegeCaxXVqPRx/CgXdleqlsbimv5Xj8CEvBnsjLPA8ABiTcVS4D6JsD56Ez9qGpXeOEDmoufoZJdTR/fVpkfrCfP7vAIypx9KEsqKA9+hq9qfRD3cIVaNft9THVV+XSvo3kqbTpwRMzKLvg5YPQLsWiAQfmp/RulYGeN/tDstxt5eaULlZuaO0PCCXI5pYH51x87SgntKNPGamcIJ9yBzs9YZhY9HvZBxuaD+MEH546g14t2MIK1J76jGITXy8/S56uV1CumTy8wwwJj+6WABxHxTTujwLAY9WBkFQ46ZLVzANe2cni6Nbv3ZJomCYXX/HksDSwZghBxRwPovafHyyFMnwvWvY nN4UUFS4 9IakR1pMCPHrF9iqhLhBX/CLccdhyk2FteQdSw2Fu1Z3HABRYCtagXBM3dZjw5MvPfMk/GUVfIqgxUHc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 02:59:02PM +0000, Pankaj Raghav (Samsung) wrote: > --- a/fs/xfs/libxfs/xfs_ialloc.c > +++ b/fs/xfs/libxfs/xfs_ialloc.c > @@ -3019,6 +3019,11 @@ xfs_ialloc_setup_geometry( > igeo->ialloc_align = mp->m_dalign; > else > igeo->ialloc_align = 0; > + > + if (mp->m_sb.sb_blocksize > PAGE_SIZE) > + igeo->min_folio_order = mp->m_sb.sb_blocklog - PAGE_SHIFT; > + else > + igeo->min_folio_order = 0; > } The minimum folio order isn't really part of the inode (allocation) geometry, is it?