From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D8EC27C4F for ; Thu, 13 Jun 2024 08:45:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97C846B00AA; Thu, 13 Jun 2024 04:45:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 904CD6B00AB; Thu, 13 Jun 2024 04:45:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A6476B00AC; Thu, 13 Jun 2024 04:45:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5B3636B00AA for ; Thu, 13 Jun 2024 04:45:52 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 04174419BC for ; Thu, 13 Jun 2024 08:45:51 +0000 (UTC) X-FDA: 82225232544.06.4DB652D Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf03.hostedemail.com (Postfix) with ESMTP id 5067820011 for ; Thu, 13 Jun 2024 08:45:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718268349; a=rsa-sha256; cv=none; b=urg8P9GWkU/SPv3nIYhtuu1dtO0+tdsopkqGTHdcXInO3jDFsoQZpTriz2Dr0IVt53nU7F V0Lg/WWjATN7YadjmQzU7f9ORUO/emPMAXfJP8FZjAXbZTDzb0aJ9UuvU2c2j3aDxC2Db2 O1Nh+aDHQY7fTaFGpSNDJSOpf1cBCK8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718268349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WatYazhebbGpDvVUTPW79qvRKhIIqIGgORRZr4O4Vks=; b=EeNhhnYdVGKHtilM33pw9BwUkceksXDe+uFQ1Gvbj21zNpbDULxDnbqsFDof1XCdMTzg1m t33SNqqNPyTLsM6MBbxzW3nWbBmCD7mR1mLPf2nOEMfzOiw5F0jcyJ6+QXxiYYCIk7dgGA XM2XPhXf283Qs5i3PirjbcA35CmHyXQ= Received: by verein.lst.de (Postfix, from userid 2407) id 9417068BEB; Thu, 13 Jun 2024 10:45:46 +0200 (CEST) Date: Thu, 13 Jun 2024 10:45:45 +0200 From: Christoph Hellwig To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 10/11] xfs: make the calculation generic in xfs_sb_validate_fsb_count() Message-ID: <20240613084545.GB23371@lst.de> References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-11-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607145902.1137853-11-kernel@pankajraghav.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: s7erqw7uhxux9e71brkytetgp87r81t4 X-Rspamd-Queue-Id: 5067820011 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1718268350-992324 X-HE-Meta: U2FsdGVkX1/aFXZ/tQMUw0tSBnGnJfHI82Bq2HDE69+sI60WY4BvU6EVr9CYxUaP75BG51bJaEursNGm0X7t3Giesyg2UP+gIivWod0puBvgQjuVj+6hhDywSnzop0uxp0VjGw3T+luS69gYy6Mn3+xX6plnO2WF2TCaLYLJOTlpnW2V5jxoIVpsx3GpRFbx7hL2uRCko5gO5QZM3DxGEW8bqSF4TSJ2iYTyQJt0+2Ymkb5Nsgq+NYkK+uIr5mWRA/wfDCb44cB/5bxs4Xx0AIkXxkL66jV7foFssPT1C7phXBqqTSQcZ/nDhFKFO1TGaJjlCfn1gHbEL+Cu7Z4cLjvIOn2w3JurE0HvNf96hwWHsDKkanbTIHejzKwdCowT70TONCEAwkygjj7dQ5PIbhQOWzj78F77kNJTeiSQcpus0ZuoGjMmq4kNYWN59qbiFfR7b+7NneXTliNwzKwsapRutttr0mH43RVxR4Y9H6qNBHzBMM5Po9/gHNj29JSM7SkxQhm0eaHPjZu8IpvhBG9xQPnUUVyoVR1KYyYBNEm3kTXdBlb5U/p4KfL/UxX/ZbgNpkEKqwDqWoUslrwqNb4SSSIQhQZJrFaQ9b1bbo+NI/OFiCtvYH+Ppi3glOgnp2E+T6vE/IotLGZwDWUglE06xoCdGm9ciDD9jy76NqsnH0/VgPa8rl6l1E9PhMYz7JU5LgE300CVArTqGh7TEj+sxYvb1EFJlTkuNd+H3yncPHcOV+piY4xZAyB0qOsiI0q2TsmAqU1vaVsy1O2i9Y9LpbbYg0Jsg/P9aYxwhsnoAWAv+u6LBmThqWs0GdG+q//ynXf/JUqtxgTMJAkWsKEuDp1SNUyYXzo7KyT+eugMW6jFHrnXB1nRY3sI+hb0LGjzStLxT0kvIy6cg1NNZFYbOm134le6UNQFhfqSZQUiu0RHwLHL0fwfNUIj0SrrHtajmt1VikKEDkuJzZO 2xzDRpi3 tC6LiNCRja8w2VgtndzMl1FVODrYbOfixVO0ctTmx1fibs88pley4YE+rhAnzOURuQwOIk3FBQA1jK1NJTZh5vG4oVkwBFOFTJa2rDhkSuECAemDbpEhI1e+4eQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > + uint64_t max_index; > + uint64_t max_bytes; > + > ASSERT(PAGE_SHIFT >= sbp->sb_blocklog); > ASSERT(sbp->sb_blocklog >= BBSHIFT); > > + if (check_shl_overflow(nblocks, sbp->sb_blocklog, &max_bytes)) > + return -EFBIG; > + > /* Limited by ULONG_MAX of page cache index */ > - if (nblocks >> (PAGE_SHIFT - sbp->sb_blocklog) > ULONG_MAX) > + max_index = max_bytes >> PAGE_SHIFT; > + > + if (max_index > ULONG_MAX) Do we really need the max_index variable for a single user here? Or do you plan to add more uses of it later (can't really think of one though)?