From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48D26C27C4F for ; Thu, 13 Jun 2024 08:44:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD5E96B00AB; Thu, 13 Jun 2024 04:44:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5E896B00AC; Thu, 13 Jun 2024 04:44:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFF966B00AD; Thu, 13 Jun 2024 04:44:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 901A56B00AB for ; Thu, 13 Jun 2024 04:44:18 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0DEF11C101B for ; Thu, 13 Jun 2024 08:44:18 +0000 (UTC) X-FDA: 82225228596.14.D15C1DC Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf12.hostedemail.com (Postfix) with ESMTP id 18A6F40010 for ; Thu, 13 Jun 2024 08:44:15 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718268255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VG6S6d11Hfd+8uXal5CftDZb8rQX5abFyRmFczJhnYs=; b=WNAG7DNKfQfLmHChWzTjZXoQkJSJyFwe5ZuHYLTmnYQ7huMcnWUjg9lsNP6SDQeT8tULXC EIU0t7V3F7apBXogcNlHrJ9bJdYoRyuGeDTT2GbTpqcJvEbLv2yfemIq2fbiFwoNfD/xOE 0m8Te6b4HgXnr0kS2+tKcEqTCVsLriw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718268255; a=rsa-sha256; cv=none; b=6mKqKJ4C+x4d9FxEpPVKoCi7t+j6uTVohpgZM4bn3Rfg1Y3bNhf8QesB+hM/u+JXlMRA/w r9wJkskZfNOiuDnQ8cQYovZF3mTk5irEplZ5uoqp4gYH5EL50Qi0Ur3zcQMJUULIyePVj9 zeyqc9SdhTRvb4cKVtJqbu82lVSin/M= Received: by verein.lst.de (Postfix, from userid 2407) id B74A468AFE; Thu, 13 Jun 2024 10:44:10 +0200 (CEST) Date: Thu, 13 Jun 2024 10:44:10 +0200 From: Christoph Hellwig To: "Pankaj Raghav (Samsung)" Cc: david@fromorbit.com, djwong@kernel.org, chandan.babu@oracle.com, brauner@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, linux-mm@kvack.org, hare@suse.de, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, Zi Yan , linux-xfs@vger.kernel.org, p.raghav@samsung.com, linux-fsdevel@vger.kernel.org, hch@lst.de, gost.dev@samsung.com, cl@os.amperecomputing.com, john.g.garry@oracle.com Subject: Re: [PATCH v7 03/11] filemap: allocate mapping_min_order folios in the page cache Message-ID: <20240613084409.GA23371@lst.de> References: <20240607145902.1137853-1-kernel@pankajraghav.com> <20240607145902.1137853-4-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607145902.1137853-4-kernel@pankajraghav.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 18A6F40010 X-Stat-Signature: c14cgpp59webgux8ck4a963mbrtgkwbz X-Rspam-User: X-HE-Tag: 1718268255-958872 X-HE-Meta: U2FsdGVkX1/7cFA2IBARgmJpB8sxZpZZmRwffx+f/7z/5b+DDt1+jwicIDxluFObMMNbzyYam8cWBMMYW38tK0McXYuBxTkFqynFzna99g5QxkMol7h/MYaWnKypFxkU4irg64/eCFH+Auv0g92gGYV4rCCZqI/7bqGGjVIw7Q48CsZDMOj4g2h927tMPKs/O0ObMlxUMvgzyZImV5y5ZcWNViLIJ9ys6tqmzmjZnUO822SSMUPtzCa5WksKeU9s3QEOebteXeEFtzMmNm1nDY40NfsRqv/rOhzIWIgUV0yf5YF3dRtRgInoPiTX9tsTSa5MLV2HUowjZVQiek/xnY35ttT1zfmFsmFC1S7Sxi1fMU2vxo6HUjZub5QjKEhuSbyczDB8zq6Wj7EqdzryTKaTKug99K9i3EBM/impz1XJlAYgLuHBm8rHxzLBFDg5QcgbyHFNizatifd4ujD5xK+WqsPJl13yVFhQiB2Xls7SqNGv1H39uQIPQHDfziCzmcTMOwM6P/hS1Gyv0DKg7M80ninIXjiqw5lSQPSW4Ecqt/mHr3tLjdRdqorDoXq6YFWJQrJE/YgWbMVpnukv9manOtM7bjBDgmGe1yJFjXmAIjVXgVOvoPGzUBLv+vGvger3Nb6yXLK7yz5PtMgAcbEA2UHnOW/19Bbssrzu1Z+65FFKELxAJYujHlG8oMuQyocNN+Irb4lSlsPPDRAGuxlYL8TDWSCj7Fd5MaHMnlzlr1PkfinTZ+t592cHf6gq1MERaPscmkz5Cocd+4RbC/pRZcDczZeKywt6hEC2xLXz62JWVt3lTNzNqERelajYTSMW4IvsYBwQlRpgW3Nd5hQhI7ydp109YBta2yjgouZ7S3EjGkNo4Hum2wqjt/lDPihejy9eM8Prf979OEJG5ppS+qA85OBkzs4Uk1s7dYOi4BO24D+ZJtvwHiWNaRyJXomwwhhYGHMOCHVPPNv uDWLUqWf yVkwmSyzdF6OipZ3USwH3HSdX9uoiWy9Ikfwefp3+nnVGqgac5XZQU+xC+HHhtnVe16W+sbp58gKmy1BQ9IDR50ryVEzKAWH7yGS4GyzWi5v0iJ6rXg8lXHeVkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 07, 2024 at 02:58:54PM +0000, Pankaj Raghav (Samsung) wrote: > +static inline unsigned long mapping_min_folio_nrpages(struct address_space *mapping) > +{ > + return 1UL << mapping_min_folio_order(mapping); > +} Overly long line here, just line break after the return type. Then again it only has a single user just below and no documentation so maybe just fold it into the caller? > no_page: > if (!folio && (fgp_flags & FGP_CREAT)) { > - unsigned order = FGF_GET_ORDER(fgp_flags); > + unsigned int min_order = mapping_min_folio_order(mapping); > + unsigned int order = max(min_order, FGF_GET_ORDER(fgp_flags)); > int err; > + index = mapping_align_start_index(mapping, index); I wonder if at some point splitting this block that actually allocates a new folio into a separate helper would be nice. It just keep growing in size and complexity. > - folio = filemap_alloc_folio(mapping_gfp_mask(mapping), 0); > + folio = filemap_alloc_folio(mapping_gfp_mask(mapping), > + min_order); Nit: no need to split this into multiple lines. > if (!folio) > return -ENOMEM; > > @@ -2471,6 +2478,8 @@ static int filemap_create_folio(struct file *file, > * well to keep locking rules simple. > */ > filemap_invalidate_lock_shared(mapping); > + /* index in PAGE units but aligned to min_order number of pages. */ in PAGE_SIZE units? Maybe also make this a complete sentence?