From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A4DDC27C53 for ; Wed, 12 Jun 2024 08:10:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE2346B019A; Wed, 12 Jun 2024 04:10:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D92626B019B; Wed, 12 Jun 2024 04:10:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6F306B019C; Wed, 12 Jun 2024 04:10:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 99EC86B019A for ; Wed, 12 Jun 2024 04:10:01 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 415DB813CC for ; Wed, 12 Jun 2024 08:10:01 +0000 (UTC) X-FDA: 82221513402.21.8E72D41 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf01.hostedemail.com (Postfix) with ESMTP id 01C1240010 for ; Wed, 12 Jun 2024 08:09:58 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=RzkkBTBA; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf01.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718179799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=74ARrTB2uqbX3nHwYJDMtYSDp0spRGdqOYKv8TI/qKg=; b=Db1snwlCQzoVTmAS+dhs55Ut7/rC4rQ/dT3vUKdS2vC6SpJnjcbD7y4QNR3776R8l7TC78 tDWI2ZUzNrjAwE4SOfC46yma+6xm84V36BwVmtOrYsyJijudPkqLS1OyTyYfXTDDhpeZIw 5YmZ98vWPwonfJ95P+i2hC66k47h/Jw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=RzkkBTBA; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf01.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718179799; a=rsa-sha256; cv=none; b=Muml1rvA/apReurk07zolTLWSiH+TiP6v4cEzTzgyfqNzJG94OCZk9O4SYinY+EuZo3yti 1WFdlIX0kObejQoxsk94SIaJO20HKOPqOf1rKDkyd5uFFWnT855dQknicnBfsULTG9KLLj CK44hoeByUdJ30UKLDs6TNASum3SLLI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 44A46CE1DD1; Wed, 12 Jun 2024 08:09:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E1B6C3277B; Wed, 12 Jun 2024 08:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718179794; bh=LH2QVR8RIElSNdKCwQD7JEh8pcjMKW0aQHLDo1mJV/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RzkkBTBA235rwtWwycIQj2KqVbizGP8wNzoEnhUb4cLSNRP9uK7hGXKcoL0q4iykq t9N0SiPmsqQsiLntlpTpWYkxZQU3y8l3mrAjBndh7BKHKocqhTEJ/OfeDFP15pqTQ/ bvSdTeTNmYUQIldzhRBCA7igwF4H6CcWlAaqxHTw= Date: Wed, 12 Jun 2024 10:09:51 +0200 From: Greg Kroah-Hartman To: Martin Oliveira Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe , Leon Romanovsky , Tejun Heo , Andrew Morton , Logan Gunthorpe , Mike Marciniszyn , Shiraz Saleem , Michael Guralnik , Artemy Kovalyov Subject: Re: [PATCH v2 1/4] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: <2024061242-puzzling-implicit-e64e@gregkh> References: <20240611182732.360317-1-martin.oliveira@eideticom.com> <20240611182732.360317-2-martin.oliveira@eideticom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611182732.360317-2-martin.oliveira@eideticom.com> X-Rspamd-Queue-Id: 01C1240010 X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: pwhymbzkntbuoi8pzwq38cfro8bmxxgg X-HE-Tag: 1718179798-543266 X-HE-Meta: U2FsdGVkX1+fGFrVoBnQ8AkMswsgZgpLW0AfErrNB0eLuia+j0MS8s87f4q2btka6lnkK/FkwIP/erLC4exkw75Ax+3MzUlcjYvEygsMDL3gKq6e3uJDyWrN5vO6R7nQRjr2VwFYchYdjSOkOP+leTmdksflxL+Oau5JjOXyH1wEIsS2kwS57exR3wcTMRC/HHucseSgA2Z6NUPBHgr8VHj2SlWsCKf12rI08MwjoE9HlVNZ4qExM7CYXJPNRS4pFgNJk8KZqgLXUFPLXjCk8EH6j6Yo8qsMY1zLat7h0kcMNiwAiMpxx78MHZVD16ikXaamA1WSh7MWS6b/5Vq3Rbu5ze5gKYf0cz3efj+6X8MJvLZ3DLgQRv6hhoEEqY9kKcm4kFvE1E2lGkUyUn0HdqoD/kvZE0EDsieHjY4xNRVZABQxXncnP++TGp5Q+6y3hS4QCU0HMO0HHAG7WY6r2fGkHyQJwRztuyJUgTQisQ4Pwr6YwyzkAfbRVfadeNKa5OXhzKGCTG/Mmq6hXxYTtg5lNxmWrHjPS8AFcdaw81DonlYezANBra5VJTMenyexx0jR0QCIjiHee23xXVGpF8SGowKmZfOBATywpHwYSzEwNc/wPwOeY3zVVGoOHNtHvEOW0iNonNUMqwxn7jbzlImCwqBI2eR/UHHJPZIkCpMMti6siZhpPx4KuU59CWl0h2q1C3e7tYdp2XnJwlTYH7dpYL8vyU+mB1b5jygb8pjVF07EpOReTMCA6vQgX+SL9lbtLGSItmxHMME50JPbzZGgpuYULhivJyPb/9djpbud5U+6fCXv5SjLp/kK0q6ynkaVfQXXF45pIKiG3lvpwVrlufeWGMOI57SM03tTO1k54wR3tTfrRQDSI+OiykxHzmV83l2vWXDqHk+mCHPaqCtZ6zaBuZj+G8NjrNIRsCSKvPcJR7aiaAqyxcUMPYaE85F6adlcFhEqzN8Tb5A iy1IqjIN Hu29GHlB+b8SjxLuhMcS0YVLUoQQs2zuBpz8kkG5hmkAt4xtm3pd0c9HoykghfCXo1okX3cVL/LcJIyD+Z29f4xDOfuHJRrFQ+4cGn/BpFlSBdDZCIGN/vs1n9ZB+4omqiLXBcpkLL56LgLL35KeA5njFe8wAfXT85dz++0Yfr4P9//NSf0UwYW4OEUPEq2NNfuqmj/KOXlI/3glmZjp6evAAGGZYscfWgXPaDsxAUslcpBkEyiGWU7D9cCycmsZGe9O+yQo1TLQTaNrSg+ETfTi3t4dkjWZc36wOmTsCXhU+NZOngCG+RINqMx3kfiBzuh9s2TuSVWQuffWFWCfiYjVWkAdNPRwVrHAYRqnAi0bIabI++fIta/ykwoU8JNnwzM4rSd/RpyxLIiBxMVlxaiAssHlo74PgXKdmz0J/1kgiuHYLgTsNEcdqLRaaRfwTg6o8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 12:27:29PM -0600, Martin Oliveira wrote: > The .page_mkwrite operator of kernfs just calls file_update_time(). > This is the same behaviour that the fault code does if .page_mkwrite is > not set. > > Furthermore, having the page_mkwrite() operator causes > writable_file_mapping_allowed() to fail due to > vma_needs_dirty_tracking() on the gup flow, which is a pre-requisite for > enabling P2PDMA over RDMA. > > There are no users of .page_mkwrite and no known valid use cases, so > just remove the .page_mkwrite from kernfs_ops and return -EINVAL if an > mmap() implementation sets .page_mkwrite. > > Co-developed-by: Logan Gunthorpe > Signed-off-by: Logan Gunthorpe > Signed-off-by: Martin Oliveira > --- > fs/kernfs/file.c | 26 +++----------------------- > 1 file changed, 3 insertions(+), 23 deletions(-) Acked-by: Greg Kroah-Hartman