From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC4B0C27C53 for ; Wed, 12 Jun 2024 19:30:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 281D76B009C; Wed, 12 Jun 2024 15:30:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2305C6B00A0; Wed, 12 Jun 2024 15:30:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D1E16B00A3; Wed, 12 Jun 2024 15:30:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E17C16B009C for ; Wed, 12 Jun 2024 15:30:14 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 832C4815F6 for ; Wed, 12 Jun 2024 19:30:14 +0000 (UTC) X-FDA: 82223227548.26.9659E7A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf22.hostedemail.com (Postfix) with ESMTP id C7A21C0021 for ; Wed, 12 Jun 2024 19:30:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PyY9f9Kj; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718220611; a=rsa-sha256; cv=none; b=EorgDhDa1RPEngdNy1dzuXkh4hUr9UPc/sDGUe94nW7Zv35AQvAYssmhEbAXXAdlJOp/2O o/067tB6k7PJKhN1FmV5q95Y8Nnb+Beuq8seTEkO52cn2h+XnLMGYoHPS5dubLRoOHiRSq iWCWfj8kNCsh1xSf7dKSHpvski+rf7Q= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PyY9f9Kj; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718220611; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k4UhdzN1nc4lwoX3qSGSqJFJ50RxN1mypyNt2n66GNQ=; b=ULma1R6mXtvPSiO4W88SdGlyb7SgsP9UrbNFl7UKOQC2f/NK/NSFAr7eYgn9yCqlkLia+J 1R1oosaor6ew0eVBex/RU4/gHndP+WUeds0E02a0M/1ilQ6vUZpTPCXwjB3jtuPo9tj4lw jJ7i7PJSC8CvBqoiK9j2QmQju5tbzcU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7B1CDCE1917; Wed, 12 Jun 2024 19:30:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 800E7C116B1; Wed, 12 Jun 2024 19:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718220606; bh=G7xaNCNg6qnygPHz7z+qFHlj+ktFcgmMk2t93MGQomA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PyY9f9KjXDi7DeicYHnRbGuAK4ICleU3PyOFxlJls8GNKvdWSgjW92Dj/DuO9OWAT xn32zCrZiqAmXEZ6yoa1ZGlWlzQu2MbvMdu2Aczx7/yEcAGSC9WRycRfcGpFWn4JR0 Yrwisb9WcdGY/Whsxk+S0WIOf3s2yknrVl9tp6+A= Date: Wed, 12 Jun 2024 12:30:05 -0700 From: Andrew Morton To: Peter Xu Cc: syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, pasha.tatashin@soleen.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] WARNING in __page_table_check_ptes_set (2) Message-Id: <20240612123005.d5872e92a8f60e8dd459cdee@linux-foundation.org> In-Reply-To: References: <000000000000b7b11a061ab49122@google.com> <20240612104735.ee6405d2096236bf18c51a41@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: amoi9gnukgk457inxop6aot1gzf6jmxi X-Rspamd-Queue-Id: C7A21C0021 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1718220610-932785 X-HE-Meta: U2FsdGVkX18dK6/Iv4mRR+f1pWO8riR+5ItZclZo+vVz9LRVGaeFYDuiehKiqmVuCyxfD1GJXssun0rNbHrSdvzhSSan7sbQBlKuR8voRY257XnGNrgOblZM/UzdRMzYhmLSkcljTUrx6HX6I0HQMITkd2A3BZ8KHw4RhF5cc9o2U/Hm3YEgAxJLkb1hPptayJbmT2eFdifE/TyzKUBEu8XBBnzNB6ovU84sCUWtgV5y4ZvZyY8GZvQvgvpyPaE2+pPOp9PfZ7xAf31yVZExyzJUN/lXioquzUuc2Lr35R1yqlhtmJyZnkYQRzB+O+eHLb/JglnDpK9B9cYFNm/fsmhRjhfNqaUyoZOskPzKnDpLGw0SwOP9HGtnq7bHrzZgZksypibV9Rf8TxC6LE8+54PSwH9+iJZCoWPpq6dsIJhj0LMITMXP08SLQD1cPVYBvSJ0/sLePZwJQufotE5VCJoGhHhPAy1V3Yw5jtSBoLpSRELKlTg7TKQPHLjSCOdy51twOXJgVmbODTpnu7zc+D9TYz0qbQmv3snembvqoo3FkDGUu5v13a8JQ6sdlF5dnkEP656r2mb5szZ2nwLYDOWUbq4ODkKZ2rIV2N1HPGHRp6YJy8LVw1007DdfFwJaj6N9tP5l6QUYdoMk/wM1BjvYnzzBbyATs2QWdXXqEiv/Lro7hL722kBZmowtWD6DdmdL0c/HYAxMxg5i0YOY//PqEO2IW6CHWSnji/Gtq+LMy5lGdehdQY5xg+2iF2Hcr5nAyuVtUNPxxrc+8E2bMk2GjTwn7VL6WoTVhz6RE/nMo0Ssu7khP5RCSOzBRomESqUCj+Rq4EqpsokVTpsxzlz/DWUDq74etwTlIFOKF0AtAM8C9+JhzB5ex7w6kPDqn33n80AGKjZ+MIQd+SQF89T+CS5wlcKBC0GD1NZcC8N+xwksiM7O22CzxNu7SSQVmQ6btBjUnzuO1vMo548 RA4zi47j L8fm8/TnIYmgTa1Kigo8+MOccx0eybGrDzCpa2V3mN9iwAFsaG7E+BzFDA0LFnCBuwF+QIJNSr9d5ivYEZuzKTiDYArFu49CKOEAN/A66ZoG12KCO3YQtd5w9lRqPlbYQvQqDpo/176mmKfA1qoYHKJ6yRladhct65X0ydjslBhZCiOC35eE3aQF5ex+8GziR267XbVrpoDDKbG+4M4FHX4v4W+4pqi2Suuqbz27o2NnUbOazkq11NeWTdcj1A3l3MNG8MnTibREJ7hnExg08Ih6qINW7Vc0mkHecEYMZzIM0sAUmYQYaIQ5hzaakk4nL4ZUl7hRf2VrhDh8BHAF05ucftM0TNjwYW3JksowtkmOI+En/zz26+0W6L3ZpftYYosNvHvuNN4323Pd/cM7WCH7eXKfk+qktjODEr89/vusfDYKyulXG9yDYGPqgiwrZZX21HYR5de8fLF3n8SjuZ+Qw0EO4mvlM9PqNVuqsKFkeKED54H/WDJvTom2rZ7cbZukJXLeoN1e3jeKFI1ILdUhj0/IT2tfWbILk5/YfzgGFAsYkBMwq6i3jdomVUbfYahLuTbgHf6yVDqTRPrGojkM0Px7JOC4PdGyvhO1G6RILpiv3ZoWTCbnd7X0Z0n7OhibkAy6Sw33n5wXMDEC0Apn1Pi/bovK6NU4HkqigEyJIbknjzFrZ9zYZTqcyluHZNc57Bt4FqqB0Wfta09YM4ozFcl42/LEafxmQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 12 Jun 2024 14:17:26 -0400 Peter Xu wrote: > Hi, Andrew, > > On Wed, Jun 12, 2024 at 10:47:35AM -0700, Andrew Morton wrote: > > On Wed, 12 Jun 2024 10:18:21 -0700 syzbot wrote: > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit: 8867bbd4a056 mm: arm64: Fix the out-of-bounds issue in con.. > > > git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci > > > console output: https://syzkaller.appspot.com/x/log.txt?x=146b3d96980000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=3b4350cf56c61c80 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=0b56d6ed0d0c0c9a79dc > > > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > > > userspace arch: arm64 > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > ... > > > > > > ------------[ cut here ]------------ > > > WARNING: CPU: 1 PID: 1 at mm/page_table_check.c:198 page_table_check_pte_flags mm/page_table_check.c:198 [inline] > > > WARNING: CPU: 1 PID: 1 at mm/page_table_check.c:198 __page_table_check_ptes_set+0x324/0x398 mm/page_table_check.c:211 > > > > if (pte_present(pte) && pte_uffd_wp(pte)) > > WARN_ON_ONCE(pte_write(pte)); > > > > Let me optimistically cc Peter ;) > > Looks like this is the same issue that the other patch wanted to fix: > > [PATCH] mm/debug_vm_pgtable: Drop RANDOM_ORVALUE trick > https://lore.kernel.org/r/20240523132139.289719-1-peterx@redhat.com > > I had a look, and indeed that patch hasn't reached arm64/for-kernelci > branch. Thanks. I currently have that patch queued for 6.11-rc1. I'm thinking it should have Fixes: 8430557fc5846 ("mm/page_table_check: support userfault wr-protect entries") and that it should be moved to hotfixes for 6.10-rcX, yes?