From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05183C27C53 for ; Wed, 12 Jun 2024 18:46:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F9866B009A; Wed, 12 Jun 2024 14:46:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 482296B009B; Wed, 12 Jun 2024 14:46:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 322576B009C; Wed, 12 Jun 2024 14:46:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 12C636B009A for ; Wed, 12 Jun 2024 14:46:05 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BCFE2C10D3 for ; Wed, 12 Jun 2024 18:46:04 +0000 (UTC) X-FDA: 82223116248.11.A6D2333 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id B5D2118000C for ; Wed, 12 Jun 2024 18:46:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HbFj2lOK; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718217963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pknXtOKKO2oO8ItC47PqXes4W0sPmD2JIivUbQ5QqH0=; b=efEPQUg55d8mz4YTCYa9f/uxfpPNbLS8lb8KL0HEev5ntUob13OGQDfLIlIYUWGHHcxbJa UAcJi8VicZBwtP3Sg1RsNMlTnwMG5ncgkZDSBJmRMCopjDE9ahpOPB41va6GVUBVPxq3cg gXUH2+RiY9eGZ5wxtXbmjd6Bz7IXfzw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HbFj2lOK; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718217963; a=rsa-sha256; cv=none; b=eUhnxaJQIsVkfemm4OOzDSSI7R/nQ8N2abVAZ5E823m8sJKFdevaWgtLRGld5ZLAcBOM2m eVuYvrXQyJ+a3yyPWTxCTFW/U3Nli55LiKButwr0j4qCL0v6Gct0Gdfo779AAaEGZGJeKF GKXVvQsDO797+aOf+TRcWIHs2Egcuo0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E037ECE10B4; Wed, 12 Jun 2024 18:45:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29118C32786; Wed, 12 Jun 2024 18:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718217958; bh=dXhvjwM/0oFIvt2EbGPoQJdmtCjDsX+7C5LbE2ZsBNc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HbFj2lOKKRLqmpNJyH1ELmss+TDEz4RJ1NB0NKtbvEQ2Q6/0z5WVXLtB/tOQOZ0KV EAy+4jYi1xAS63Q/3Nmc3D53yrduqGvkwkWy80rWFLxGYC/t3ubqBJD90Hw6ORZiAm tw+lzL1LOEn4fgoAEEB2R8Vb8Nu6CeOFEk1/4IECUnTQ1kPSF4v1GPdUyuW4gnaV8w h55x04pfatlIDpIiWLt2lDQPIYDhcA3YGu19NkxWsRwfKSuLPCjIGqMPtncmjSd6LE M0qxhxk+ERJ7Q6e3qi8IC4pbnahl/1I6ROoaU7q+pzDF+hzQWqOx0q76fNHfbPbuck 06aLuT5irhExQ== Date: Wed, 12 Jun 2024 11:45:57 -0700 From: Kees Cook To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon , Ard Biesheuvel , Mike Rapoport Subject: Re: [PATCH v3 2/2] pstore/ramoops: Add ramoops.mem_name= command line option Message-ID: <202406121145.8860502D7@keescook> References: <20240611144911.327227285@goodmis.org> <20240611144949.703297941@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611144949.703297941@goodmis.org> X-Rspamd-Queue-Id: B5D2118000C X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: xt4d1mzimxz16psgemr1xe9ufu7xy9hq X-HE-Tag: 1718217962-139589 X-HE-Meta: U2FsdGVkX19HvBlCbeYKgk6i5r5jd/5vqriBm7C1TPHI9PHKbkgenQzmbQl4nIF5YRJkYjxbBA/y8HXZL+5ohIfU27+w82h9Ihn0uKgixINsMu05cqou/yrv3FQ8mXxI1f30PTsiL6+OCxwZ+pMtQKywE0xguUDIMrKxG/f4cBlZqPSWCYx2DYU2Ox/mvQlJ/MYGr9xrsw7/8AjzVJsOCwd3vRbG5a1u0WJv72oIKbi0CUlDoQNub/DsCld2QGsQLV6afPmJEV2YybmOTmqe/YmzW6C+iEtxYLPpNpSeT1xToCdaEwjkg+XAWhMgCSb1szPtolWO4THkeVtsf2J04+gVuvOvMleJNykL3ZwgM3mwcizcm2ae2lgk0uBac9CvNHgaIt6xFgdRaqniTt94igNjUNYvezg7pg9XtEvUpRZULWA9c4tfhGmkoDjBjiTgB7gi6dS+UengUXFr/f6rAcofq8dZ3faBZhTzhS8JsFI7XY53l+m71OTXF+JC60FIYipGUZwiLdkb/eOPLQT9YGsH69KFgTf/0W5RohHFjbt3rJJGdzt16P8gz5WebzJ99ccJ+fvAQ4ZW8Eqs0bRm4/6E2DCgPsJi6mIk43YUt78lqK/oZC7gmJewlw6m7SoxpGwraUa4xweGFg5EsYu8hTKTemWi6yFa4XBF7g1/I5DYjwxXwihtoOhTrsn/tcPmNXZD1jaqtwTesuwGtq3AYgtNrz6jAX0SIF5zoNcKVJy2FbBRqGeb3CP0AQubuRVuBfDuibjglbn/Rz7k8DHy1egtAvwUifJ/GbL5W58jwhjofhwrI2KOdzd+TBbayPrphxacpEI0XXwoWLYpZz+DDhVXJ1730oVtCV4s4Vu+LenOP71s/nHGVVFXMcu1Hhizehbef1xa6OnT6xoZ76qJcmMcM52dvff0f+9RQniWPdvdjGPdxWedaA1AQMA9oVphECeQIzie/KundjEv+AM lWuGSH1+ cm9srrVyrvPeTU5pNmNBfxywsABO9gp7Q3Z51gB/hlw/bQJqjGnTr/DwXnkheo/4pvlmAVIpdluiDNEFT1PsjYLKosH+W27qnqIlv5NcFDxeUeYbi3Q+dJ+rgBgKHwuWPEoY2fcaqqrj6CSjMXArOPG0ydgD8q6klZqUTblkuHBMCJKKYonAFKNLYxk+YVQNuLRpjfFQ+9abwXgmB2lU2eGSSmtbWEXAMW+i/rlnKkDeUhIn39wIrvNdmPS3e67NNQStT0hb0O61ZD/fIgKm1X/GEYB9BIFMVG2yb6TNAqXKDfZ7GP8zgsDUT+6EdDWmjcmAbK2kKOQalO9GSipd0am3M+KpWeQsZag0u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 10:49:13AM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > Add a method to find a region specified by reserve_mem=nn:align:name for > ramoops. Adding a kernel command line parameter: > > reserve_mem=12M:4096:oops ramoops.mem_name=oops > > Will use the size and location defined by the memmap parameter where it > finds the memory and labels it "oops". The "oops" in the ramoops option > is used to search for it. > > This allows for arbitrary RAM to be used for ramoops if it is known that > the memory is not cleared on kernel crashes or soft reboots. > > Signed-off-by: Steven Rostedt (Google) Acked-by: Kees Cook Let me know if this should go via the pstore tree, if you'd rather carry it? -- Kees Cook