From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20EE4C27C53 for ; Wed, 12 Jun 2024 15:29:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E0CA6B009C; Wed, 12 Jun 2024 11:29:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 969E36B009D; Wed, 12 Jun 2024 11:29:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8319C6B009E; Wed, 12 Jun 2024 11:29:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 645B66B009C for ; Wed, 12 Jun 2024 11:29:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0BF4F14187A for ; Wed, 12 Jun 2024 15:29:01 +0000 (UTC) X-FDA: 82222619682.26.61DDCE8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 6C6D310001A for ; Wed, 12 Jun 2024 15:28:58 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=9b5n=NO=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=9b5n=NO=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718206138; a=rsa-sha256; cv=none; b=Ny0lW2pcIwmWanJvJY1hEyniUxwxt/89WZN2i82dp+3p2EmAMAZ6K6fWhlNaokxQmXQOlp x6HsZT5OIAGLJHTY1Yo50Ypd5gg5o9WmJ1aZZI4ZmpXnYBT2Os6iLpr39TL0VvyN2qJrqI geQZXLPh1sIugUCa+WjvHVIdmzedUEE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=9b5n=NO=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=9b5n=NO=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718206138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xvCpSlYeXJn8XcbehAUBlCctR5OajRR7DCr51yaClW4=; b=4Lz0N0pBa5bxxfElm3vCcl1cvMrHArmyk9Vf5akBs10iZuBwhdSlgOP4AFzrnEwJI8nqay 0RExYAaIvnce3hcFY1ymW9yUPv3o9A1r02OKaXqZmblHWgimRIkns66fRTBa+1HCS341dP gs4HfsFrrk6jMUmzla5pRWFBV/st9BE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 77E0E6123A; Wed, 12 Jun 2024 15:28:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26A4BC116B1; Wed, 12 Jun 2024 15:28:53 +0000 (UTC) Date: Wed, 12 Jun 2024 11:28:51 -0400 From: Steven Rostedt To: Wei Yang Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon , Ard Biesheuvel , Mike Rapoport Subject: Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up Message-ID: <20240612112851.17664dab@rorschach.local.home> In-Reply-To: <20240612073049.xof3ciae2x5qjp6a@master> References: <20240606150143.876469296@goodmis.org> <20240606150316.751642266@goodmis.org> <20240612073049.xof3ciae2x5qjp6a@master> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6C6D310001A X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: xkrjsnfddyge4fui3wd7e64my7mrq1un X-HE-Tag: 1718206138-579559 X-HE-Meta: U2FsdGVkX1901ROh5bDr46lYSgWH+f4tNT94b6B5X4lQt1uJ1pp/ZFb6CzIjGLb5KtRN9DV8lzwy8hZsAQARQj8Vq2FFYqwm6MOX6YTlJ9Qqb+bHVYB626meltQ1jBq8tuKaVqte458ds5NQRUJFwNx/qyYb3y/ImzA9MD49JWK1cio5yGb4GIpD6OwHR9Tmf//O2+zowlqJtc11kLYxfpUrXx2iNhwdjGuWnemWblXC7DC9SWKujUq92HPFVj/nbi9Satree2TRgInVM+yvGekxpNnC9K0H0APgfSBAADdQmfNzwN16CeMfPIi9nsiNSJuOjjnZB/uXdxncl99RLmddbKHu9nl7xQ/vkddDnA7IFPipjX7hIjdhC8IYCjN55ZGQFRL+OsU2ydSQpTKe1R/35oM8kvbSV5dCvCtiDRp8jBVIHOupV74UunH8d5TC0a4F06tXwlv7qXJRo+LfLzuOGZdh06Veg4u6m600+yWeCg0SSqmivY4bEI/qjUs7gkGlDjhPCxFGu8245K0egfXHnvNawP894cuFAUkzWSlxemUpmzSYNDIffW0FgW4t1Qonve4GUjvI69MgKaWGxJovclIE4s54tc4OJPP4RMAU1Y3a1LMZGQEWFr+2ey14Qo8mzev14Y5WWCpo0bu9DtxzQRLwJMbAEhA8c7xi2qnQEmnPeHrk2B6LgGlB+EpB+voHvXY2aCUXKo2usDBMfH8+oN6T/bbi3ro6OawZ857gdb12RvwA1qAa1cO7eAZS9XmrUDTiRG1KE+5AAgJt89kSCGnhr5dfgTJB0QyXdOZ33aN+gngHPsCPDPKEZ9A5op6w18nLCnto5/cLvwrA3v/44rgqLpYPEU2VWrz9GJBeXRd7yPT5bzFhs+dDeclypoTZrYdYJvpN50GhLwBgTUdFB1plqDULgCAeoQpgEcExDDIVp1apZubDuDON54iLadDqjDj3BLn1HRZJu3n NOJaKiWd vFlC4+0FaO15k68thKvLUppFZgGBujpRtFry2l/PVEPpzrqzAMCRhm5JAOa5cyI/TOaVXHeB0ZM99Lbtwt1Qb2M04aGIoPVLMlA1ZDR5UlG5nE2TYIULQzUu2HeIFYuogW18LtUB1sFjQjqKJSPoA8P85tNULqntEJZmpAsVh4kMVTctMQnG4syXq61LZjRLYyub4xpOztAO8Ml4m7McAMhB1QTYHcJIK9/Z01sv4G7bhv58nM1A+0jb5JrBFJMg2DfxIp8V9duA0z61z55SsyY4hYlgxDskcAEhTfS6X1ts/Ow3d3R9OfO7xYvlUU02BP1dPM+i/HFo0Wz4r9ZkjbskH4S7P60m7Fu32q5/8dJtX9A1DtQPCsAwraZ+IeYesnm362DnAMFNTB08= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 12 Jun 2024 07:30:49 +0000 Wei Yang wrote: > >+/* Add wildcard region with a lookup name */ > >+static int __init reserved_mem_add(unsigned long start, unsigned long size, > >+ const char *name) > >+{ > >+ struct reserve_mem_table *map; > >+ > >+ if (!name || !name[0] || strlen(name) >= RESERVE_MEM_NAME_SIZE) > >+ return -EINVAL; > >+ > >+ if (reserved_mem_count >= RESERVE_MEM_MAX_ENTRIES) > >+ return -1; > > Another thing come to my mind: could we specify several reserve_mem on the > command line? Yes, in fact I have this on my command line that I test with: reserve_mem=2M:0:oops ramoops.mem_name=oops ramoops.console_size=0x100000 reserve_mem=12M:4096:trace trace_instance=boot_mapped@trace > > If so, we may need to check whether names conflict. Yeah, I can add that. Thanks, -- Steve