From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 419D5C27C53 for ; Wed, 12 Jun 2024 04:02:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 567CD6B013D; Wed, 12 Jun 2024 00:02:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 517E86B013E; Wed, 12 Jun 2024 00:02:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 406A96B013F; Wed, 12 Jun 2024 00:02:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 22E236B013D for ; Wed, 12 Jun 2024 00:02:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 96F5F811A4 for ; Wed, 12 Jun 2024 04:02:24 +0000 (UTC) X-FDA: 82220889408.29.0D3075A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf01.hostedemail.com (Postfix) with ESMTP id 9987E4000E for ; Wed, 12 Jun 2024 04:02:22 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718164943; a=rsa-sha256; cv=none; b=IbC6zkYCnwFIksmLwk+wINduGoWgHza+PW5aszUyx2GCCg5rVy8ADj+7izJ3XO9JVJ6J0i euGrLHl8X9XZBX8vjMaKDR72r8PzYpu3GDf7411SIO6zhjrQs7LT3U37v2F6ngNwDeZxQZ IWxj4wuJbKvQgxG7YrQvWJexZk76oAs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718164943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nkOCSo7h5aRzMJ1OzuX0+1j2uzglFSkAC22rmNyM+b8=; b=oZiLJdTiFrvvcLpUAA871sAM8zvshqSEQ7ytd6c1F5E3FVS/Cm2H9YBs+3xlPv/U2jg2PB LssF9CXIsKOoHFNCVMGp5vji8xnjAE/jIFxrAAhIGA83IRJi7e9pQRux/CAh+FKonmvxWB iIFjut7ZAfLZG3EvkNzVAGbcYmO7rvw= Received: by verein.lst.de (Postfix, from userid 2407) id 4EBFD68BEB; Wed, 12 Jun 2024 06:02:17 +0200 (CEST) Date: Wed, 12 Jun 2024 06:02:16 +0200 From: Christoph Hellwig To: Shaun Tancheff Cc: Christoph Hellwig , Shaun Tancheff , Trond Myklebust , Anna Schumaker , Matthew Wilcox , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios Message-ID: <20240612040216.GA25886@lst.de> References: <20240527163616.1135968-1-hch@lst.de> <20240527163616.1135968-2-hch@lst.de> <8e23be47-e542-4bb8-8da7-da7801c98e42@hpe.com> <20240611161311.GA12257@lst.de> <1d87741b-7178-4791-aca2-da3ac3033552@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1d87741b-7178-4791-aca2-da3ac3033552@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: gatd5bqxs89qhtbd99i9m975ykbgsjcq X-Rspamd-Queue-Id: 9987E4000E X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1718164942-480738 X-HE-Meta: U2FsdGVkX1/Hhvf/1H54SHYvKPjqS+sbGZxiF5QlpK7/Bhw4wijksKk6NeE7Ft5d64wCOx5uxWgC+43wDg2gn9vdu0CYONe0v32qJ5l/Jl1rTun0WmqzRXU6d1yj91ldB3jCpFCg04Rp5BVr/tJZc5jYwgMQOjGKpjIp46A4QnfzR3TFgRpUHU1ySK4YSFolPjb1xc6b7hQa2x3+w54db8u2AyzHpizXHKc6EiXERJB4ksnIXwNs4jy8pa3HeWV2OKH7HWGZV61oLGMjav4Gqx9lUjr0pyOPUDf6cfrpaYMHcl0/pGijKbAFzx9YiQbmIgMuFSZELolcFk2t3Cvnpo6AxSv5133Ho7J1BrCYSOemaVtvJZ9oLGptH4woB/jlmvUsvHbPpWRClMt3QOGt27AtQ+8VNirvkVPpn6dgH0jrcj8zAZMasZNOLEvrGIph4ZFi+w7oBDHgOSMQK6cxVOJa4LPuPWAMUKhJpkfvtu4BZr2KuUVRuE9E2AOsxMcv2JTaGa/bCca7YdpX2/mA6dgRP1hHaQFq3+pnzvmoOp6ryuK+scqg2Zd4RGTfjM6kjyQf1npOXqAZRKtYDnArCNtuIG5u8360/nyhyEJM2D/Ub6kxIZ9WSb46Z6w/I5XtHXkjfakn0MtWJSy0BRTst77BA1MninFxlCwFTR1+y8HyIymh81BBIMo/YYDp1oDjHCAvl1B1AQMa1FvBnT8GtyD6mye8IHnx9Uneoz40IlIuna5I7jhvDSur2cPeonnA5IJajzJXUvLeWw8hMGfUD2TUhqMzfxbTG6oQCzCsOSaAL7ZkwbS9+BCFvSRxf2KU4rOCOQ4QrRSnz7Vt/m8+GBY2bmGR9YDOyRrv8LNRFBlCenJ9z+HCL6LG0ErEVGpNIaHKHvlka8zQWcJ+Z4+D28/i0SNeitgm3mvTlH2IpKJP6IBWY09n0rTu/EvkbgizGQOamTIjBG1tMVUruh1 TzuEGeEJ omQdCrVyNVs9KH77cS8RYsCWs9im87Kao9MwfMgQjzTKiGgZ5hMxlsASJ/+ReOFOGVbOlNzMwwcJj+orO/CCYs2eV2LY0y5o0xXybIS+vNGm6q/s3Ikgwi/spcoEUpTQbVzWeD2deKCPq3qE+FO3B/AJtOgIEXBx3zI3OBLokjOfztJj5zXazwFQBxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 12, 2024 at 08:41:01AM +0700, Shaun Tancheff wrote: > On 6/11/24 23:13, Christoph Hellwig wrote: > >> On Tue, Jun 11, 2024 at 05:47:12PM +0700, Shaun Tancheff wrote: >>>> const struct address_space_operations *a_ops = mapping->a_ops; >>>> + size_t chunk = mapping_max_folio_size(mapping); >>> Better to default chunk to PAGE_SIZE for backward compat >>> +       size_t chunk = PAGE_SIZE; >>> >>>> long status = 0; >>>> ssize_t written = 0; >>>> >>> Have fs opt in to large folio support: >>> >>> +       if (mapping_large_folio_support(mapping)) >>> +               chunk = PAGE_SIZE << MAX_PAGECACHE_ORDER; >> I don't think you've actually read the code, have you? > > I checked from 6.6 to linux-next with this patch and my ext4 VM does not boot without the opt-in. Please take a look at the definition of mapping_max_folio_size, which is called above in the quoted patch.