From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A54FC27C75 for ; Tue, 11 Jun 2024 18:30:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B7C86B00C5; Tue, 11 Jun 2024 14:30:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F6EB6B00C6; Tue, 11 Jun 2024 14:30:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F01866B00C7; Tue, 11 Jun 2024 14:30:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D094D6B00C5 for ; Tue, 11 Jun 2024 14:30:04 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8CBC21A145B for ; Tue, 11 Jun 2024 18:30:04 +0000 (UTC) X-FDA: 82219447128.30.8BF7056 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id C8C7218000F for ; Tue, 11 Jun 2024 18:30:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u4wHn2wb; spf=pass (imf06.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718130602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8ewDgG5DNMm0oEeSD3VZZmCo+4mAM4o3h4mlJpAnAdg=; b=cE1H3sOGy8P2XstVpxrgCkxNho/15BdZYP1E1nhsjp/oI7/Ru/0qwO0GM577gewc/IznTf pHrN8vzrOnVG8J0of0MmLVS1FEX2QHUkTM+lB4ot8RjMkbi+KT40YyFysKkGxBzfXoygdN MTD3HMGPv+QhoYMWZFa14RfVwLQGue0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u4wHn2wb; spf=pass (imf06.hostedemail.com: domain of djwong@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718130602; a=rsa-sha256; cv=none; b=mGWLlNAiatvhWLMDzzWYHbmEwguAEmTYT+lxNDQpPw/BapbW4XuZ2r+OEzx8dY+Tp6Xg8y EktdEsxqQbDpuvOPt4eYcUk8Xjchj2lIf3FqppN9K7vXLhotYaDx7ek9AzmwPsAy/Vj3Wd 0O49SmU4ozRRo41NPAHF1FUOWIX9wwg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9D64C61168; Tue, 11 Jun 2024 18:30:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 621C7C4AF67; Tue, 11 Jun 2024 18:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718130600; bh=5EOvWQp68RIcBOSg4YFAnSWecjOyMMJj7nDme+d1s/4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u4wHn2wbBtiahaV8uAu5b30r04/E1lT2osRrSUQBMYaGr0T87eN7bAdoA3h2cA8yH EpzxeJ+aRGrEzrH9vvXzpTsTEdaOFQk7lwUG9n/jmjSm+WHXy0mV1LaPNhnjslIcsi dJOftjE0a3kmEAanBAk53b3DVsMnc4axdHAFl6CkAzoJ60coBQ75YkAXQEESseXAIU E61FXNtkztNh/m97ZI43UX9iIiAMpngeZe7gXFXrZiWdEbkq6P+wqCRcEDVwRaAUvw vRlLJQMqG9e4HWPtNF4/7SidJm7zmZGC79zFpMniPHMKO5R/9Epgx/SvIo0lqmSgbS 6Om99EnfMpTRg== Date: Tue, 11 Jun 2024 11:29:59 -0700 From: "Darrick J. Wong" To: Luis Chamberlain Cc: patches@lists.linux.dev, fstests@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, ziy@nvidia.com, vbabka@suse.cz, seanjc@google.com, willy@infradead.org, david@redhat.com, hughd@google.com, linmiaohe@huawei.com, muchun.song@linux.dev, osalvador@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, hare@suse.de, john.g.garry@oracle.com Subject: Re: [PATCH 5/5] fstests: add stress truncation + writeback test Message-ID: <20240611182959.GZ52987@frogsfrogsfrogs> References: <20240611030203.1719072-1-mcgrof@kernel.org> <20240611030203.1719072-6-mcgrof@kernel.org> <20240611144503.GI52977@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: C8C7218000F X-Rspamd-Server: rspam01 X-Stat-Signature: wsig7g498tyrkfircb7jg71nrpdafeko X-HE-Tag: 1718130602-984065 X-HE-Meta: U2FsdGVkX18WLm+tv9IilKhpUABJIqyGuo8M+f6/oN3+hTbCND55NDmmRohxlWqEZuiaa2+trReuBHqXD/VbZIRRuLJuNb9FiK73wCOo5QcOCbiPeH3sfV+yQUCi3cCSE1AieMtVaqVvc00RVz7g65mfdP9M6gNUyBNdlAMtEDW/5TDHxK2+10BlUI7/YThJfP2CxHvWmPLai9c65bYKSaXePLXesv69wXPtI80viutX7VN+h9L/EmXLFuv4hYz6XCypZqIXDuKex7XATyQrLTNFoKSBxOypItLmoVfPdVUDP0T0EZOatf5UH05wVLcRznqTRGs+LbM5k+zUbAoGKZSIhVRIDTyHAm5dBTU13jorNNqSI8oA33Mx9zWz/gTGEPLP0VfiO4twN2wkcfYBLon4gZJk2+9CyJC+VCrrVEuMI3uoNKu5qSPdQIDPTSmj1y7BOsKb0dhNsAWarhu+6/g72hGCdXELJU5Z2PGyoNJ+Dtkjv9luB3MwLy5/JTbySPzR9In62b5LE7uVlSPuMeWbKRFh2A1Z/93WV6DtYxlw70kjpll3u6KVySSX6HKqRkkg/afZcRXcXxcTHomV2QMPtL9JISUE7Fkasaqul+0qBv0RLj4gJBKkyfyxx3Kr/uL5Wb/nvdpeE3H5HsxNpIU6lFhEqUFBzkCmkjYCTWFfiekDLmRPpbwvb/LDDmU4EQNMtW9L6gHGm8Et/kNYfgfwoBiXhbv19kbcZBOiS/Xx5RjZ+ORrtPjmMmAlO4awOlniqlek2kkI1HkKmYdocI5jI+RRT7upHELDDeB5Y31M+P7NkFJGcv+0Co/pEjsv+ubW8PQrplLFuecyZFcRKfb1C61t6NB8aG17wj1iCLyYi1/1KnpHx3R2BJ8lDcljom696BZRNwzAEqTzwiNA648hGYvw4cMt6WCYu1OV2cPxVkk6zh/V24ne0eT2ejBK4PW/cgxODmUwltfYAAY +NJYOhkc YwJADFn62j9jk3dGbtyo1am9ah2EXXHd7hKK+LLlaS2KJVR0S49SYtZJSvEDGRvjal89W7Z5RFfPPwfVX5yGXVdDisW425aeOSueTqHVJWWZxPccfJr7Anxo6idU3AHQxFlUuN3pEn1Sbd07AGhr8vhBw6E03Zz8L2FqbNWPNGC5GsVTtuHB25xqaM9bxXiNZgoAF2yIL2hJ73qe2MYP4gPGQkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 11:15:52AM -0700, Luis Chamberlain wrote: > On Tue, Jun 11, 2024 at 07:45:03AM -0700, Darrick J. Wong wrote: > > On Mon, Jun 10, 2024 at 08:02:02PM -0700, Luis Chamberlain wrote: > > > +# Requires CONFIG_DEBUGFS and truncation knobs > > > +_require_split_debugfs() > > > > Er... I thought "split" referred to debugfs itself. > > > > _require_split_huge_pages_knob? > > Much better, thanks. > > > > +# This aims at trying to reproduce a difficult to reproduce bug found with > > > +# min order. The issue was root caused to an xarray bug when we split folios > > > +# to another order other than 0. This functionality is used to support min > > > +# order. The crash: > > > +# > > > +# https://gist.github.com/mcgrof/d12f586ec6ebe32b2472b5d634c397df > > > > You might want to paste the stacktrace in here directly, in case the > > gist ever goes away. > > Its not a simple crash trace, it is pretty enourmous considering I > decoded it, and it has all locking candidates. Even including it after > the "---" lines of the patch might make someone go: TLDR. Thoughts? I'd paste it in, even if it's quite lengthy. I don't even think it's all that much if you remove some of the less useful bits of the unwind: "Crash excerpt is as follows: "BUG: kernel NULL pointer dereference, address: 0000000000000036 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 7 PID: 2190 Comm: kworker/u38:5 Not tainted 6.9.0-rc5+ #14 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 Workqueue: writeback wb_workfn (flush-7:5) RIP: 0010:filemap_get_folios_tag+0xa9/0x200 Call Trace: writeback_iter+0x17d/0x310 write_cache_pages+0x42/0xa0 iomap_writepages+0x33/0x50 xfs_vm_writepages+0x63/0x90 [xfs] do_writepages+0xcc/0x260 __writeback_single_inode+0x3d/0x340 writeback_sb_inodes+0x1ed/0x4b0 __writeback_inodes_wb+0x4c/0xe0 wb_writeback+0x267/0x2d0 wb_workfn+0x2a4/0x440 process_one_work+0x189/0x3b0 worker_thread+0x273/0x390 kthread+0xda/0x110 ret_from_fork+0x2d/0x50 ret_from_fork_asm+0x1a/0x30 " --D > > > +if grep -q thp_split_page /proc/vmstat; then > > > + split_count_after=$(grep ^thp_split_page /proc/vmstat | head -1 | awk '{print $2}') > > > + split_count_failed_after=$(grep ^thp_split_page_failed /proc/vmstat | head -1 | awk '{print $2}') > > > > I think this ought to be a separate function for cleanliness? > > > > _proc_vmstat() > > { > > awk -v name="$1" '{if ($1 ~ name) {print($2)}}' /proc/vmstat > > } > > > Otherwise this test looks fine to me. > > Thanks! > > Luis >