From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4CFC27C75 for ; Tue, 11 Jun 2024 16:13:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1AAC6B009B; Tue, 11 Jun 2024 12:13:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCA396B009C; Tue, 11 Jun 2024 12:13:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB9FF6B009F; Tue, 11 Jun 2024 12:13:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9E4CD6B009B for ; Tue, 11 Jun 2024 12:13:20 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F258C121530 for ; Tue, 11 Jun 2024 16:13:19 +0000 (UTC) X-FDA: 82219102518.27.3C18772 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf25.hostedemail.com (Postfix) with ESMTP id BC870A000E for ; Tue, 11 Jun 2024 16:13:17 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718122398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g6XuWN1mzEX7hbzBkG7KeHloAYilIHuQbXCnb1/6tV4=; b=KhnIi1c0jkH/NL4+wZTbpzqAbxBEJstJ+xGPV8/E8GtAqj458c6xeJDOuUL8xrHHPsRH0p arrzGaklCnKpyDpdqNZQ+qfvr7YI2QRdzaKLwQ8ZkIw5Y/Q2we8ahkBgIGva1G3LIbIAzS EQl/I6cQEFi8KlCw1qfk4PWb6cDpaFY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718122398; a=rsa-sha256; cv=none; b=uUA0Uu+q8dUTpxylDoUurWaUvAPw9zThKqVTgzBVprVC6SvCM7xuAsAlCqnbbCq6iTuDuo E6SY1R5wrrxE3vItKpKvHEAAgED0d0S8pJK8ultEgYrrWjL8WxBtatArtTwoJxjZ8tyEq1 XWBC8Pv1FwgV4T1Qtm3MdJvb3Yw5K/o= Received: by verein.lst.de (Postfix, from userid 2407) id 7C5CE68BEB; Tue, 11 Jun 2024 18:13:11 +0200 (CEST) Date: Tue, 11 Jun 2024 18:13:11 +0200 From: Christoph Hellwig To: Shaun Tancheff Cc: Christoph Hellwig , Trond Myklebust , Anna Schumaker , Matthew Wilcox , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios Message-ID: <20240611161311.GA12257@lst.de> References: <20240527163616.1135968-1-hch@lst.de> <20240527163616.1135968-2-hch@lst.de> <8e23be47-e542-4bb8-8da7-da7801c98e42@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8e23be47-e542-4bb8-8da7-da7801c98e42@hpe.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: BC870A000E X-Rspamd-Server: rspam01 X-Stat-Signature: othgmqrfefad67a99ddk8jd8cd96g3cq X-HE-Tag: 1718122397-106356 X-HE-Meta: U2FsdGVkX18frXeCwb7BnvJq4AzWTvPB9gVYMATmO5azU+uxN3mAGob1H2g/KncnvgUPmjGyXEDhOJRuIvsKN1zhqeWBtwHn+TyyU1qE5NEpbReQbfKGg/u5pzKdhGe9ovp2ztdKt8eXfr7B/pmrCIsXGKGPtetP2KZVGtBHN6dklJ3mmNd7wWod+Nc1rBzQoSHlBo+1e2bTi7B4l28SbXKLZyeXRFAvQYwa4VDVSB6My0Pxnwe72BxGtKRQuj6AU0j0NDJTIDQ9Hi9RUaIiONp/h3aBmVh68E7DrFkWINSdkDDB7ftqQkmTqR8j00kG9MXe68zb/qymwXCeSdrI4z9zbfMft1d8QPPoac7bVOrOu2lmMmyAHK73ZCfn0jmZ4mGvnRt7OeDAID9TYKRqrQKsx/UzaTgT9zZbrEMMh0XGT6vUV3lrg7JJ08qzvq2TeEBD2BY5gav/1D1PZganKOrrtqfrhnMhciINtZ3GGiKkFjVR8QAuql0dqcVrazwYmMeORcuzvp+qO9dAMQ5PSaBIQhZCzH1QLsU/xaGVVFNMarIotEeuH/PEdDDEt/pmUzL/kofHxRXc/iFOcL4KNePavs4LaEV8csKN8CKVMJKBAyRVLZ42JssXYluZPFfV81f7dPz1DBP0WH8xrAaa9bCUvosSRCpF9HyV0w5L2+U17mi03DQJEWI9n1cLyB+CIqg8sZTNwKDAl1fWqByQN8OsuvfQs0kuiCZk167aeBUhmwrBw99jDisZjPTog6FzgJCszpq1bkw4+U7kK+xhogah9+fRF89vI9f595uzRtVb1uwQ3WIjhjwDmxxZiNLbQt6zzhBB8yygPY3Bw+pJjhmc9zvhQ9i114HUggGq/w2Vm4rDYvXvYOvhm5/f17dEIovjSwGQRZhQvb4rpQRamZI3L3NScVoGzyXWEk+0N0PsY8pnSqoodhlbLg8Zqnb+BkTlxM1YeGHamMdTF2G +wNQQhXk 1S5TGeyaIOki3M3ll41KfrQIN8vSCli96LsoLrpKO7eYyO4tfouszuGQhz+m0/j5Pb0lyDCIGScPKJfzD+lieqQPOtmLj2h20JYDNwlnOO9AbFNE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 05:47:12PM +0700, Shaun Tancheff wrote: >> const struct address_space_operations *a_ops = mapping->a_ops; >> + size_t chunk = mapping_max_folio_size(mapping); > > Better to default chunk to PAGE_SIZE for backward compat > +       size_t chunk = PAGE_SIZE; > >> long status = 0; >> ssize_t written = 0; >> > > Have fs opt in to large folio support: > > +       if (mapping_large_folio_support(mapping)) > +               chunk = PAGE_SIZE << MAX_PAGECACHE_ORDER; I don't think you've actually read the code, have you?