From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45BB9C27C65 for ; Tue, 11 Jun 2024 19:39:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D2D46B00CB; Tue, 11 Jun 2024 15:39:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 880856B00CC; Tue, 11 Jun 2024 15:39:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 721BC6B00CD; Tue, 11 Jun 2024 15:39:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 530CF6B00CB for ; Tue, 11 Jun 2024 15:39:04 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F10FC141647 for ; Tue, 11 Jun 2024 19:39:03 +0000 (UTC) X-FDA: 82219620966.23.2CB03AA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 449A7C0014 for ; Tue, 11 Jun 2024 19:39:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of "SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718134742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EsCfcZ4MKl2tNfeh78Jv4sokZSesflPs+tenRCc7XAQ=; b=3xoOkE7/jLrDeUDTddP5z6nrCzjqlViLDCqZHXF63i+Cn2so+z0hQPOq8kiuXHdQ4PUGr6 nY/PzFPpFTJ/C282E/HmyABXLJGqay2IAkM+lTRm6q1X7XZqmC9AbeVNPojeNYstuydn/z gRvzNUsA43EdjWxMwVH1wExffIIRLpI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718134742; a=rsa-sha256; cv=none; b=fIZpgiPrxTcZbG9LhyqMObratqK+OenCoDJCtWzIC/i9f4drKhhMmHluPwFB+snLjRXB4K XXyeNT3EUTWVt+p1NxSV5o6X6CaHGg3h7fUOzWc6ZyLqKZtlOMWYZXcqqSsJKnjeH2I5mt P5a64UhE+V6xnj+EDOD1kCCBLMYhNTE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of "SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=hOOK=NN=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7274A611AA; Tue, 11 Jun 2024 19:39:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7AE7C4AF48; Tue, 11 Jun 2024 19:38:57 +0000 (UTC) Date: Tue, 11 Jun 2024 15:39:13 -0400 From: Steven Rostedt To: Wei Yang Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon , Ard Biesheuvel , Mike Rapoport Subject: Re: [PATCH v2 1/2] mm/memblock: Add "reserve_mem" to reserved named memory at boot up Message-ID: <20240611153913.1568be52@gandalf.local.home> In-Reply-To: <20240611111218.71e57e0f@gandalf.local.home> References: <20240606150143.876469296@goodmis.org> <20240606150316.751642266@goodmis.org> <20240611144029.h7egl4aif5mjlrwf@master> <20240611111218.71e57e0f@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 7dedyjt63q8tbpe8ygpce3mr4199kj91 X-Rspamd-Queue-Id: 449A7C0014 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1718134742-649419 X-HE-Meta: U2FsdGVkX19UH2mnC2T4gtPW6XeEm2Z/MEyTmBVvwRlScaT79dCJin/tOMiFdFkPScZGmzWo4br19uFNxJR6b+Pa7QaKqq+CeUlnMQU1cCAwF2M3aunQKk56YTpkpuXWWOZQ7nXHZzr9pig+c3bzFAL2TfnDCKea3EhQphRc8szvpqG+oFe3oTP58CDsLrfX+fmwn1kcec0Agf5T4S082A0hxx9M/LHGXQuRmtRM/DCpQITh0RKUqhSiT2U73mUctTlobl/BDyk62BBeXujPki9NVn3zmxFWQo7IKMElxtJdoJZHi1vi1NqpAwF/r+80XChg1mLjVA+sY5QZPhWt7v2QYdiKfvJeD7iVIbgNJCX25TTY2ISgrGgdRVv7tFSyREdedFNwD5KqjhFDDSXFCGh7Ji+zv77LuqgX9x+mTC7V9harXmoTRZ3msuYSlio3bNSGLVZ5K/NuFVDqOuB3fX8G/OcSD+Nr2CNK+cv+08B65lPur+H+2r2+eTBR5Ev4Cl5Fjl8JYHG1dJUjmCTBFzkX5PJZyEYozUTQpNj3iKirDSAGmuynfO/mJfoVKvWLKayVKILNLR7nGuY6h0tPiQc2eTiAOFsbVsxXP/KM1G6Kt2DeKbJ8vT3L5lG+U+nVKNmUFdsKcGO/uUOx9v6hWVkBcSvR/7yFdRIiZBOn+LapAg4ReJHPahLf7QJ2lusMFjp+7/l1YnlzVJQIvk0NNiGIb+WQZVIFrtUazO3UoCgJhaBvTWo1r14/wBxcllJD10ku0yu/26yXgiNSkBzIg2hKJe/XDx07GfCMU8D9ZKsAfan8I+9XlE0NeF4kIMFEsTYItOC/qVApcpTNrpxpK41c/ZwW8H5E7c+ZQiaI2zp6HAp6RJJ4HidM8salz5l6He6d+qrhOJgzXItNzzs+31An5g+VetJS5mm54O2ESnZCMJ6DhQBw6kAyn8l+un4+1hpPpxG+TaKGEYi6X+k zq0SrXcS 1i41MW+TybsfAG4uAs7rbvRLn/RBgfBYTSRfBvZOrbXYKfnEAF2UJVg/RKJgW/APzzNhGjaqJ1pVX+75MMdlUE+gijjurIad0p9bxRhMtmkLMznYfrlq7CIRtuHEn5MY6z8STrxZ8yd0oj9prJx+XDPDoI8Sak9bkzGHEHBkNqxWE0EwnFxforAawSYDOn2MRK7e2u6/6/KkfqHISjJ2AnvTKO91Zp6xZFLqmUHLs/DLtBp3amxcURaZ4YwYHegLtWLNsXVhso4IKFSgXt5ilf5DWUw1GGIpo3KO3TzKFYecR1a2dbTMx2GuOcgICTJLVB7IL792pxsFu3tNOER0NMsMSVGIk8xmct9kHP0FurIB/kWe2oIIL7e+BB8HNaFFYdFEYpc1XIn6ixZFX7gk8EMG/scwlUD2mleDx6JrGna0W5wg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 11 Jun 2024 11:12:18 -0400 Steven Rostedt wrote: > > >+ p++; > > >+ err = reserved_mem_add(start, size, p); > > >+ if (err) { > > >+ memblock_phys_free(start, size); > > >+ return err; > > >+ } > > >+ > > >+ p += strlen(p); > > >+ > > >+ return *p == '\0' ? 0: -EINVAL; > > > > We won't free the memory if return -EINVAL? I actually copied this from parse_memmap_one() in arch/x86/kernel/e820.c and now looking at it, it's a pretty stupid check. It does: p += strlen(p); which requires p ending with '\0'. So this will likely bug if there is no '\0'. I'm going to remove this, but still check to make sure that the name has some length before the allocation. -- Steve