From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D57C27C77 for ; Tue, 11 Jun 2024 22:23:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E43A6B00EC; Tue, 11 Jun 2024 18:23:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26CA26B00EF; Tue, 11 Jun 2024 18:23:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10D2E6B00F0; Tue, 11 Jun 2024 18:23:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E4BE06B00EC for ; Tue, 11 Jun 2024 18:23:22 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 90E00A2AC5 for ; Tue, 11 Jun 2024 22:23:22 +0000 (UTC) X-FDA: 82220035044.15.5A8DC43 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id D02F240002 for ; Tue, 11 Jun 2024 22:23:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0jIxQgOm; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718144601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E6a4+CIm3/DuDPOGNXsRcBnHzBEBikS3aL/QUIyWtic=; b=ThcY+f4UcaKJSY/fQJJvzQM11585KhDiBuopm2RLAGyXUFSUKYHeBG+C/Ntou+UipjAg3h xOGPqm8NWcsl/KanibMAwwQupDUukEeMTokGMzNtMTGiMCKvU0EpZ0E/DC+XDXO14uApPF 0+4D/8nVTxp6pdNHZ3JqzfTNAFGBeWc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718144601; a=rsa-sha256; cv=none; b=IKN26XTvw8slBGgt57vbM8a0MuhjfkyUc4keSG7KkDaYDl8nx7F25Bk+Znep1OeO7wdUp7 S1O8qczia/sjpOq21Z/9hG8nZD7RQlIOgKkxkhoirvCk7aXqaITlvgAniAPjw9j1smNHFj p5qoIuo1XGO05FemvddfUKR1pMfsd5Q= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0jIxQgOm; spf=pass (imf11.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C36B7611EA; Tue, 11 Jun 2024 22:23:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61DE5C2BD10; Tue, 11 Jun 2024 22:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718144599; bh=N7J/BKFpAmEyLroeB6EgYBai+EdxjrGGyxlJYhRnzzo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0jIxQgOmjhTJF9j2Le1iYYfgjpUM9ZW5eXdch5pbaNr8a+mL+nP0dbaKMlVFofRGy 2DJZVQUoAXGPSGadWc108A+G+L0E+Sts9WHlQ5O7MdIoYO6SbbboHCkZA0yysMeRks leaUZ3XjBh0x7S0wZXH7YMkk2GC9HlQjqlcn561c= Date: Tue, 11 Jun 2024 15:23:17 -0700 From: Andrew Morton To: Mark Brown Cc: Shuah Khan , Muhammad Usama Anjum , Ryan Roberts , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: mm: Make map_fixed_noreplace test names stable Message-Id: <20240611152317.8e72edb3a545a685a2a0b395@linux-foundation.org> In-Reply-To: <20240605-kselftest-mm-fixed-noreplace-v1-1-a235db8b9be9@kernel.org> References: <20240605-kselftest-mm-fixed-noreplace-v1-1-a235db8b9be9@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D02F240002 X-Rspam-User: X-Rspamd-Server: rspam08 X-Stat-Signature: a6jjnqjmoxj4qxdzazncqhe958zxmdn4 X-HE-Tag: 1718144600-112910 X-HE-Meta: U2FsdGVkX1+2UZhKWYA5IVwmxujnszqRKHfpiEGgh4hRQQBRvhSexYSMGBawDHVOQ4HUgN6GBW4lrXit0gDOvRETpsY0fhKkJ8GXqWrw2Nzg2GDcEFIdio/VAhXmL2CFOzLoeAus8BQKKSD0olkPOlniWgnWYTk7Pl1jqSB4r1l8PxgQtuHsutit03c/BMDVW1YN+QuDinv8Bjtu6yPW/v+kazt271zeF6aUHGxzJ8v/b4QNXYlSmn8l7Ktnta9Pjuc5aJT+2yLZyK67st0nhU4FK5KoYLDmPTOpW52kNCo9oskoV5XfhcnNYJ55d5ASXxw2RXtzEqhvwa8WWuSGedWWDD3FDIqQdH8M/apoqOLCBLwoaYzlLKad1iCk1BjXrPF00Q9qCrQYAd142adR9RHlh1qYQzwQPHudaWkIH2AfGOhMy6bbmIWS4W4hN4lVEKCqjlpkp5oEkhgGfD3Nun0W8lzFojWx2TnX+BykRgwia4/8yXZ+ZWXzmWAVmDLHuzRLS7XFyCM962QlzUGnlg/6cMbURBbO6j0sA2Hl3Eoryq5F/Q7z6qVvBWq0diS12aJkaP0AlbuQ9LdaBj3t9N10wiQI0cdjoCeWw+PbEieF8zAnBSJc6/KLpzmP1EFVa2D6VKM9UlRZHZ7Ip3Gd9ezXXaAIFpj8LPaoCLGd8yMrVEUH0rC8xA4L9TLa1vmMKflD2KBZztPqKrun9w/vnIJusYAgxeonG2o0axlDT52e7yFtxCc8rpJ1mXgq2RSnHvvyQ1ycOc40kb1kzCQyfElf4QwksZ+VN4JGx7YRfDFz7Dzm7VaL7n4eKaEi0LslHnDUXIHfTM6xzcBr9AYSAb1UuCLq39P/EJoFHuWdujnfucc3v1Lyw0QpkOPcQUFbUxZmo7aW/oFkrN9VgQYKORM2f0mYOchZk9dParg9CrMj2t4OGke/yFhMUqTB3g4LqX2xvlPh3KxsAZF+aRZ ANKGR7Ac DvTu3L6eVlKyS5ScBxAdj3tLT68ryMIwWNaPUBn8yOukCby1cdo0B+uSieq/BxyUQZ0/+jSPlP64XkIRQB5IWvAm3Uut5ukplcKjwabdJZXougUs/4NFR+nfIVR7JZOpkPwDVyQ5842FUeXRkPgQyE0ph3pBjFB41eU+2JboE3Z33ybWMAAEzf87CGzL1eDlYsmqS9+DEDeH8xgdQxYEiEADrZfsZAhaa+1iRqpB/GdfdslWmZUY+rZTWTbm9iKYmSZEQFgDr8vr2wGF0x+5OzBrxxNJXEJPloBFu3Ih16s/kyF7Cj7XsomU7YkRRT7+VF+v9j6Wf2V9ufhA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 05 Jun 2024 23:36:12 +0100 Mark Brown wrote: > KTAP parsers interpret the output of ksft_test_result_*() as being the > name of the test. The map_fixed_noreplace test uses a dynamically > allocated base address for the mmap()s that it tests and currently > includes this in the test names that it logs so the test names that are > logged are not stable between runs. It also uses multiples of PAGE_SIZE > which mean that runs for kernels with different PAGE_SIZE configurations > can't be directly compared. Both these factors cause issues for CI > systems when interpreting and displaying results. > > Fix this by replacing the current test names with fixed strings > describing the intent of the mappings that are logged, the existing > messages with the actual addresses and sizes are retained as diagnostic > prints to aid in debugging. This sounds fairly annoying and I'm inclined to backport the fix into -stable kernels(?).