From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F598C27C75 for ; Tue, 11 Jun 2024 21:44:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1CD56B00E3; Tue, 11 Jun 2024 17:44:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A5016B00E5; Tue, 11 Jun 2024 17:44:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 845F46B00E6; Tue, 11 Jun 2024 17:44:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 653306B00E3 for ; Tue, 11 Jun 2024 17:44:18 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E27211C141C for ; Tue, 11 Jun 2024 21:44:17 +0000 (UTC) X-FDA: 82219936554.20.1986D52 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 5DE9B4000B for ; Tue, 11 Jun 2024 21:44:14 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=F+cXvwq1; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718142256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8wdnj2RPUNpywaTmVaIrKg5LDfErQYVHsVEZmkylT7g=; b=f09pnPCqW2OKdTyz5td+QFhknGrECtvPGn69GhynqElm9rDN3bArvQW1Hl3RQGbMEul555 RBMFMAG6OuCopmdSor2635S539XhSI7RAIk9oMOrnEg/Lt11uiG3ix9vWFfufWfeO04ydI DOM+yAdtNsNuBjHJR0NAuRsG9Rtpieg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=F+cXvwq1; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718142256; a=rsa-sha256; cv=none; b=ECjzyV6iUSG+heCqPy4xM5ru404ezUxMRSlCjG6BAQaqQ6BPuBP0JQStaqug9z00mwo2XM vX5Ip50UwLYOE9bzrogoHCp1d4/CHBQ623PgLuuunyfq6Q46drHIfqZ0n3urkAyMPozsw1 X6kqkL+gsU3uunBZzgE+bdAKKIeYNOY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B68B2CE1D99; Tue, 11 Jun 2024 21:44:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A6C7C2BD10; Tue, 11 Jun 2024 21:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718142251; bh=MnMMMfKpCzwe5zM46Q5EbI2heIEE2LunZ3AvfWvTS6g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=F+cXvwq1E2TzxC4y2mbbVqf/tGLnfTL2o8VAOeFV12pQ7Iu7bYct4JQXZ+EtFwN7k rGqjg6WRjlAenK2E+/iCAhFqW/WNhMsTRYJcY43kCiht/z4G2QhQc5Di5rHjQyt2Lk 8/A3i9mcX3XNNNebCUrrEHW9Ly/0IHUBh5MrrTms= Date: Tue, 11 Jun 2024 14:44:09 -0700 From: Andrew Morton To: Alice Ryhl Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?ISO-8859-1?Q?"Bj=F6rn_Roy_Baron"?= , Benno Lossin , Andreas Hindborg , Greg Kroah-Hartman , =?ISO-8859-1?Q?"Arve_Hj?= =?ISO-8859-1?Q?=F8nnev=E5g"?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , Trevor Gross , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v7 2/4] uaccess: always export _copy_[from|to]_user with CONFIG_RUST Message-Id: <20240611144409.21840c70387b29eddcf5c2f5@linux-foundation.org> In-Reply-To: <20240528-alice-mm-v7-2-78222c31b8f4@google.com> References: <20240528-alice-mm-v7-0-78222c31b8f4@google.com> <20240528-alice-mm-v7-2-78222c31b8f4@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 5DE9B4000B X-Rspamd-Server: rspam01 X-Stat-Signature: q987zf61jx3qtz7z1td1fxudqu671mwp X-HE-Tag: 1718142254-162463 X-HE-Meta: U2FsdGVkX18xcmI93iMysrp+p+BjNprDdGXLjBQdPmoe/TBmqU6cgI56xs8wmnmyJnyo5TZm0cJcyo5xJx/TuPfS4O/eHbpnM7eI+iV/BiXGP1gY89BbEeGMKz+XHCAMJOpjxvqMRNkHwxClW2HmoyjN7Bkh8bMybqLlbVLejTNj6asZsomsEZ5hu83vhGQ6DziiH4+ce4lGKBCjSfHfdPirggEVRsBTdV0NfUsGnb8SW265T+yxMvhBz/HAYJtntiML9ChbBcxHhUx6GkJ7/6jZmgIRskQ+1YcOowDj3gJLmXzaBz65RLxDC/4zayTPv4y728GekOjhlIziw81IX4aBlCr8u9/oZi4pveTT6Q1qj5QbpZ8Ih49OaWbUpjInJuTGKEYMR+RTCSjUtTfPhCYK4+0UVeGArHvu0s7/ab9SPeYfYjpNoy6LCcwAz4MSrXdicUT9Xsydr6Iwl+KEDJdlVMhkPajRPm0q/Pc4MkaX+uIYo8AUCEMkDFND3s/jbFAecfabXK8y/ByyS8VzMq+f30wD6S0Pjuc19o5OYa5nHzMcjunuWYEzJ59IYqCrHCDb8CVinI8a45vQDh4/cr9HiSKbF3RFteTz0/DoTojY2SR2ZnLlBTyUK0ZGMZa3v310SavWJLGmqG31HvL5ozN6L2Y0kp6f+P1UC+ST4B4TJq5GBwYZhufer9raQ1YHZxdx2A23/LmqrBhdMWUM3AVwV+wikwjOOxEl7689z38uAl3g7oxflI3fmEE9OIilgTJb2I0uRHxqgrY/UJfnzB7sDIsWlTgw4wXvMzxoqxD+AlwjenIgGhbiId7l94FcEHwU4xkpbuVTlTk43MSc639ZhSibSUvel93dX9/IzuHQkmPIsKA0ZQWgnJyHoY1E4u0SuqWwz3fpaYdU7SxB+UXfd7V+Ikl92l85diqQ3N3Gx840lI60Cg/Z4+nS2NM73iooynynBfdK9iYluXu a/pOO3g7 L3nFMYxJHOU/mU7X4fddhwWyLGGAfTs6p4aYE06btvjwBukpqZ1pCaxEEVkJktm1betzwfjKx/9u7R76bha/MPVUDHfhx9n4spSiuBo1EeR908Gj9abGL07jIWkpwlPvPiF+XRAG/x4TCPi4obtNQHuv9qqB1AgdDWIa2nvNB95E5MMk3snILBga8LUiwLd7uhwuElfA/2tNP9SNauvCtBaLWkcoD8mJ9u8fi/4FQn7tC8oyGv19IXBJZyC/fDJLsj7S1MW/f7XbCN9iNBQySiRGPYCwnkomzZvAr7QfpeVC1iGxkl6nVTpjDMudEHTGkNB46RvuYO0MBMWpEybKkn1tFU5n8bt4WDkfBq0dGttHp9wPpKyOr3ZwnGYAtpXukPVL2XZjjYW5lSMqQWxnZHV1ZJNZbG4XN7wBWC182jZ8v/LQ4x0x5eWviOWBH3ce3DYp93sjKTpuxqV4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 28 May 2024 14:58:03 +0000 Alice Ryhl wrote: > Rust code needs to be able to access _copy_from_user and _copy_to_user > so that it can skip the check_copy_size check in cases where the length > is known at compile-time, mirroring the logic for when C code will skip > check_copy_size. To do this, we ensure that exported versions of these > methods are available when CONFIG_RUST is enabled. > > Alice has verified that this patch passes the CONFIG_TEST_USER_COPY test > on x86 using the Android cuttlefish emulator. > > ... > > include/linux/uaccess.h | 46 ++++++++++++++++++++++++++++++++-------------- > lib/usercopy.c | 30 ++++-------------------------- > 2 files changed, 36 insertions(+), 40 deletions(-) Acked-by: Andrew Morton