From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7327C27C75 for ; Tue, 11 Jun 2024 14:35:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 381AB6B0099; Tue, 11 Jun 2024 10:35:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3315D6B009A; Tue, 11 Jun 2024 10:35:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F97B6B009B; Tue, 11 Jun 2024 10:35:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 006196B0099 for ; Tue, 11 Jun 2024 10:35:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9D5CA161331 for ; Tue, 11 Jun 2024 14:35:18 +0000 (UTC) X-FDA: 82218855516.22.7FC949B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id 78DC0C0013 for ; Tue, 11 Jun 2024 14:35:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rDLB1L26; spf=pass (imf28.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718116517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YoeyU9wbd2M0EQW5I8OtfdiqLU47Gbb1Uc8/dvFLeLA=; b=yEvGUyTZi0ynpNb7cvh5G/0ToHpuEikjO6iQHdf0c9gF/bQh4NjOzzETEvoJ0NtBMDilcm MX5Y4+UF6SkdVlLJqATAKN5/vCBnC6HlobvYgUYI5PiO+6EfxUMgC//1rQiaDXDUQr5xS5 t8RPpzN2YoFdkV+/Tt8v+CF8BHg+k9I= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rDLB1L26; spf=pass (imf28.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718116517; a=rsa-sha256; cv=none; b=Jz5C+Y8dIhGNxKLmX9jhkPOJX/dDo6r1E83PZq1+LrpSUveebeuou54Rr4iWA+W7JJznRb nI/QjgTj32ukvQLNPXNe92eDRUQkmtfktagVQeZBPMpDWzDxBIYFkbaeImEju9GaIwnX1o Dk++bkN6kQixAt1RG/PRL9dZ4f2fEOA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A6CA1CE10F6; Tue, 11 Jun 2024 14:35:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D83EFC2BD10; Tue, 11 Jun 2024 14:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718116511; bh=2p+bKisyVsF4x+rjbIUXwa6vK01xzvwWdi8ZNTUWA+g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rDLB1L26mROxSN5Osvk8KPy0pi6Whe3xSQamqRFiViQqvdZAxfLdmME87zRZsqBDq GFTWI7dGzbC29XnwSo+l5b+5Qov56FBnQoGJJDaaeOto/NCbrozwkyaN2wJWsu0lZk FcmUAExX/OfsmhkcMSpn2IEz/r9MsNGO1j/jN7+OoJRT2zAqDR6uZJ5XHIlqKznM4n 95ViaR53UxCa9Jv09j8B3v48en6LvfKwt4ahR9CE7oBMtZY5eKalq9aSKKCG2XRhLK Xz1Ob/1QzpLgEGAYvXLCetrHq4C6QohVqEEqZfm//ox7yJAMiggNhjoVb61W08kyKk kz5n5lLQZgdag== Date: Tue, 11 Jun 2024 07:35:11 -0700 From: "Darrick J. Wong" To: Luis Chamberlain Cc: patches@lists.linux.dev, fstests@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, ziy@nvidia.com, vbabka@suse.cz, seanjc@google.com, willy@infradead.org, david@redhat.com, hughd@google.com, linmiaohe@huawei.com, muchun.song@linux.dev, osalvador@suse.de, p.raghav@samsung.com, da.gomez@samsung.com, hare@suse.de, john.g.garry@oracle.com Subject: Re: [PATCH 4/5] _require_debugfs(): simplify and fix for debian Message-ID: <20240611143511.GH52977@frogsfrogsfrogs> References: <20240611030203.1719072-1-mcgrof@kernel.org> <20240611030203.1719072-5-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611030203.1719072-5-mcgrof@kernel.org> X-Rspam-User: X-Rspamd-Queue-Id: 78DC0C0013 X-Rspamd-Server: rspam01 X-Stat-Signature: g96mh3fufwt8757jyhwj873iwjsi8pgw X-HE-Tag: 1718116516-782135 X-HE-Meta: U2FsdGVkX1+jYRgb5GIiIoJs7t66G+i9tvOY1VZjkYNkQB6Spld+yy9kJKRqEflMd5js/YWTv1Liz3zfS9yrTLhbGT6LPGc7iU2XewAy8XiQZjnlmhAVorYBEoRRx5gc3xchIGowK1FRclL6xK4NLdIeQC63mKFtUqMuWHSZ/n7d10utK+x1Otj9QTlnkXeLIJe6PDYah0hYI3h+UjH02jRHekoTHol9PENluRDDVuvkrpPQe7wwvTVZD4l7xS+c17EuSjAAdP3q3EQnhJZPk/YTH2gEnKlaQEmE9BWtOvxV1WcAyN1gVFTX67B5nbouYzPsd0oSoCoNjBXCqjwUzy8B3/1eS7AFHaHmIzwmNqbNx+X6wnLc3jT8fTL3e13UJo3PpcJxcYLPN93imrvSWmWb9uSrmOJ/B8Qb2361Q+wEmMkdjiraet5ixv/TaFwmDZNdtvUPtwJaI8Hl5R+kOSGdZ49VtdkrrsfR25yiLL7cUTyUTqHr/or5xNzvnNs1/hBDImfKasjc9MvrPmmAaxksx2LJ0+RDmoGKIKljsTGtQsE4Kcn6bMbmtcOmIzTusgiuNePyUP6i/E68jx400T5PGSiz/d6Q9/pJuin5vXG/URKLyPJxaHS/THOI5OLy78w2u0mCaNcfehFHH/Z+CRd/8Ehc3Bz3d1Oe7K/Fq1EFiNDTX5OaJfhCyZenaFdS5Ybq+62YFLKmcD15Go5t2w6jUF750bYGllFRUtSP/pRpmPXcQit5RxrYIZAy33ezuA9bkaYjEGqw+anPjfDRvV8Xs5M73qIpJChm7EvjdsS88hDrMgY07YwZ3yeSu21NUZOquAIDvsEaEoRuKNdd7XWJUDdy/6c9/oSQux5BZiZY7KZA0BHYgDoxcF39WklSVp1apCOuU1QO/znMMQzJzIzRD+M/ojaYjCRdabr27jcVmqTqGImW+V+tipdZVG+uzIiDzkFV03PEq/blXWx Ol5kGaJt jP72GMuroFOAM617QmNLL+TTbHCubFiBrt3WEggorQ9CpZwPAVmydkldtmG4LuZZxkWydM7+aZbH4YaMVVSrUl33zfO8iaB+5XBLLqSWiMj5MIOukTZs5IxPKQUeD+YF7rDfXHGnSNGYaVoVeFc6YfnyF8crtbJZ3P5O8hI3TtJqcun52ACRpymsPr+bxUP9VKNaIKHR+xguw1BWN/1jzDrLx0rV1Ix6BBB88WrY59tvKezdEn1otywotbxdFEcOYBwCF85pgHqmreMXZlrnQXrwuyrMSG3P+AcXu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 10, 2024 at 08:02:01PM -0700, Luis Chamberlain wrote: > Using findmnt -S debugfs arguments does not really output anything on > debian, and is not needed, fix that. AH, right, -S filter the "source" column in /proc/mounts. That's unimportant for fstests, because we really just want to know that the *fstype* is debugfs, which is what -o FSTYPE does. Ignoring my previous questions on this matter, Reviewed-by: Darrick J. Wong --D > Fixes: 8e8fb3da709e ("fstests: fix _require_debugfs and call it properly") > Signed-off-by: Luis Chamberlain > --- > common/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/rc b/common/rc > index 18ad25662d5c..30beef4e5c02 100644 > --- a/common/rc > +++ b/common/rc > @@ -3025,7 +3025,7 @@ _require_debugfs() > local type > > if [ -d "$DEBUGFS_MNT" ];then > - type=$(findmnt -rncv -T $DEBUGFS_MNT -S debugfs -o FSTYPE) > + type=$(findmnt -rncv -T $DEBUGFS_MNT -o FSTYPE) > [ "$type" = "debugfs" ] && return 0 > fi > > -- > 2.43.0 > >