From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C07FC27C65 for ; Tue, 11 Jun 2024 19:57:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 905B98D0003; Tue, 11 Jun 2024 15:57:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B47B8D0002; Tue, 11 Jun 2024 15:57:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A4078D0003; Tue, 11 Jun 2024 15:57:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5D26D8D0002 for ; Tue, 11 Jun 2024 15:57:17 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 10F5A1A0327 for ; Tue, 11 Jun 2024 19:57:17 +0000 (UTC) X-FDA: 82219666914.20.955D642 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 4A5E1100019 for ; Tue, 11 Jun 2024 19:57:15 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JXP0r93T; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718135835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q4I5rjO0wAdzAFSgtTx8CRIYGu0qJv8iO9DBQVomeIo=; b=MRy+uIRk7TtfooLKM6rHLuig5Pea2RHvvOsUa21hvpkmB0WGfIT7dIlOVAZ1kdY/prumX2 Kegor4UicSREL8nsTjUg2xrYHoGqsQkmx+GR6xCnGNVFw7T7gURnO17EHeLbg3NRHr6OZ5 zSyFtdM0WihReUrwB4XIDW1exi08BhU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JXP0r93T; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718135835; a=rsa-sha256; cv=none; b=Qyzr+ZIVnygRKUGHDAZAaePsFa9D1WQKzXKyc6UExQTsbvfC2eE5R6YYxKD68TbmviIK68 dFGtUuJLbMDW+eSkipl805SlylUcjSK9cKIHvVPj7AvBsZ1qvkh/hloW48MRVlbB6juyNw R9VsM14Jin60L6DJfsMLK1EdtVtDNDY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5147A611BB; Tue, 11 Jun 2024 19:57:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A94FFC2BD10; Tue, 11 Jun 2024 19:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718135834; bh=6M1ebK5ksd8fFr0463WqM9S7WBIPDoIGj+N3XpTNpPc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JXP0r93TC6EddhtLwiYV0ZjXHBBlEdNNIljuy8rPFZz9i8xvRmt12ONtRAzQCSzwt 3QZdLA4TSq94RabfXvxKod5pcgr5XD4hgZFDGIRsEWmQbkgIJuYCOyP44PqHjE/an0 pAiTbYjRMIfWLZcfyz6UK4G/Z28FKjxWfKWHmoCU= Date: Tue, 11 Jun 2024 12:57:13 -0700 From: Andrew Morton To: Shubhang Kaushik OS Cc: "ampere-linux-kernel@lists.amperecomputing.com" , Uladzislau Rezki , "linux-arm-kernel@lists.infradead.org" , "cl@linux.com" , "corbet@lwn.net" , "linux-mm@kvack.org" , "guoren@kernel.org" , "linux-doc@vger.kernel.org" , "xiongwei.song@windriver.com" , "linux-riscv@lists.infradead.org" , "linux-csky@vger.kernel.org" , Matthew Wilcox Subject: Re: [PATCH v5] vmalloc: Modify the alloc_vmap_area() error message for better diagnostics Message-Id: <20240611125713.eeef88483f5a782e3df71b21@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4A5E1100019 X-Stat-Signature: 1nw9muyz5s1dmsw174yhp6zu3nbxdgfb X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1718135835-831561 X-HE-Meta: U2FsdGVkX1/YMDc47vPOJBiDzm8kjA1DCl6yehnMX4cUWicAbebKX1OcsXfdUEHIj2mOqaOuWiMXDivDJ3Yo1E6hA6pyFCJWeYug7pQIWuVTv+ugZtqL89PpBsbJlPBWUZbEsRy7b5eI1enJpQDDFLA2V7yuQ9SfdGKsHTzZnRVx+Q6lBj0GTfeg4pspMbPaaaBpLEHxxVKNhiU4Xlc8JDj73z0vZYB464ctI9PqJgiVvX6ZAhwL6ZTgwi/nMZYYftpiOLLor0rpExCqpCUg/DDUzuQ7lJ+3jqz0AhBIHHjVpPN4wxUK0r0Xo5l8wokY/C+h/Gkv1vVg0T/6Tw56qDEG48sfVuo82/KxKQYN2QBN4aVgOaXmOnJrLDQiCf0s8+CAPrlUqo836PLKouEMi+4vWPUQ3HMFG9GHnWnc3aP/xxm2pDpNiKvmq31p1p2bHdoAf85pD50OJtSeIw0a30amiQ7j/tFgNDCIPNtQHqeQ90816owEMcEaQvve7wSVmbnSKcEaORER5F6kK11emMlQ77N2k2QP8AgOSa6csmRq7KGWA2ZpPJDm4DcqFEphvRcb9OH7JMVPyKSojJtIJU297KQLVdZAgHVgHF/N0GuKEFwPqiFntLfeGTfabwtIOtFcuFCYDQBfK/OY7NJJmYb5NKX7KE+5+66G+kIkLQu43hykSZamHYV4i64eqWnFScuhcg6oK0VPCuv3VUH1Ev7lEwA6WUsgT5CvAlUeZ3FjHaVxtD57l/WLWmay6u8CIk1COLJnHsANWudTTddrsNMsPw3oWr6ied35y82CndQVGjYPFKskCmbYa7TxV+THNOt9ReTsIF7NxEaGHq5h/xDTNMR3oZeImC3IDqXmHhcEDKsDCJ5+9cFRzw6X4TVuM/93LkQ7dQxWfUqDL0rW2vFR9GNqJsuBGaC5AEMBUXCSUj2n7ua6X/HQa/WNz/6YunxOlPoKhgEyasR2wKO MY6cCybu rIX2mcpXdRytgHj7lWxLWSEs32LqSqJYfD8Ioz5gPv8+d4ALbU8OHcBFjSPVViXrJzsgc3N8DneGHSsTMy23IKymQ8WJ6+OQSaukp90T5Ui6VKA+zg/YOGQGJsST80ZeGvdGsSKV+DB2MkCGgAuOlswYp++RTGk0oNGy52hu0tAfeQ7RVMt0Cm36HoPOUjOVZd5R3BITBHGl8pyqzKOn3w6h32EFQubL1yylb21uBOMvL+X5qby8gipBEoaPnpF5e3w/+2meG2/KdDrbz4CpfpD9bomdXoSismLTiXCz1Yi13u8KI9j2YpEYteg967d7XqW3p9Su+SkgPfgv2cGhz3mB87FoZZmC/osWxr+TmWBCj2THWXe3DNIZ+rA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 11 Jun 2024 19:38:44 +0000 Shubhang Kaushik OS wrote: > 'vmap allocation for size %lu failed: use vmalloc= to increase size' > The above warning is seen in the kernel functionality for allocation of the restricted virtual memory range till exhaustion. > > This message is misleading because 'vmalloc=' is supported on arm32, x86 platforms and is not a valid kernel parameter on a number of other platforms (in particular its not supported on arm64, alpha, loongarch, arc, csky, hexagon, microblaze, mips, nios2, openrisc, parisc, m64k, powerpc, riscv, sh, um, xtensa, s390, sparc). With the update, the output gets modified to include the function parameters along with the start and end of the virtual memory range allowed. > > The warning message after fix on kernel version 6.10.0-rc1+: > > vmalloc_node_range for size 33619968 failed: Address range restricted between 0xffff800082640000 - 0xffff800084650000 > > Backtrace with the misleading error message: > > vmap allocation for size 33619968 failed: use vmalloc= to increase size > insmod: vmalloc error: size 33554432, vm_struct allocation failed, mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0 > CPU: 46 PID: 1977 Comm: insmod Tainted: G E 6.10.0-rc1+ #79 > Hardware name: INGRASYS Yushan Server iSystem TEMP-S000141176+10/Yushan Motherboard, BIOS 2.10.20230517 (SCP: xxx) yyyy/mm/dd > Call trace: > dump_backtrace+0xa0/0x128 > show_stack+0x20/0x38 > dump_stack_lvl+0x78/0x90 > dump_stack+0x18/0x28 > warn_alloc+0x12c/0x1b8 > __vmalloc_node_range_noprof+0x28c/0x7e0 > custom_init+0xb4/0xfff8 [test_driver] > do_one_initcall+0x60/0x290 > do_init_module+0x68/0x250 > load_module+0x236c/0x2428 > init_module_from_file+0x8c/0xd8 > __arm64_sys_finit_module+0x1b4/0x388 > invoke_syscall+0x78/0x108 > el0_svc_common.constprop.0+0x48/0xf0 > do_el0_svc+0x24/0x38 > el0_svc+0x3c/0x130 > el0t_64_sync_handler+0x100/0x130 > el0t_64_sync+0x190/0x198 When sending an updated version, please describe what was changed since the previous version. After the changelog's ^---$ separator is the usual place. I'm seeing this: --- a/mm/vmalloc.c~vmalloc-modify-the-alloc_vmap_area-error-message-for-better-diagnostics-v5 +++ a/mm/vmalloc.c @@ -2057,7 +2057,7 @@ overflow: if (!(gfp_mask & __GFP_NOWARN) && printk_ratelimit()) pr_warn("vmalloc_node_range for size %lu failed: Address range restricted to %#lx - %#lx\n", - size, addr, addr+size); + size, vstart, vend); kmem_cache_free(vmap_area_cachep, va); return ERR_PTR(-EBUSY); _ which I assume has no effect?