From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1919C27C65 for ; Tue, 11 Jun 2024 18:59:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 383906B00C9; Tue, 11 Jun 2024 14:59:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 333686B00CA; Tue, 11 Jun 2024 14:59:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FADB6B00CB; Tue, 11 Jun 2024 14:59:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EC5DA6B00C9 for ; Tue, 11 Jun 2024 14:59:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 92072A1D59 for ; Tue, 11 Jun 2024 18:59:57 +0000 (UTC) X-FDA: 82219522434.28.8A0ADA5 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id 59AC718000A for ; Tue, 11 Jun 2024 18:59:54 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=CpNB9mt7; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718132395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vH+e3oLjYKgjh/NF0+F3hNDMBS6gfTp/YjQme6nvaM0=; b=lyMDFv2yfCVwa454hTm0Jxlh4lGi90IS4ZdB89dsWbA0mlU/lmnThJC1hvhJ7FqHx58J4I N8CnAJn3pq8Bij+Sz638Xvk3dUjG9DXiSVA/639NJo1VM8ptpqO7UTY/KLxfyACZQUQdju 7v0zGipIdJrCyJIA0fLv5lM7eppPTRQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=CpNB9mt7; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718132395; a=rsa-sha256; cv=none; b=6jOJ5PMq5Ogs+GwPrCQkBjeFlpOhM/9X6SVuvC8CJRe3IifaD+gq6pwrzaA0QlhiLwbk/P uHFKEFreOSgxUQ5J2EdJeN8jty5ObSaLAoP1rUdqErr0xG8s8L4M16tW2KvApgIkJtzkKe VWCxjqZNpQWc55ANsFP6Fug6d3A+lgs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 333A4CE1D83; Tue, 11 Jun 2024 18:59:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D6CBC2BD10; Tue, 11 Jun 2024 18:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1718132391; bh=Z0AdnMQuPM/Bin8KMAQKa4YF3YN0x9Dx2QEDp/iveXM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CpNB9mt7iK6m7a1s7BE80uyrEbYDQ23XIzOC8afqYvNTO/jYEX7DS+XoovRYE4nem 21ezMNwnb8PmAtxttYf9hkWWH9L2USPR8Tcjiz4WqqFzdRWBd9tWstqCEEiEyo23ZW r4O8+3h8XCu4WEkmDHutyhpGUbbwi6EdYxOnu5jc= Date: Tue, 11 Jun 2024 11:59:50 -0700 From: Andrew Morton To: Andrii Nakryiko Cc: linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, gregkh@linuxfoundation.org, linux-mm@kvack.org, liam.howlett@oracle.com, surenb@google.com, rppt@kernel.org, Alexey Dobriyan Subject: Re: [PATCH v4 0/7] ioctl()-based API to query VMAs from /proc//maps Message-Id: <20240611115950.35197b36eafe0a804ecaa0de@linux-foundation.org> In-Reply-To: <20240611110058.3444968-1-andrii@kernel.org> References: <20240611110058.3444968-1-andrii@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 59AC718000A X-Stat-Signature: fpzrp5ix8ngrmguysj8eto86fonba1e1 X-Rspam-User: X-HE-Tag: 1718132394-370660 X-HE-Meta: U2FsdGVkX1+qW94R8mozv1hXdSrYfGZB2lfQo8Tr9Pz6kFy9wwi7kYnm2jzMRfQ+Zwu1Y0o9NvsFYI2QFT1dfG862rFN+Ndbx7IwQqJ9RZHmWUlpkwfbMxy8g5cP6h9AhFgIENTInv+HDCG46TJxEVEGgjMbJy5ufYRkRG5vAfNh2bAF3rubHLMhDlPm1iV3IyGy0XgqvlIFbk6iqUvsTv0niqYcRm99do1MMaJgRCLVlIObj2h5EnVsh85QzN5rZOt85DGggb4WmqoPBl7prx+5f8+Q7ajTrDuQ8XlH2z6JMPB+F4S+3HTr2aa3dNsim4E0IiD6D7+FklPtwKeAP34L6JiiNN+qfuf+tDcaRBg4POjctd2nsZPzXfvDgNhhpmhxMpotL8SFZtnrWvVUOxUe4lVxPwGQRSUvbRTJHqMcGtETqCF0KE5eqILckOoqhNA2j1J5JsRa6iVM4bA/uWDfOJrq9Kj2XZMjbgUPoRC6DFp4Ikvw4NFcI0wfi2u2H76atmHvm/ZSyBOS46Lwli71Qiofk8OTN3sOfJ+iF5N4x/l+y7K20k9MRwVETCj7Ttc3DYhvgnsrn9AYTwBwF2WaCBXukwxTZq0dLZP9VjMqQcWBHuU0bnFlXwuEsnHIUBEqonEwK330y6QA5RMSV7IwOehH6jgPUbgHHXJipswP5fWBm23pqYs5KHEGfYgJE0y6p2FEm/oR9dP4edTcAruZtiY+y0cIwjAmNWPrhR4GSB05WrdiwI2c6m0/xaLE17Cl9cp2Hekji7ID9qElslZ49+C5XrVJHRDep8+8tU8j1kBsXhiHM4gU9DNHydcErQxkwK6tDU3WWceEyM8q3Wwxk4Lz4q9q5TtXVYJX1vgGVmIJGUQxgZeAtDgYgWJu6W4AVvrT8Yu6nWSmdBAIhmW7FPBpBEMUAY3D5VfCs2mVV425CJVhLGo3StBNxprP7/Qc4SbFU6Be6tAPWct MzwOigkg PmYUC6l/Hxg/CHlOeaN6kpDJLkJfWCSWxACLCq166EXgLOTiCINOq9dp8dnZE5DzkXZn8WmXFlQzPyz129hXsNrDbE25cI6LRAx7IWT6GRM9dx3k35BSoimd+0KBgiA1EcsPCl83nWSeVdsWhkcWSvZ9f1QjDWOuKGPsoacOTwbkEwqs6Vj0YcS0AFSD0CQUdpihuVl0fefFv/Xwilns5mC8Xo6qi0X1APOuIhiYR/C57zZPYBz41iy2HeT2SS8EOfu52xEN5JK+j3NyZIjVcgZNeKd4OaOstXDk/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: (Please cc Alexey on procfs changes) On Tue, 11 Jun 2024 04:00:48 -0700 Andrii Nakryiko wrote: > Implement binary ioctl()-based interface to /proc//maps file to allow > applications to query VMA information more efficiently than reading *all* VMAs > nonselectively through text-based interface of /proc//maps file. Looks nice but I'll await further reviewer input. > > ... > > Documentation/filesystems/proc.rst | 9 + > fs/proc/task_mmu.c | 366 +++++++++++-- > include/uapi/linux/fs.h | 156 +++++- > tools/include/uapi/linux/fs.h | 550 ++++++++++++++++++++ > tools/testing/selftests/bpf/.gitignore | 1 + > tools/testing/selftests/bpf/Makefile | 2 +- > tools/testing/selftests/bpf/procfs_query.c | 386 ++++++++++++++ > tools/testing/selftests/bpf/test_progs.c | 3 + > tools/testing/selftests/bpf/test_progs.h | 2 + > tools/testing/selftests/bpf/trace_helpers.c | 104 +++- > 10 files changed, 1508 insertions(+), 71 deletions(-) > create mode 100644 tools/include/uapi/linux/fs.h > create mode 100644 tools/testing/selftests/bpf/procfs_query.c Should the selftests be under bpf/? This is a procfs feature which could be used by many things apart from bpf and it really isn't a bpf thing at all. Wouldn't tools/testing/selftests/proc/ be a more appropriate place?