From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D522C27C55 for ; Tue, 11 Jun 2024 02:14:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E70916B0085; Mon, 10 Jun 2024 22:14:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1F916B0089; Mon, 10 Jun 2024 22:14:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE78A6B008A; Mon, 10 Jun 2024 22:14:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B272E6B0085 for ; Mon, 10 Jun 2024 22:14:28 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2FB4F1C0BEB for ; Tue, 11 Jun 2024 02:14:28 +0000 (UTC) X-FDA: 82216988616.15.AA80CBE Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf27.hostedemail.com (Postfix) with ESMTP id 442B940022 for ; Tue, 11 Jun 2024 02:14:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kvaKkl+w; spf=pass (imf27.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718072065; a=rsa-sha256; cv=none; b=sziUC4a/4EoHqJ/Nie0DeSDE3gZVfD4I7sVXtIZtVivH96aKCt7LyDOXCLIX1HRvRfYsVb xiogee8lTxqbNVsn36gOwVeGIp8ZPXa0UVFOAt0IgLKycFMtmnIWeky9sssUinY4a3pJRS q15TjPmxhqCCnPSr8xR+IxdVFSUZfvk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kvaKkl+w; spf=pass (imf27.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718072065; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b8pZMe5tLOhtQMTyhHDkVRgRGfxx7jB/8jVnL+SLk/k=; b=H+wORO50fwvhPNihESGzDAsTI0McIRFpw2QDT/TkRPlwzRRL45NxeFV8q32aJw2TJzO0Jh Ii5uVJmwQZ0V9uB3YL/UZx4ovLWjB2K8dRfljc+vCkbSGRBKEwKfG1G/D948FNlzBddcUm qQ49W641NtQLDpPEqHCtBzMvCssyO4I= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a6f09eaf420so255263866b.3 for ; Mon, 10 Jun 2024 19:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718072063; x=1718676863; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=b8pZMe5tLOhtQMTyhHDkVRgRGfxx7jB/8jVnL+SLk/k=; b=kvaKkl+wuu/l/WNsdqBoGL50BXvqEmjY8pjNC7pcb9jM/69woUC96ZKyx9mTOn6ffI kh27BNIpnOp6jW1U6P+2UhiXPdGRCi5Sb3mk2mGikIlJKkDBIebGA2EY3TK0WkQ1n8rj Q2xz71xSYTR1dXdR8fNp5CPi6yddBRSl1CqcTYgaw9PY1ja5K2DERIWqnPqX0dvQEh7N rBt40nU/LLpO/wT+R+zd4x08vx/2FXS5UiWDvj+BSJcZqE1o9ocLrW+EmA9ol1BR5PZO b9vf08gnfzsKBSSZaNYPIHR3cDSu2TMHOP378kz8iNHG1XsSQLuzBtopyVsvXn3UFHyP JCrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718072063; x=1718676863; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=b8pZMe5tLOhtQMTyhHDkVRgRGfxx7jB/8jVnL+SLk/k=; b=MJykBIWwIoy6tI6tTQ2ZGUe60CHdvix81kG+R6n+mcwLNBUXAqBGLi8Tbt21gYAzVU OmsXyZnxhsHeAGUla/4x+MqD1efOhq8tQz4b7TQMZRPuGbj5isI07Po/+GY9ve6B2wHS ZZgOd6yhj/wr+3VQjo6JzGDD53auPHGqNLqbW8oe/nvi69VHQ23GYcdYemlwqMlbjyiq 3qjKiNgCVE2DgHBvhnx8EusF2xdlFKMLk11KCZn4DqHUD1+bBqTEgD2dz/qBahXccGaq A/jq1F4b3JBFLa9iU/PJt8zuPCIEcGzBOVE5SdYrHCIaAThEipSAD0SSfsLnFiuUNhbv 4VYg== X-Forwarded-Encrypted: i=1; AJvYcCU5iuQNRaq4mmiXKz+M80TkKsfjba7m2oE5MBQmjjpQPWWxXNaNjwv4zKix849lLL5aLJyadLqkAXBztg1KJC69q84= X-Gm-Message-State: AOJu0YyajFK61tJ4cRA5Oy5Ck1CBU5v1ku5EJa54l8oqNCZ0QwvtlqrN 6wa137/t7kSmVhvrx5iN8wkDLA4/HV7iR+0rXi7pkSCHjnfLHzJe X-Google-Smtp-Source: AGHT+IHLndnHLEdIidZRlflhfxTVqBNZR5kp1EjeHswiQ2VdgxapfNGOo2BZUBezZU02I3BpIC4g9w== X-Received: by 2002:a17:906:398:b0:a66:414c:2abf with SMTP id a640c23a62f3a-a6cd60a189emr763912466b.26.1718072063176; Mon, 10 Jun 2024 19:14:23 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f1d862513sm219900766b.166.2024.06.10.19.14.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Jun 2024 19:14:22 -0700 (PDT) Date: Tue, 11 Jun 2024 02:14:21 +0000 From: Wei Yang To: Leesoo Ahn Cc: rppt@kernel.org, Leesoo Ahn , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/sparse: use MEMBLOCK_ALLOC_ACCESSIBLE enum instead of 0 Message-ID: <20240611021421.seknuy7flwztan33@master> Reply-To: Wei Yang References: <20240610151528.943680-1-lsahn@wewakecorp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240610151528.943680-1-lsahn@wewakecorp.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: wda54m3jknmgqx7br89nwh3jiwjysyx9 X-Rspamd-Queue-Id: 442B940022 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1718072064-418562 X-HE-Meta: U2FsdGVkX1+GhNZz8krld10i3qbA7ggXeeTr8JCUss/anHtXSx2L8Qe7R8TlX+2Q7tSWg3LLYifEvviGG0e93guNVJ6Di5LbDJs7/CjJEYSb+5nzFEty77ZiLHH+IaGAU0e/aTHc8zu0b5h068gN3YHgLJC9ihV4zIQJkvfiC4B6vhqUYeFloQR0TnLioWUhdfgeToN1RUOIlUQIyYzm6lVjhECGIjGma10ftTEADCY4TdiWEluRiz8FWbFizA4Wo8FAP/VgEIB1FBJw4uneyBaevfiFjrFItuPu8xn4riD1dAyq/+SE6f2oh5+zUmU12ftTBNbG+VFlpqsceJCHHwz8r9uzRShj2OqHSeuSZj8PTtIfQbJhzV0vJybpt9lBYVQJ5PHhA2DPK04oOtAbHWHcWUeVemjy9EHMUvIqqucZi7imBiqkPc/5i4ZvKfpU151a0FU/ZWxgYIK5KNifm0ULlQZpQvW3jasFTYv6SPn39J4YMl6+x11liV7dRjc7bZ6Z/qbWOmCN2+BUisuBdGe2H+epJ8AFFOwaP0ugrOPsMvgw0lomqCd3Uc2lT9GuuwJQYub8lWbvLcP1QyOmWBS651Sirrvbc6IQlYyOFwE7U6ASUE+XJMqHjfkvhz3+bcB1H1yk/kBxmN09jq92bvAYgYLL7B1Fxsw4EJbwCEU2Z5Ocl1883ROYjRebL0KCp1dXWjGY968wJLQfoI8Ym8v14UFYKD1szYdSopdKuTeioiVGZbBOND2CH3d0WyApeEsQgTfZIqHmLAAYFUbl9gt5B5o+jAaCnne3WETtH6oEXgJgAo0kDCu3iOLl+1126/NaBD7t7wIpgLp3GOO0R9t56Fntujnt6UoxN1QyvpcmfoubKBndGMan7Mz6jPHvV3wL7V1O+nraqRgdexZS/EFx2SR1Bt6KWr6ODFAz9NKdB75nf3Zqhxi0F/xvkOJ4gW2QFGuUoC3J3O+Vx3a 12pSIuoD 8y6fxtT2mNeSXIo1rxPE4vNI8h5M9mB+EkKZ7i4Xvt/kBQIv28IfWeVWQM8jIKMgpP9fblUWH1gX3C/cEWgkX8GRAt5VATEZ5pgw6GtmktfMy+DneYqHfAQ//lFqJp1shaaQC4Oq1ltnqy/DJs3HGpIzpf73N3q58NY7gI5K9KP/KqB9UknoncNKuSroabSvMz51FlaBaCT3dxj9/soo0PcwhjjSoBU6vwh9ni7nxxfT1fsdzUSTrlef6s7P8SsOUHlKsM/U89DNRq1BsCU+P1fYptbjsuy648DWx5CxwC6U7DG+BlNoOA+mRdogM2AucKRPFqu5uiSBhYF7pCfdfmJR6IdXmzsnkB59qVJcBstPTCy3DbbKfsww5E8f4rqASbKYBpV76/whDOvcbO1otOAsz3uK86jQzCwESDDy/JrvXJ+QAAJJPe/10UYfjIrt1FWvE7xKTIjFzQUj9BopesmftK1oCTa89NgJAm4mBH0K1Xf8xRBIb/m3bEVvs4xtO+JyVkq9kOsJMMDtY22HhEwvjgmYt7KgmNoA7fIMgVt5dR/dXmXKE+m8pyoPSwlhEQSNc4ifyMnTVMCT4fPOdeMfWkKd+MvPcUzg7mgZ3iJKj4fhdvQHpLGPVZFEd4O7D4DhpB1mdgrWnJcMSItpDnchhxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 12:15:28AM +0900, Leesoo Ahn wrote: >Setting 'limit' variable to 0 might seem like it means "no limit". But >in the memblock API, 0 actually means the 'MEMBLOCK_ALLOC_ACCESSIBLE' >enum, which limits the physical address range end based on >'memblock.current_limit'. This could be confusing. > >Use the enum instead of 0 to make it clear. > >Signed-off-by: Leesoo Ahn Reviewed-by: Wei Yang >--- >v1 -> v2: do not rename 'limit' to 'limit_or_flag' >--- > mm/sparse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/mm/sparse.c b/mm/sparse.c >index de40b2c73406..cf93abc542ca 100644 >--- a/mm/sparse.c >+++ b/mm/sparse.c >@@ -351,7 +351,7 @@ sparse_early_usemaps_alloc_pgdat_section(struct pglist_data *pgdat, > again: > usage = memblock_alloc_try_nid(size, SMP_CACHE_BYTES, goal, limit, nid); > if (!usage && limit) { >- limit = 0; >+ limit = MEMBLOCK_ALLOC_ACCESSIBLE; > goto again; > } > return usage; >-- >2.34.1 > -- Wei Yang Help you, Help me