From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D16C27C55 for ; Mon, 10 Jun 2024 20:15:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 992056B009D; Mon, 10 Jun 2024 16:15:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9401B6B009F; Mon, 10 Jun 2024 16:15:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E07C6B00A0; Mon, 10 Jun 2024 16:15:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 60B586B009D for ; Mon, 10 Jun 2024 16:15:31 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0293041151 for ; Mon, 10 Jun 2024 20:15:30 +0000 (UTC) X-FDA: 82216084062.29.46A441F Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf04.hostedemail.com (Postfix) with ESMTP id DB33740008 for ; Mon, 10 Jun 2024 20:15:28 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=wPD4783f; spf=pass (imf04.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718050529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f846KB3AW4c2nFZH9X4EH/MCA/jm3hltyAr3O7+b0XI=; b=QDMxP4DmC/kk4hJWh+k5AbIffS1iFF/1Ht5dxPOFp6WOVIjnnWsInTYICWdk3gQVp2+Mss l1OJBRTxeTgc7nn6ksZ6oCLmrvO42rzoaRQG5Z8pybmbFaFVk5lig+sTn2D7VZJyCgfu+5 lult7keti9l6y/ljlpBDZwSKgT99Mhc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718050529; a=rsa-sha256; cv=none; b=dRiJfNsPc59MVwx8abTUJMJaj1hJGBIvwxs8SkXqqxo7CxySmU9aDSJMCp7eOSYXsH55O0 BrzTkpzSwdxvydjBTlu4AwJhaBfTGMYmgPTTrhfXYwUKz0Nvtpmy3GwbE8lnG+d/6Wdm6A 7hhETVV/CIxLcqtzAZJIy3G7fRobIX4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=wPD4783f; spf=pass (imf04.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7955f3d4516so141720285a.1 for ; Mon, 10 Jun 2024 13:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1718050528; x=1718655328; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f846KB3AW4c2nFZH9X4EH/MCA/jm3hltyAr3O7+b0XI=; b=wPD4783fjklKAKZx3pdWNewL38zIRVXidS+1R8GmnFT6228YHnbTAltM65I9mnbpgz Zo7O6uXRVRbAPrSxyGrwFxBeUHN3BVgnGgGy7sIA3b4gQr1B5bKFgHcRIg5HUdYj3FBW 0jT8Ea+o2YfsIAZWyWfucmwh/iuCN2HKqr6GVaUtJY6JLQyS+7PSGNva6v0Nl3iI+gav ZECBlN3Z2pOu/xz/CstL/95mbA7TNyS8y+0xb/2Lh+bNLfoBUDQJaFqtyEVkSCeZ8L4h 7fk4CUrXak2a5IduOBmCFyK5kbG6EbfOFfrF7oJONDwKoICiSL7H4MWtZvjpzlSiadNK HBZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718050528; x=1718655328; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f846KB3AW4c2nFZH9X4EH/MCA/jm3hltyAr3O7+b0XI=; b=vAKAvw//f6uT4O+KHU9j33xCmkIkDogtAKNsziMf8or/lFSkHgpTp+/t8PdClceke4 GZzXSCocZD+CD+OOJIHVIem4aTJBFLSMpsgLB6ifL+51gRFBm1LX6wFYYwkyr6TTVzm3 VOQeQZoOUyXQhJknq8Jil2y4C47w/kr74JCOHQL4ghfrBBXoPEZxp4pUzdk0Z1Re00YX 5PTvLnpA0WUYVwakZVjP10Tr39k7wULa/+RN1xT78Owu1u+cuSKpsKvAD2FBJl/p9/Lq uVg6mSF5d2RavAbz4DzspMNsZ9KR0/twhlx5OlkM+aO6c1QmudQ1xSpLtlPRscYUmokR MANQ== X-Forwarded-Encrypted: i=1; AJvYcCWMylXx1IHH/l6Eaw4YZjet3Sm5VD5yPNQIR1sl0bIfcnKa5K7je/F07uPI2H1hckhy2+qgzpY2Y1y8/BkoFM8Pe3E= X-Gm-Message-State: AOJu0YxDJy8A+WpBbt2BUJF9CfwRF6LXEptRPVqLOhVAJmiCZJqJrhQP 1ni4GGxvTkKnPvX4ihRac+QAIwdaatVjo8M3cGrqL0wECOTEORA0vI8UnEu8mHo= X-Google-Smtp-Source: AGHT+IEAxxhl9X6MeL09eAr6w5axAZ6/2hC70TjPpot+ne0b5eqMoN833OwVY4njvMPTbqSJ6S8YyQ== X-Received: by 2002:a05:620a:294a:b0:795:498b:5fda with SMTP id af79cd13be357-797c2da0038mr127591585a.22.1718050527911; Mon, 10 Jun 2024 13:15:27 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79689c09e28sm111635985a.121.2024.06.10.13.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 13:15:27 -0700 (PDT) Date: Mon, 10 Jun 2024 16:15:26 -0400 From: Johannes Weiner To: Usama Arif Cc: akpm@linux-foundation.org, willy@infradead.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH] mm: Do not start/end writeback for pages stored in zswap Message-ID: <20240610201526.GA2407021@cmpxchg.org> References: <20240610143037.812955-1-usamaarif642@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240610143037.812955-1-usamaarif642@gmail.com> X-Stat-Signature: rdeon1ejb6hrdj6pas7hd6yk6xukrm7y X-Rspamd-Queue-Id: DB33740008 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1718050528-682615 X-HE-Meta: U2FsdGVkX182cnLb0/87PstS6jl72WGYbyrQgRCsDiots3B/1eqpG0we/llF9fCmZ7fVbnOwhpLnJI6Dykg1vtow0kGXaFhTIi0kP897DUcRbbnJg/95+tBoijKEaZUQLOJVoxWVVQEz22Pq3JE7ydKK7zb0tTQUw3Jog9ytRWMLtSzjFMQp2QBqhjX5OzKRwb2TQGAilKpvEi9FNlhH3nUoiSGAEoZVziGUf9FVQBVe+ioJmT0ITnLNHkd/UVdJCGbDFktZdIZI/8BWh5llWsSD5FCuq9SETGl3s6bppNY9A2tYTV/LB2uIxGuiDG7Y5WFtjt+h4BbxNF2PFlIKtOe5A+2Kif7Nr3uAgXLOjeEVl7UpIw+DVl6d2O0j0wM+YRRN2yaIbBxtvkAS8Ejuwid7to3rEGp9/YFWV7jHbZesLbUxJ50wk3nNNzH0ebOznpXhlOE7K8t3xpe4YlS7D1CUUEvsOUxxkM7hC1kHbydoTj0EcYFTZn/41nPrdadwFeX+9RI45UcpyDV2H+9UkssypcY7jqxHd6Yqs2alVS3a+Qd3EGxeXtivMV97ooDkIWptZt2r0fuMhLloQjwTrBGCaDvQsyfR6VCbQ7iFXrJlx4umHPlYwrNWiYysSeY/KqPcNeBFrKOvD4CO8evNLY9ji1AnCnPlzJ7sMb8U988NDuM1BQjO29zStUDUkpW3P+i29ujjh6pRU593YNjzhR7bwIdMcgaAmMhFzr1lrwBXRk9wrat//VpG00GCaZ5keP5t6AVBrOcIQYm6CVlwd6Ma0soVLg7Wi2L9TYXybYPk1+T8tR4N142mvZzHzqF3DJAftEWntSUvzlbeW8butWcVi4T1jySYJX2TkGZBKNku0j4s3bCF0WH6TH+8zyNfNCnJa115xsBzejpPfLRrwF3xM55zyJFUZ/B2IsbGXNygMBzkvbCpW8yRqnowPvdE/km4y0x4PpVY5dpbBNH Do8iI/Lp RxoiM3eOjPxbEGsy/GL+TsLbLJENxBJM+PnGREmQsWtkr/0uZFc2X9hdJG3FAvAucpWQhzhfUr8WSm5wC4wyT2c5kbtqiF/icHhSuATNNfAF5R1GumB4TXY0x/VJEWWsXM99Wd3v96wWtOnjM5/+RKdSf9zMog9oVCBggYpIwBF7CAfauO7SWA7/2pbr2rSolLcD9KvzfVnijmRCw6sniIurwUDElyNsup3qWuSObG4Hi6T40vl62OVYWcrdKv0sgCg7m1GRX8et+vAxkqiSTP+fLq821u787Wpy1bNk/FciEEUUZF78BZwj/T89fEiX6WHmIFB3ur84T6U6QqNIDa/pNGCnPrfpcJHAmg3AlbO+xU8oR6KLLu0eL7qCx4IkNNa+HBp+QSGwYvlVtolcnZF34yaU3vVTCryKCQPsxk0ZxTo8gu+R3uWcruHq8RhhaWxmP7v4996AuDNGFJe6zYeEK+5ZkgycHX5TQHUm0pu8gu23HyzQJv5yF6EstD/YiBD11pyEXvIQlMu9E4au5rp5TrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000080, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 10, 2024 at 03:30:37PM +0100, Usama Arif wrote: > start/end writeback combination incorrectly increments NR_WRITTEN > counter, eventhough the pages aren't written to disk. Pages successfully > stored in zswap should just unlock folio and return from writepage. > > Signed-off-by: Usama Arif I also don't see anything in those start and end calls that wouldn't be pointless churn for these pages. Acked-by: Johannes Weiner