From: Johannes Weiner <hannes@cmpxchg.org>
To: Usama Arif <usamaarif642@gmail.com>
Cc: akpm@linux-foundation.org, willy@infradead.org,
yosryahmed@google.com, nphamcs@gmail.com,
chengming.zhou@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH] mm: Do not start/end writeback for pages stored in zswap
Date: Mon, 10 Jun 2024 16:15:26 -0400 [thread overview]
Message-ID: <20240610201526.GA2407021@cmpxchg.org> (raw)
In-Reply-To: <20240610143037.812955-1-usamaarif642@gmail.com>
On Mon, Jun 10, 2024 at 03:30:37PM +0100, Usama Arif wrote:
> start/end writeback combination incorrectly increments NR_WRITTEN
> counter, eventhough the pages aren't written to disk. Pages successfully
> stored in zswap should just unlock folio and return from writepage.
>
> Signed-off-by: Usama Arif <usamaarif642@gmail.com>
I also don't see anything in those start and end calls that wouldn't
be pointless churn for these pages.
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2024-06-10 20:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 14:30 Usama Arif
2024-06-10 17:31 ` Yosry Ahmed
2024-06-10 18:11 ` Usama Arif
2024-06-10 18:29 ` Yosry Ahmed
2024-06-10 19:08 ` Shakeel Butt
2024-06-10 20:05 ` Yosry Ahmed
2024-06-10 20:15 ` Johannes Weiner [this message]
2024-06-11 9:53 ` Chengming Zhou
2024-06-11 15:59 ` Usama Arif
2024-06-11 17:16 ` Shakeel Butt
2024-06-11 17:28 ` Yosry Ahmed
2024-06-12 10:01 Usama Arif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240610201526.GA2407021@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=usamaarif642@gmail.com \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox